Page MenuHomePhabricator

Regnerate XHPAST with Bison 3.0.4
ClosedPublic

Authored by epriestley on Apr 29 2016, 1:29 PM.
Tags
None
Referenced Files
F13996921: D15820.diff
Thu, Oct 24, 1:03 AM
F13996425: D15820.diff
Wed, Oct 23, 9:04 PM
F13970529: D15820.id.diff
Thu, Oct 17, 8:13 AM
Unknown Object (File)
Sep 27 2024, 12:31 PM
Unknown Object (File)
Sep 26 2024, 5:20 AM
Unknown Object (File)
Sep 10 2024, 8:35 AM
Unknown Object (File)
Sep 5 2024, 8:00 PM
Unknown Object (File)
Sep 5 2024, 8:00 PM
Subscribers
None

Details

Summary

See rARC3ffed59. I think that test failure is some sort of weird parser generator bug in Bison 3.0.2 that appears to affect Ubuntu and OS X, at a minimum.

I don't immediately see what the acutal issue is, nor can I find anything suspicious in the changelog. However, I can reproduce the issue reliably locally (OS X).

If I do this:

$ git checkout master
$ git clean -df
$ ./scripts/build_xhpast.php

...I get test failures in arc.

If I do this:

$ git checkout bison304 # This change
$ git clean -df
$ ./scripts/build_xhpast.php

...I get clean tests.

The actual AST/parser look fine to me from careful inspection, too.

Test Plan

Added a now-passing unit test.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Regnerate XHPAST with Bison 3.0.4.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: richardvanvelzen, chad.

Underlying change was:

  • Install binson version 3.0.4.
  • Run make cleanall.
  • Run make.

Spooky!

iiam

This revision is now accepted and ready to land.Apr 29 2016, 1:46 PM
This revision was automatically updated to reflect the committed changes.