Page MenuHomePhabricator

Add support for exponentiation
Needs ReviewPublic

Authored by joshuaspence on May 3 2017, 12:00 PM.
Tags
None
Referenced Files
F17652921: D17817.diff
Sat, Jul 12, 7:13 AM
F17625499: D17817.diff
Thu, Jul 10, 3:17 AM
Unknown Object (File)
May 29 2025, 9:18 AM
Unknown Object (File)
May 14 2025, 3:00 PM
Unknown Object (File)
May 10 2025, 1:45 PM
Unknown Object (File)
Apr 26 2025, 10:53 AM
Unknown Object (File)
Apr 18 2025, 1:39 PM
Unknown Object (File)
Apr 15 2025, 10:14 AM

Details

Summary
Test Plan

Added a test case.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 16771
Build 22375: Run Core Tests
Build 22374: arc lint + arc unit

Unit TestsFailed

TimeTest
44 msPHPASTParserTestCase::Unknown Unit Message ("")
Assertion failed, expected values to be equal (at PHPASTParserTestCase.php:120): Parser output for "base-pass.php.test". Expected vs Actual Output Diff --- Old Value
22 msPHPASTParserTestCase::Unknown Unit Message ("")
Assertion failed, expected values to be equal (at PHPASTParserTestCase.php:120): Parser output for "base-pass.php.test". Expected vs Actual Output Diff --- Old Value
1 msAbstractDirectedGraphTestCase::Unknown Unit Message ("")
1 assertion passed.
0 msAbstractDirectedGraphTestCase::Unknown Unit Message ("")
1 assertion passed.
0 msAbstractDirectedGraphTestCase::Unknown Unit Message ("")
1 assertion passed.
View Full Test Results (2 Failed · 383 Passed · 2 Skipped)

Event Timeline

I definitely did something wrong here, because I updated src/parser/xhpast/parser_tokens.php by hand...

Because the token values have shifted pretty much all test cases have bad data :(

It will probably be a lot easier to handle after something like D17802#214972 is implemented.

wow exactly what the language desperately needed

I bet there are as many as 0 uses for this in our small million-line codebase