Reorder remarkup block rules for consistency with PhabricatorMarkupEngine
ClosedPublic
Actions

Authored by richardvanvelzen on May 6 2016, 8:54 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUc0370f2f3c14: Reorder remarkup block rules for consistency with PhabricatorMarkupEngine

Summary

I got consistent failures on the remarkup tests. This resolves that issue by bringing the order in line with the order used in PhabricatorMarkupEngine::newMarkupEngine

Test Plan

No more failures when running arc unit src/markup/engine/PhutilRemarkupEngine.php

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

richardvanvelzen updated this revision to Diff 38201.May 6 2016, 8:54 AM

richardvanvelzen retitled this revision from to Reorder remarkup block rules for consistency with PhabricatorMarkupEngine.

richardvanvelzen updated this object.

richardvanvelzen edited the test plan for this revision. (Show Details)

richardvanvelzen added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 6 2016, 8:54 AM

Herald added a subscriber: Korvin. · View Herald Transcript

We should probably give blocks an explicit ordering at some point like rules have, I suppose.

This revision is now accepted and ready to land.May 6 2016, 2:42 PM

Closed by commit rPHUc0370f2f3c14: Reorder remarkup block rules for consistency with PhabricatorMarkupEngine (authored by richardvanvelzen, committed by richardvanvelzen). · Explain WhyMay 6 2016, 2:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

markup/

engine/

__tests__/

PhutilRemarkupEngineTestCase.php

6 lines

Diff 38204

View Options

src/markup/engine/tests/PhutilRemarkupEngineTestCase.php

Reorder remarkup block rules for consistency with PhabricatorMarkupEngineClosedPublicActions