Paths

Table of Contentst

Differential D15814

Update xhpast linter rules for new function AST format
ClosedPublic
Actions

Authored by richardvanvelzen on Apr 28 2016, 3:03 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 22, 7:15 PM

	Unknown Object (File)
	Tue, Nov 19, 6:25 PM

	Unknown Object (File)
	Mon, Nov 18, 4:34 AM

	Unknown Object (File)
	Thu, Nov 14, 8:53 PM

	Unknown Object (File)
	Tue, Nov 12, 7:17 PM

	Unknown Object (File)
	Sat, Nov 9, 11:29 PM

	Unknown Object (File)
	Tue, Nov 5, 8:50 PM

	Unknown Object (File)
	Fri, Nov 1, 1:28 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARC3ffed59bd7fb: Update xhpast linter rules for new function AST format

Summary

See D15678. A node containing a return type hint is added right before the statement body node. This updates all relevant linter rules to now retrieve the body from the correct index.

Test Plan

Ran arc unit --everything, inspected every single message to make sure all xhpast test cases succeeded. Also grepped for getChildByIndex(5 and getChildOfType(5.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

richardvanvelzen updated this revision to Diff 38095.Apr 28 2016, 3:03 PM

richardvanvelzen retitled this revision from to Update xhpast linter rules for new function AST format.

richardvanvelzen updated this object.

richardvanvelzen edited the test plan for this revision. (Show Details)

richardvanvelzen added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 28 2016, 3:03 PM

Herald added a subscriber: Korvin. · View Herald Transcript

Those test cases are unrelated version issues.

This revision is now accepted and ready to land.Apr 29 2016, 12:24 PM

Closed by commit rARC3ffed59bd7fb: Update xhpast linter rules for new function AST format (authored by richardvanvelzen, committed by richardvanvelzen). · Explain WhyApr 29 2016, 12:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistAbstractMethodBodyXHPASTLinterRule.php

2 lines

ArcanistInterfaceMethodBodyXHPASTLinterRule.php

2 lines

ArcanistReusedAsIteratorXHPASTLinterRule.php

2 lines

ArcanistReusedIteratorReferenceXHPASTLinterRule.php

2 lines

ArcanistStaticThisXHPASTLinterRule.php

2 lines

ArcanistToStringExceptionXHPASTLinterRule.php

2 lines

ArcanistUndeclaredVariableXHPASTLinterRule.php

2 lines

ArcanistUselessOverridingMethodXHPASTLinterRule.php

2 lines

Diff 38106

src/lint/linter/xhpast/rules/ArcanistAbstractMethodBodyXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistInterfaceMethodBodyXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistReusedAsIteratorXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistReusedIteratorReferenceXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistStaticThisXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistToStringExceptionXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistUndeclaredVariableXHPASTLinterRule.php

Loading...

src/lint/linter/xhpast/rules/ArcanistUselessOverridingMethodXHPASTLinterRule.php

Loading...