Page MenuHomePhabricator

Update xhpast linter rules for new function AST format
ClosedPublic

Authored by richardvanvelzen on Apr 28 2016, 3:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 5:44 PM
Unknown Object (File)
Sun, Mar 17, 8:40 PM
Unknown Object (File)
Sun, Mar 17, 7:47 PM
Unknown Object (File)
Sun, Mar 17, 6:53 PM
Unknown Object (File)
Sun, Mar 17, 6:47 PM
Unknown Object (File)
Sun, Mar 17, 5:35 PM
Unknown Object (File)
Wed, Mar 13, 7:15 PM
Unknown Object (File)
Wed, Mar 13, 1:56 PM
Subscribers

Details

Summary

See D15678. A node containing a return type hint is added right before the statement body node. This updates all relevant linter rules to now retrieve the body from the correct index.

Test Plan

Ran arc unit --everything, inspected every single message to make sure all xhpast test cases succeeded. Also grepped for getChildByIndex(5 and getChildOfType(5.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

richardvanvelzen retitled this revision from to Update xhpast linter rules for new function AST format.
richardvanvelzen updated this object.
richardvanvelzen edited the test plan for this revision. (Show Details)
richardvanvelzen added a reviewer: epriestley.
epriestley edited edge metadata.

Those test cases are unrelated version issues.

This revision is now accepted and ready to land.Apr 29 2016, 12:24 PM
This revision was automatically updated to reflect the committed changes.