Page MenuHomePhabricator

Add nullable type hint support to xhpast
Needs ReviewPublic

Authored by richardvanvelzen on Apr 28 2017, 8:43 AM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4334: Support PHP5.4+ syntax in XHPAST
Summary

Ref T4334. This implements a new node type for type hints in general, and uses them to add nullability to a type hint.

Test Plan

Added test cases.

Diff Detail

Repository
rPHU libphutil
Branch
nullable-type-hints
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 16732
Build 22321: arc lint + arc unit

Event Timeline

src/parser/xhpast/__tests__/data/nullable-type-hints.php.test
1

Darn

Remove copy-flag from new unit test (caused by copy-via-IDE)

For real now :(

This does not appear to have any impact on arc/lint.

richardvanvelzen edited the summary of this revision. (Show Details)May 1 2017, 1:43 PM
epriestley edited edge metadata.May 1 2017, 1:44 PM

(This and the other change look good to me, I just want to look at them in more detail and maybe take a stab at fixing the awful unreadable test cases while we're here.)

Sure, no problem. Let me know if there is something I can do to help