Differential D17802

Add nullable type hint support to xhpast
Needs ReviewPublic
Actions

Authored by richardvanvelzen on Apr 28 2017, 8:43 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4334: Support PHP5.4+ syntax in XHPAST

Summary

Ref T4334. This implements a new node type for type hints in general, and uses them to add nullability to a type hint.

Test Plan

Added test cases.

Diff Detail

Repository

rPHU libphutil

Branch

nullable-type-hints

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16732
Build 22321: arc lint + arc unit

Event Timeline

richardvanvelzen created this revision.Apr 28 2017, 8:43 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 28 2017, 8:43 AM

Herald added subscribers: Firehed, Korvin. · View Herald Transcript

richardvanvelzen added inline comments.Apr 28 2017, 8:44 AM

src/parser/xhpast/__tests__/data/nullable-type-hints.php.test
1	Darn

Remove copy-flag from new unit test (caused by copy-via-IDE)

For real now :(

This does not appear to have any impact on arc/lint.

richardvanvelzen edited the summary of this revision. (Show Details)May 1 2017, 1:43 PM

(This and the other change look good to me, I just want to look at them in more detail and maybe take a stab at fixing the awful unreadable test cases while we're here.)

Sure, no problem. Let me know if there is something I can do to help

richardvanvelzen mentioned this in D17817: Add support for exponentiation.May 3 2017, 12:30 PM

joshuaspence added a subscriber: joshuaspence.May 3 2017, 12:34 PM

epriestley mentioned this in D17819: Make PHPAST parser tests stable and human-readable.May 3 2017, 5:07 PM

epriestley mentioned this in T4334: Support PHP5.4+ syntax in XHPAST.May 3 2017, 5:24 PM

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

	nullable-type-hints.php.test
	variadic.php.test

497 lines

php-callable-typehint.php.test

14 lines

php-syntax.php.test

56 lines

return-type.php.test

168 lines

variadic.php.test

28 lines

bin/

PhutilXHPASTBinary.php

2 lines

parser_nodes.php

1 line

support/

xhpast/

1 line

17 lines

3968 lines

1 line

22 lines

194 lines

2 lines

Diff 42806

View Options

src/parser/xhpast/tests/data/nullable-type-hints.php.test

View Options

src/parser/xhpast/tests/data/php-callable-typehint.php.test

View Options

src/parser/xhpast/tests/data/php-syntax.php.test

View Options

src/parser/xhpast/tests/data/return-type.php.test

View Options

src/parser/xhpast/tests/data/variadic.php.test

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

View Options

src/parser/xhpast/parser_nodes.php

View Options

support/xhpast/generate_nodes.php

View Options

support/xhpast/parser.y

View Options

support/xhpast/parser.yacc.cpp

View Options

support/xhpast/parser_nodes.php

View Options

support/xhpast/scanner.lex.hpp

View Options

support/xhpast/scanner.lex.cpp

View Options

Add nullable type hint support to xhpastNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42806

src/parser/xhpast/__tests__/data/nullable-type-hints.php.test

src/parser/xhpast/__tests__/data/php-callable-typehint.php.test

src/parser/xhpast/__tests__/data/php-syntax.php.test

src/parser/xhpast/__tests__/data/return-type.php.test

src/parser/xhpast/__tests__/data/variadic.php.test

src/parser/xhpast/bin/PhutilXHPASTBinary.php

src/parser/xhpast/parser_nodes.php

support/xhpast/generate_nodes.php

support/xhpast/parser.y

support/xhpast/parser.yacc.cpp

support/xhpast/parser_nodes.php

support/xhpast/scanner.lex.hpp

support/xhpast/scanner.lex.cpp

support/xhpast/xhpast.cpp

Add nullable type hint support to xhpast
Needs ReviewPublic
Actions

Revision Contents
Changeset List

src/parser/xhpast/tests/data/nullable-type-hints.php.test

src/parser/xhpast/tests/data/php-callable-typehint.php.test

src/parser/xhpast/tests/data/php-syntax.php.test

src/parser/xhpast/tests/data/return-type.php.test

src/parser/xhpast/tests/data/variadic.php.test