Differential D15833

Add unpack support to xhpast
ClosedPublic
Actions

Authored by richardvanvelzen on May 2 2016, 3:02 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU0709cd5cfc26: Add unpack support to xhpast

Test Plan

cd support/xhpast
make cleanall
make
cd ../../
scripts/build_xhpast.php
arc unit

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

richardvanvelzen updated this revision to Diff 38140.May 2 2016, 3:02 PM

richardvanvelzen retitled this revision from to Add unpack support to xhpast.

richardvanvelzen updated this object.

richardvanvelzen edited the test plan for this revision. (Show Details)

richardvanvelzen added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 2 2016, 3:02 PM

Herald added a subscriber: Korvin. · View Herald Transcript

richardvanvelzen added inline comments.May 2 2016, 3:06 PM

support/xhpast/parser.y
1108–1111	I've updated this part to match PHP 7's behaviour. Call-time pass-by-ref no longer exists, so unpack needn't support it either.

Thanks!

This revision is now accepted and ready to land.May 2 2016, 3:12 PM

Closed by commit rPHU0709cd5cfc26: Add unpack support to xhpast (authored by richardvanvelzen, committed by richardvanvelzen). · Explain WhyMay 2 2016, 3:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

unpack-fail.php.test

4 lines

variadic.php.test

173 lines

bin/

PhutilXHPASTBinary.php

2 lines

support/

xhpast/

27 lines

4905 lines

25 lines

72 lines

2 lines

Diff 38141

View Options

src/parser/xhpast/tests/data/unpack-fail.php.test

View Options

src/parser/xhpast/tests/data/variadic.php.test

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

View Options

support/xhpast/parser.y

View Options

support/xhpast/parser.yacc.cpp

View Options

support/xhpast/scanner.lex.hpp

View Options

support/xhpast/scanner.lex.cpp

View Options

Add unpack support to xhpastClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 38141

src/parser/xhpast/__tests__/data/unpack-fail.php.test

src/parser/xhpast/__tests__/data/variadic.php.test

src/parser/xhpast/bin/PhutilXHPASTBinary.php

support/xhpast/parser.y

support/xhpast/parser.yacc.cpp

support/xhpast/scanner.lex.hpp

support/xhpast/scanner.lex.cpp

support/xhpast/xhpast.cpp

Add unpack support to xhpast
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/xhpast/tests/data/unpack-fail.php.test

src/parser/xhpast/tests/data/variadic.php.test