Page MenuHomePhabricator

Add unpack support to xhpast
ClosedPublic

Authored by richardvanvelzen on May 2 2016, 3:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 22, 3:07 PM
Unknown Object (File)
Mon, Feb 17, 11:30 AM
Unknown Object (File)
Sun, Feb 16, 6:45 AM
Unknown Object (File)
Feb 12 2025, 3:06 AM
Unknown Object (File)
Feb 11 2025, 4:56 AM
Unknown Object (File)
Feb 9 2025, 1:28 AM
Unknown Object (File)
Feb 9 2025, 1:28 AM
Unknown Object (File)
Feb 5 2025, 3:32 AM
Subscribers

Details

Test Plan
cd support/xhpast
make cleanall
make
cd ../../
scripts/build_xhpast.php
arc unit

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

richardvanvelzen retitled this revision from to Add unpack support to xhpast.
richardvanvelzen updated this object.
richardvanvelzen edited the test plan for this revision. (Show Details)
richardvanvelzen added a reviewer: epriestley.
support/xhpast/parser.y
1108–1111

I've updated this part to match PHP 7's behaviour. Call-time pass-by-ref no longer exists, so unpack needn't support it either.

This revision is now accepted and ready to land.May 2 2016, 3:12 PM
This revision was automatically updated to reflect the committed changes.