Correctly detect new version of xhpast build
ClosedPublic
Actions

Authored by richardvanvelzen on May 19 2016, 10:52 AM.

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Commits

rPHU7ff4bd8dfb0b: (stable) Promote 2016 Week 21
rPHUbd56873ae4c0: Correctly detect new version of xhpast build

Summary

When running lint after xhpast is updated, it tests whether the version is up-to-date. Because the version isn't reset before the test, it would think that the build failed, requiring a second run of lint

Test Plan

Downgraded xhpast, ran lint. Saw broken xhpast, but correct xhpast on second run. Applied patch, and got correct lint results regardless of version.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

richardvanvelzen updated this revision to Diff 38395.May 19 2016, 10:52 AM

richardvanvelzen retitled this revision from to Correctly detect new version of xhpast build.

richardvanvelzen updated this object.

richardvanvelzen edited the test plan for this revision. (Show Details)

richardvanvelzen added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 19 2016, 10:52 AM

Herald added subscribers: Firehed, Korvin. · View Herald Transcript

Not really high-prio, but a minor annoyance after getting a fresh xhpast version.

epriestley accepted this revision.May 19 2016, 1:53 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 19 2016, 1:53 PM

chad accepted this revision.May 19 2016, 2:04 PM

chad added a reviewer: chad.

Closed by commit rPHUbd56873ae4c0: Correctly detect new version of xhpast build (authored by richardvanvelzen, committed by richardvanvelzen). · Explain WhyMay 19 2016, 2:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

bin/

PhutilXHPASTBinary.php

4 lines

Diff 38398

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

Correctly detect new version of xhpast buildClosedPublicActions