Page MenuHomePhabricator

Support class const dereferencing in xhpast
ClosedPublic

Authored by richardvanvelzen on Jun 17 2016, 9:53 AM.

Details

Summary

Ref T4334. As it turns out, a major overhaul of the syntax wasn't needed.

This adds support for stuff like SomeClass::SOME_CONST[$idx] which was introduced in PHP 7.

Test Plan

Added a test case. Ran tests on libphutil and arcanist with both PHP 5 and PHP 7.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

richardvanvelzen retitled this revision from to Support class const dereferencing in xhpast.
richardvanvelzen updated this object.
richardvanvelzen edited the test plan for this revision. (Show Details)
richardvanvelzen added a reviewer: epriestley.
This revision is now accepted and ready to land.Jun 17 2016, 11:43 AM
This revision was automatically updated to reflect the committed changes.