Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T9640: Make Phabricator compatible with PHP7
arc unit --everything
Diff Detail
- Repository
- rPHU libphutil
- Branch
- php7-fix-remarkup-test
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 8426 Build 9685: arc lint + arc unit
Event Timeline
I would expect this to give us the wrong result for:
<space><space>%%%Four score and...
...which should be a code block but will maybe be picked up as a literal now?
Yea, I copied out the regex that is used in the code block rule, the weird thing is, that PHP7 and PHP5 outputs don't differ
This is weird
Just kicking this out of my queue until we figure out what the real issue is. It's vaguely possible this is actually the right fix, but I suspect not, and we should better understand the root cause.
I guess the question is:
Is the content of that text-file really supposed to to be a literal block, or should it be a code block? (the indented line)
If its supposed to be the code block, then something is wrong in PHP7, if its supposed to be be the literal block, then something is wrong in PHP5, it all depends on what the expected functionality is.
%%%[[http://hello | world]] **bold**%%% %%%[[http://hello | world]] **bold**%%% ~~~~~~~~~~ <p class="remarkup-literal">[[http://hello | world]] **bold**</p> <p class="remarkup-literal">[[http://hello | world]] **bold**</p> ~~~~~~~~~~ [[http://hello | world]] **bold** [[http://hello | world]] **bold**
Should line 2/3 be block or literal?