Page MenuHomePhabricator
Create Task
Maniphest T11166

When an install has no footer, Maniphest task previews have no bottom margin
Closed, ResolvedPublic
Actions

Description

  • Remove footer items in ui.footer-items.
  • Open a task which has total page height larger than the browser window height.
  • Start typing a comment.

At least in Safari, the preview box is uncomfortably close to the bottom of the window. I'm scrolled all the way down, here:

Screen Shot 2016-06-16 at 5.30.28 PM.png (246×152 px, 14 KB)

Revisions and Commits

rP Phabricator
D16168rP3bb3170a2c7c Add space under comment previews

Related Objects

Event Timeline

epriestley created this task.Jun 17 2016, 12:31 AM
Herald added a subscriber: eadler. · View Herald TranscriptJun 17 2016, 12:31 AM
chad added a subscriber: chad.Jun 17 2016, 1:33 AM

Yeah doesn't repro in Chrome.

chad added a comment.Jun 17 2016, 1:42 AM

Oh, on task view, I was looking the edit page.

epriestley added a comment.Jun 17 2016, 1:43 AM

Sorry, my screenshot was garbage since all the text to the right was INCREDIBLY CONFIDENTIAL SECRETS.

chad claimed this task.Jun 17 2016, 2:06 AM
chad added a project: PHUI.
Mnkras added a subscriber: Mnkras.Jun 17 2016, 7:47 PM

T10433?

chad added a comment.Jun 17 2016, 7:51 PM

Nope. We don't add padding to the outer container, it's handled on an object by object basis.

chad added a revision: D16168: Add space under comment previews.Jun 22 2016, 7:15 PM
chad closed this task as Resolved by committing rP3bb3170a2c7c: Add space under comment previews.Jun 22 2016, 7:17 PM
chad added a commit: rP3bb3170a2c7c: Add space under comment previews.
Phabricator · Built by Phacility