Support comments as an EditEngine field
c034752578cf
Actions

Description

Support comments as an EditEngine field

Summary:
Ref T9132. This adds an automatic "Comments" field, like the Subscribers/Projects/Policy fields.

The primary goals here are:

Allow users to make comments via Conduit.
In the future, get stackable action support.

As a side effect, this also allows you to put comments on create forms. This is a little silly but seems fine, and may be relevant on edit forms (which I'm not 100% sure how I want to handle yet). I've just hidden them by default for now.

Test Plan:

Screen Shot 2015-11-18 at 2.33.23 PM.png (1×1 px, 151 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9132

Differential Revision: https://secure.phabricator.com/D14515

Details

Provenance

epriestley	Authored on
epriestley	Pushed on Nov 23 2015, 12:27 AM

Reviewer

chad

Differential Revision

D14515: Support comments as an EditEngine field

Parents

rP269e0bfc943e: Allow EditEngine form fields to be locked and hidden

Branches

Unknown

Tags

Unknown

Tasks

T9132: Build an ApplicationEditor abstraction

Build Status

Buildable 8989
Build 10556: Run Core Tests

Event Timeline

epriestley committed rPc034752578cf: Support comments as an EditEngine field (authored by epriestley).Nov 23 2015, 12:27 AM

epriestley added a task: T9132: Build an ApplicationEditor abstraction.

Harbormaster completed building B8989: rPc034752578cf: Support comments as an EditEngine field.Nov 23 2015, 12:27 AM

I wonder if instead of "Comment", "Justification" might have more use in certain cases? (why not both! "Comment/Justification")

See D14515 for discussion. This is mostly a side-effect / proof-of-concept. I hope to be able to remove it from the UI completely in a future version.