Page MenuHomePhabricator

Add a user field into aphlict configuration
Changes PlannedPublic

Authored by tycho.tatitscheff on Apr 19 2016, 6:06 PM.

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Summary

As discussed on conpherence :

  • add an user field that is optional
  • verify that the user is not root
  • update the default config with en empty field, so we have an int that user field exists
  • if the user field exist in configuration and is not null : add a sudo into the command
  • update diviner documentation
  • correct the wording evrywhere so it sound english

I plan wording correction and test a little bit more edge cases.
But nothing that will really change the code structure so you can start reviewing
that if you got some times.

I hope that this contribution, on the contrary to previous ones, will match all the requirements.

Test Plan
  • I first removed ws from my mac so the command failed and thus so I can see the actuall command than run.
  • what was tested :
    • with empty user in config, it don't sudo
    • with no user in config, it don't sudo either
    • with 'blabla' user in config, it sudo and fail cause blabla is not an user

Diff Detail

Repository
rP Phabricator
Branch
add-user-config-into-aphlict
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11842
Build 14863: arc lint + arc unit

Event Timeline

tycho.tatitscheff retitled this revision from to Add an user field into aphlict configuration.
tycho.tatitscheff updated this object.
tycho.tatitscheff edited the test plan for this revision. (Show Details)
tycho.tatitscheff added a reviewer: epriestley.
tycho.tatitscheff added a reviewer: chad.

I think it is now ready for review.

I basically fail to write some wordings that sound english and if possible funny.
Could you help me find something cool ?

Then, small question : is idx phabricator specific ? What is the point accessing an dictionnary with idx instead of dict['key']?

avivey retitled this revision from Add an user field into aphlict configuration to Add a user field into aphlict configuration.Apr 19 2016, 6:44 PM
avivey added a subscriber: avivey.

Sorry, I'm a bit OCD about that...

@Mnkras : Ty. I was searching in rP.

@avivey : your welcome. My English is too bad. Thank you for helping me improve this.