Page MenuHomePhabricator

Can't create new credentials for remote repository
Closed, ResolvedPublic

Description

Importing an external repository has a step in it that tends to be confusing. To reproduce:

  • Create a new repository (external)
  • Give it a url like https://github.com/chadlittle/sonnets.git
  • On the "Authentication" page there is a select to choose a password with a button "Add Credential"
  • Clicking "Add Credential" fails with an exception no matter what you put into it.

This is confusing, because it makes users think they need to click "Add Credential" to add a Passphrase, I presume this button should say "Create New Credential" and be separate from the <select>, maybe ?

Most of the time people don't need to create credentials here, and can just Continue.

phabricator 146fb646f92b12a0031105d9fc9d67df67f86dcd (Sun, Apr 10)
arcanist 737f5c0df976fe2b3178aac6ab7feb3d3621d99e (Sat, Apr 9)
phutil a46f7b7e5d8073a91e89f7facc9fea62baaca7e8 (Sun, Apr 10)

Event Timeline

chad added a subscriber: chad.

This bug report is missing version information and reproduction steps. Please take the time to file a complete bug report and re-open after. Thanks!

chad renamed this task from Cant add credentials for remote repository. to Can't create new credentials for remote repository.Apr 11 2016, 2:48 AM
chad reopened this task as Open.
chad updated the task description. (Show Details)
chad added a project: Diffusion.

I dug everything up here.

As a workaround you can create credentials in Passphrase, then select the credential and click "Continue"

Thanks for suggestion guys. Will do the workaround.

I believe D15612 introduced the bug, but unclear why newDialog isn't doing the right thing here overall. Easy to revert.