HomePhabricator
Diffusion Phabricator 219357aa9fa3

Adding awarder info to badge cards displayed on user profile pages
Concern Raised219357aa9fa3
Actions

Description

Adding awarder info to badge cards displayed on user profile pages

Summary: Ref T8940

Test Plan: Award badge, open recipient profile page, badge should appear in badges list, and flipping the badge card should show who awarded it.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: chad, Korvin

Maniphest Tasks: T8940

Differential Revision: https://secure.phabricator.com/D15570

Details

Auditors
Mnkras
Provenance
lpriestleyAuthored on Apr 2 2016, 12:52 AM
lpriestleyPushed on Apr 3 2016, 1:23 AM
Reviewer
Blessed Reviewers
Differential Revision
D15570: Adding awarder info to badge cards displayed on user profile pages
Parents
rP839e7e2fc6e6: Update Config to new UI
Branches
Unknown
Tags
Unknown
Tasks
T8940: Annotate badges with awarder, date
Build Status
Buildable 11443
Build 14265: Run Core Tests

Event Timeline

lpriestley committed rP219357aa9fa3: Adding awarder info to badge cards displayed on user profile pages (authored by lpriestley).Apr 3 2016, 1:23 AM
lpriestley added a task: T8940: Annotate badges with awarder, date.
Harbormaster completed building B11443: rP219357aa9fa3: Adding awarder info to badge cards displayed on user profile pages.Apr 3 2016, 1:23 AM
Mnkras raised a concern with this commit.Apr 12 2016, 12:25 AM
Mnkras added a subscriber: Mnkras.

It seems this no longer is working correctly:

pasted_file (517×322 px, 21 KB)

(taken on this install right now)

chad added a subscriber: chad.EditedApr 12 2016, 12:36 AM

My expectation is people will file bug reports for bugs since raising a concern skips gathering required information. (I don't think this commit is the culprit, offhand).

Mnkras added a comment.Apr 12 2016, 12:38 AM

Fair enough, I will do that now.

chad added a comment.Apr 12 2016, 12:40 AM

I think per D15014#171695 a migration script was to be written, but I can't find further reference to it.

chad accepted this commit.Feb 13 2017, 3:29 PM
chad resigned from this commit.Mar 25 2017, 2:04 AM
chad removed an auditor: chad.

Changes (1)

PathSize
src/
applications/
people/
controller/

rP219357aa9fa3

View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Loading...
Phabricator · Built by Phacility