Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

Sep 16 2020

Harbormaster failed to build B24901: rP93ef902ffa3c: Fix a view fatal in CommitGraphView when commits are undiscovered for rP93ef902ffa3c: Fix a view fatal in CommitGraphView when commits are undiscovered!

Sep 16 2020, 12:48 AM

Harbormaster failed to build B24898: rP3a80efa440f0: Build "DiffusionCommitRef" objects from "internal.commit.search", not… for rP3a80efa440f0: Build "DiffusionCommitRef" objects from "internal.commit.search", not…!

Sep 16 2020, 12:48 AM

Harbormaster failed to build B24900: rPcebde34425c2: Make "CommitData" wrap and persist a "CommitRef" record for rPcebde34425c2: Make "CommitData" wrap and persist a "CommitRef" record!

Sep 16 2020, 12:48 AM

Harbormaster failed to build B24906: rP969587f7b0c3: Log unexpected exceptions raised by Conduit calls for rP969587f7b0c3: Log unexpected exceptions raised by Conduit calls!

Sep 16 2020, 12:48 AM

Harbormaster failed to build B24904: rP737e7c85412c: When an in-process worker subtask fails permanently, don't fatal the whole… for rP737e7c85412c: When an in-process worker subtask fails permanently, don't fatal the whole…!

Sep 16 2020, 12:48 AM

Harbormaster failed to build B24902: rP6f78e2a91c88: When a commit is marked "closeable", clear the "published" flag for rP6f78e2a91c88: When a commit is marked "closeable", clear the "published" flag!

Sep 16 2020, 12:48 AM

Harbormaster failed to build B24903: rPa39c59044235: Move task and revision closure to the "publishing" step of the commit import… for rPa39c59044235: Move task and revision closure to the "publishing" step of the commit import…!

Sep 16 2020, 12:48 AM

Harbormaster failed to build B24899: rPe454c3dafe99: Wrap all direct access to author/committer properties on "CommitData" for rPe454c3dafe99: Wrap all direct access to author/committer properties on "CommitData"!

Sep 16 2020, 12:47 AM

Harbormaster failed to build B24897: rP7d6874d9f099: Turn "bypassCache" into a no-op in "diffusion.querycommits" for rP7d6874d9f099: Turn "bypassCache" into a no-op in "diffusion.querycommits"!

Sep 16 2020, 12:47 AM

Harbormaster failed to build B24896: rPf6238f9d9bd3: Remove "bin/repository lookup-users" workflow for rPf6238f9d9bd3: Remove "bin/repository lookup-users" workflow!

Sep 16 2020, 12:45 AM

epriestley closed T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash as Resolved.

Sep 16 2020, 12:44 AM · Differential

epriestley committed rP969587f7b0c3: Log unexpected exceptions raised by Conduit calls (authored by epriestley).

Log unexpected exceptions raised by Conduit calls

Sep 16 2020, 12:37 AM

epriestley committed rP2a83df578604: Fix an issue where a GROUP BY was missing when a query matched a revision using… (authored by epriestley).

Fix an issue where a GROUP BY was missing when a query matched a revision using…

Sep 16 2020, 12:37 AM

epriestley committed rP737e7c85412c: When an in-process worker subtask fails permanently, don't fatal the whole… (authored by epriestley).

When an in-process worker subtask fails permanently, don't fatal the whole…

Sep 16 2020, 12:37 AM

epriestley committed rPa39c59044235: Move task and revision closure to the "publishing" step of the commit import… (authored by epriestley).

Move task and revision closure to the "publishing" step of the commit import…

Sep 16 2020, 12:37 AM

epriestley committed rP93ef902ffa3c: Fix a view fatal in CommitGraphView when commits are undiscovered (authored by epriestley).

Fix a view fatal in CommitGraphView when commits are undiscovered

Sep 16 2020, 12:37 AM

epriestley committed rP6f78e2a91c88: When a commit is marked "closeable", clear the "published" flag (authored by epriestley).

When a commit is marked "closeable", clear the "published" flag

Sep 16 2020, 12:37 AM

epriestley committed rPcebde34425c2: Make "CommitData" wrap and persist a "CommitRef" record (authored by epriestley).

Make "CommitData" wrap and persist a "CommitRef" record

Sep 16 2020, 12:37 AM

epriestley closed D21464: Log unexpected exceptions raised by Conduit calls.

Sep 16 2020, 12:37 AM

epriestley closed D21459: When an in-process worker subtask fails permanently, don't fatal the whole process.

Sep 16 2020, 12:37 AM

epriestley closed D21460: When a commit is marked "closeable", clear the "published" flag.

Sep 16 2020, 12:37 AM

epriestley committed rPe454c3dafe99: Wrap all direct access to author/committer properties on "CommitData" (authored by epriestley).

Wrap all direct access to author/committer properties on "CommitData"

Sep 16 2020, 12:37 AM

epriestley closed D21462: Fix an issue where a GROUP BY was missing when a query matched a revision using multiple hashes.

Sep 16 2020, 12:37 AM

epriestley committed rP7d6874d9f099: Turn "bypassCache" into a no-op in "diffusion.querycommits" (authored by epriestley).

Turn "bypassCache" into a no-op in "diffusion.querycommits"

Sep 16 2020, 12:37 AM

epriestley closed T13569: When running worker tasks in-process, subtasks which fail incorrectly cause the parent tasks to fail as Resolved by committing rP737e7c85412c: When an in-process worker subtask fails permanently, don't fatal the whole….

Sep 16 2020, 12:37 AM · Daemons

epriestley committed rP3a80efa440f0: Build "DiffusionCommitRef" objects from "internal.commit.search", not… (authored by epriestley).

Build "DiffusionCommitRef" objects from "internal.commit.search", not…

Sep 16 2020, 12:37 AM

epriestley closed D21458: Fix a view fatal in CommitGraphView when commits are undiscovered.

Sep 16 2020, 12:37 AM

epriestley closed D21450: Move task and revision closure to the "publishing" step of the commit import pipeline.

Sep 16 2020, 12:37 AM

epriestley committed rPa745055813e4: Lift Diffusion Conduit call proxying to the root level of Conduit (authored by epriestley).

Lift Diffusion Conduit call proxying to the root level of Conduit

Sep 16 2020, 12:37 AM

epriestley committed rPf6238f9d9bd3: Remove "bin/repository lookup-users" workflow (authored by epriestley).

Remove "bin/repository lookup-users" workflow

Sep 16 2020, 12:37 AM

epriestley committed rPa9506097ea04: Add "internal.commit.search" to replace the cache bypass mode of "diffusion. (authored by epriestley).

Add "internal.commit.search" to replace the cache bypass mode of "diffusion.

Sep 16 2020, 12:37 AM

epriestley closed D21449: Make "CommitData" wrap and persist a "CommitRef" record.

Sep 16 2020, 12:37 AM

epriestley committed rP367cd289270d: Delete some commit dead parsing code (authored by epriestley).

Delete some commit dead parsing code

Sep 16 2020, 12:37 AM

epriestley closed D21448: Wrap all direct access to author/committer properties on "CommitData".

Sep 16 2020, 12:36 AM

epriestley closed D21446: Build "DiffusionCommitRef" objects from "internal.commit.search", not "diffusion.querycommits", in the message parser worker.

Sep 16 2020, 12:36 AM

epriestley closed D21444: Remove "bin/repository lookup-users" workflow.

Sep 16 2020, 12:36 AM

epriestley closed D21447: Turn "bypassCache" into a no-op in "diffusion.querycommits".

Sep 16 2020, 12:36 AM

epriestley closed D21443: Add "internal.commit.search" to replace the cache bypass mode of "diffusion.querycommits".

Sep 16 2020, 12:36 AM

epriestley closed D21442: Lift Diffusion Conduit call proxying to the root level of Conduit.

Sep 16 2020, 12:36 AM

epriestley closed D21441: Delete some commit dead parsing code.

Sep 16 2020, 12:36 AM

epriestley committed rARCde209ec06488: When raising a Conduit client exception, show the called method in the error… (authored by epriestley).

When raising a Conduit client exception, show the called method in the error…

Sep 16 2020, 12:34 AM

epriestley closed D21463: When raising a Conduit client exception, show the called method in the error message.

Sep 16 2020, 12:34 AM

epriestley requested review of D21464: Log unexpected exceptions raised by Conduit calls.

Sep 16 2020, 12:25 AM

epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: D21464: Log unexpected exceptions raised by Conduit calls.

Sep 16 2020, 12:24 AM · Differential

epriestley requested review of D21463: When raising a Conduit client exception, show the called method in the error message.

Sep 16 2020, 12:20 AM

epriestley requested review of D21462: Fix an issue where a GROUP BY was missing when a query matched a revision using multiple hashes.

Sep 16 2020, 12:20 AM

epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: D21463: When raising a Conduit client exception, show the called method in the error message.

Sep 16 2020, 12:20 AM · Differential

epriestley added a revision to T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash: D21462: Fix an issue where a GROUP BY was missing when a query matched a revision using multiple hashes.

Sep 16 2020, 12:19 AM · Differential

epriestley triaged T13581: DifferentialRevisionQuery omits GROUP BY when querying by hash as Normal priority.

Sep 16 2020, 12:16 AM · Differential

Sep 15 2020

epriestley committed rP3dfa89dd5d27: Update SES API to use AWSv4 signatures (authored by epriestley).

Update SES API to use AWSv4 signatures

Sep 15 2020, 8:03 PM

epriestley closed D21461: Update SES API to use AWSv4 signatures.

Sep 15 2020, 8:03 PM

epriestley closed T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly, a subtask of T13570: Amazon is retiring SMTP V3 Signatures, as Resolved.

Sep 15 2020, 8:03 PM · Mail

epriestley closed T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly as Resolved by committing rP3dfa89dd5d27: Update SES API to use AWSv4 signatures.

Sep 15 2020, 8:03 PM · Mail

epriestley requested review of D21461: Update SES API to use AWSv4 signatures.

Sep 15 2020, 4:20 PM

epriestley added a comment to T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly.

I've marked D21461 as resolving this, since the new errors surface the particulars:

Sep 15 2020, 4:19 PM · Mail

epriestley added a revision to T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly: D21461: Update SES API to use AWSv4 signatures.

Sep 15 2020, 4:15 PM · Mail

epriestley added a revision to T13570: Amazon is retiring SMTP V3 Signatures: D21461: Update SES API to use AWSv4 signatures.

Sep 15 2020, 4:15 PM · Mail

epriestley edited the content of Dependencies.

Sep 15 2020, 4:08 PM

epriestley added a subtask for T13570: Amazon is retiring SMTP V3 Signatures: T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly.

Sep 15 2020, 4:08 PM · Mail

epriestley added a parent task for T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly: T13570: Amazon is retiring SMTP V3 Signatures.

Sep 15 2020, 4:08 PM · Mail

Sep 8 2020

epriestley requested review of D21460: When a commit is marked "closeable", clear the "published" flag.

Sep 8 2020, 8:43 PM

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21460: When a commit is marked "closeable", clear the "published" flag.

Sep 8 2020, 8:42 PM · Differential

epriestley requested review of D21459: When an in-process worker subtask fails permanently, don't fatal the whole process.

Sep 8 2020, 8:17 PM

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21459: When an in-process worker subtask fails permanently, don't fatal the whole process.

Sep 8 2020, 8:16 PM · Differential

epriestley added a revision to T13569: When running worker tasks in-process, subtasks which fail incorrectly cause the parent tasks to fail: D21459: When an in-process worker subtask fails permanently, don't fatal the whole process.

Sep 8 2020, 8:15 PM · Daemons

epriestley requested review of D21458: Fix a view fatal in CommitGraphView when commits are undiscovered.

Sep 8 2020, 7:56 PM

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21458: Fix a view fatal in CommitGraphView when commits are undiscovered.

Sep 8 2020, 7:55 PM · Differential

epriestley triaged T13580: Make "fully imported" a separate commit bit or standalone flag, not a complex bitmask operation as Wishlist priority.

Sep 8 2020, 7:49 PM · Diffusion

epriestley closed T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path as Resolved.

D21457 fixes approximately 20 additional errors identified by the linter in phabricator/.

Sep 8 2020, 6:48 PM · Arcanist

epriestley committed rARC73847a4b194b: Fix a false negative in lint for "xsprintf()"-family functions (authored by epriestley).

Fix a false negative in lint for "xsprintf()"-family functions

Sep 8 2020, 6:46 PM

epriestley committed rARC7112ee3d5960: Fix additional "xsprintf()"-family static parameter errors (authored by epriestley).

Fix additional "xsprintf()"-family static parameter errors

Sep 8 2020, 6:46 PM

epriestley committed rARC83e63aeb078b: Allow AAST to extract string literal values from HEREDOCs (authored by epriestley).

Allow AAST to extract string literal values from HEREDOCs

Sep 8 2020, 6:46 PM

epriestley committed rARC1c327208d7ba: Fix a missing "pht()" parameter in HTTPSFuture (authored by epriestley).

Fix a missing "pht()" parameter in HTTPSFuture

Sep 8 2020, 6:46 PM

epriestley closed D21456: Fix additional "xsprintf()"-family static parameter errors.

Sep 8 2020, 6:46 PM

epriestley closed D21453: Fix a false negative in lint for "xsprintf()"-family functions.

Sep 8 2020, 6:46 PM

epriestley closed D21454: Fix a missing "pht()" parameter in HTTPSFuture.

Sep 8 2020, 6:46 PM

epriestley closed D21455: Allow AAST to extract string literal values from HEREDOCs.

Sep 8 2020, 6:46 PM

epriestley committed rP6e1b5da1121c: Fix additional "xprintf()"-class static parameter lint errors (authored by epriestley).

Fix additional "xprintf()"-class static parameter lint errors

Sep 8 2020, 6:45 PM

epriestley closed D21457: Fix additional "xprintf()"-class static parameter lint errors.

Sep 8 2020, 6:45 PM

epriestley requested review of D21457: Fix additional "xprintf()"-class static parameter lint errors.

Sep 8 2020, 3:56 PM

epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: D21457: Fix additional "xprintf()"-class static parameter lint errors.

Sep 8 2020, 3:55 PM · Arcanist

Sep 5 2020

tiguchi added a comment to T5776: Make Slowvote choices editable by the author.

I just created a poll where I accidentally hit enter while editing options, so I was left with an incomplete poll which I wasn't allowed to complete, so I had to close it. Would you consider adding a feature that allows us to edit poll options as long as there are no votes cast yet?

Sep 5 2020, 4:46 PM · Slowvote

epriestley added a comment to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path.

D21454 fixes the specific issue in HTTPSFuture.

Sep 5 2020, 12:32 AM · Arcanist

epriestley requested review of D21456: Fix additional "xsprintf()"-family static parameter errors.

Sep 5 2020, 12:32 AM

epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: D21456: Fix additional "xsprintf()"-family static parameter errors.

Sep 5 2020, 12:32 AM · Arcanist

epriestley requested review of D21455: Allow AAST to extract string literal values from HEREDOCs.

Sep 5 2020, 12:26 AM

epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: D21455: Allow AAST to extract string literal values from HEREDOCs.

Sep 5 2020, 12:26 AM · Arcanist

epriestley requested review of D21454: Fix a missing "pht()" parameter in HTTPSFuture.

Sep 5 2020, 12:10 AM

epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: D21454: Fix a missing "pht()" parameter in HTTPSFuture.

Sep 5 2020, 12:09 AM · Arcanist

epriestley added a comment to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path.

Check if arc lint catches this.

Sep 5 2020, 12:09 AM · Arcanist

epriestley requested review of D21453: Fix a false negative in lint for "xsprintf()"-family functions.

Sep 5 2020, 12:07 AM

epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: D21453: Fix a false negative in lint for "xsprintf()"-family functions.

Sep 5 2020, 12:07 AM · Arcanist

Sep 4 2020

epriestley committed rP5fff4ed8dbb7: (stable) Remove obsolete write to "pid" property in "annihilateProcessGroup()"… (authored by epriestley).

(stable) Remove obsolete write to "pid" property in "annihilateProcessGroup()"…

Sep 4 2020, 11:44 PM

epriestley committed rP69662a11d73d: (stable) When printing timestamps on paper: use an absolute, context-free date… (authored by epriestley).

(stable) When printing timestamps on paper: use an absolute, context-free date…

Sep 4 2020, 11:44 PM

epriestley committed rP7daaaa8463e2: Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon… (authored by epriestley).

Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon…

Sep 4 2020, 11:41 PM

epriestley closed D21452: Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon Overseer.

Sep 4 2020, 11:41 PM

epriestley requested review of D21452: Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon Overseer.

Sep 4 2020, 11:41 PM

epriestley added a revision to T13579: Overseer may fatal when trying to write to "pid" property in "annihilateProcessGroup()": D21452: Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon Overseer.

Sep 4 2020, 11:39 PM · Daemons

epriestley triaged T13579: Overseer may fatal when trying to write to "pid" property in "annihilateProcessGroup()" as Normal priority.

Sep 4 2020, 11:38 PM · Daemons

epriestley committed rP0854425d191f: When printing timestamps on paper: use an absolute, context-free date format (authored by epriestley).

When printing timestamps on paper: use an absolute, context-free date format

Sep 4 2020, 11:36 PM