Paths

Table of Contentst

Fix additional "xsprintf()"-family static parameter errors
ClosedPublic
Actions

Authored by epriestley on Sat, Sep 5, 12:32 AM.

Details

Reviewers: None
Maniphest Tasks: T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path
Commits: rARC7112ee3d5960: Fix additional "xsprintf()"-family static parameter errors

Summary

Ref T13577. After the lint rule fix in D21453, it can identify more errors. Fix the errors it identifies in "arcanist/".

These all seem fairly obscure/benign.

Test Plan

Ran arc lint on the files before and after these changes. Did not specifically re-test these particular messages, but they mostly very obscure.

Diff Detail

Repository

rARC Arcanist

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sat, Sep 5, 12:32 AM

Harbormaster completed remote builds in B24876: Diff 51061.Sat, Sep 5, 12:32 AM

epriestley requested review of this revision.Sat, Sep 5, 12:32 AM

epriestley mentioned this in T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path.Sat, Sep 5, 12:32 AM

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Sep 8, 6:46 PM

Closed by commit rARC7112ee3d5960: Fix additional "xsprintf()"-family static parameter errors (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC7112ee3d5960: Fix additional "xsprintf()"-family static parameter errors.

Revision Contents
Changeset List

Path

Size

src/

hardpoint/

ArcanistHardpointList.php

4 lines

land/

engine/

ArcanistLandEngine.php

1 line

repository/

api/

ArcanistMercurialAPI.php

2 lines

runtime/

ArcanistRuntime.php

1 line

toolset/

ArcanistAliasEngine.php

4 lines

workflow/

ArcanistCloseRevisionWorkflow.php

3 lines

Diff 51067

View Options

src/hardpoint/ArcanistHardpointList.php

View Options

src/land/engine/ArcanistLandEngine.php

View Options

src/repository/api/ArcanistMercurialAPI.php

View Options

src/runtime/ArcanistRuntime.php

View Options

src/toolset/ArcanistAliasEngine.php

View Options

src/workflow/ArcanistCloseRevisionWorkflow.php

Fix additional "xsprintf()"-family static parameter errorsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 51067

src/hardpoint/ArcanistHardpointList.php

src/land/engine/ArcanistLandEngine.php

src/repository/api/ArcanistMercurialAPI.php

src/runtime/ArcanistRuntime.php

src/toolset/ArcanistAliasEngine.php

src/workflow/ArcanistCloseRevisionWorkflow.php

Fix additional "xsprintf()"-family static parameter errors
ClosedPublic
Actions

Revision Contents
Changeset List