Page MenuHomePhabricator
Feed All Stories

Fri, Sep 4

epriestley closed D21451: When printing timestamps on paper: use an absolute, context-free date format.
Fri, Sep 4, 11:36 PM
epriestley requested review of D21451: When printing timestamps on paper: use an absolute, context-free date format.
Fri, Sep 4, 11:33 PM
epriestley added a revision to T13573: When printing, render dates in an absolute, context-free format: D21451: When printing timestamps on paper: use an absolute, context-free date format.
Fri, Sep 4, 11:25 PM · Infrastructure
epriestley renamed T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting from Include "Moved/Copied" gutter in 1-up diffs, and add aural cues to Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Fri, Sep 4, 5:56 PM · Accessibility, Differential
epriestley triaged T13578: Provide `bin/user approve` to approve an account from the CLI as Wishlist priority.
Fri, Sep 4, 5:52 PM · Setup, Auth
epriestley triaged T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path as Low priority.
Fri, Sep 4, 5:49 PM · Arcanist
epriestley triaged T13576: Certain "arc land" merges fail when they should succeed as Normal priority.
Fri, Sep 4, 5:46 PM · Arcanist

Tue, Sep 1

20after4 added a comment to T13478: Fix various policy issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones.

Probably related: According to https://phabricator.wikimedia.org/T261642, it seems that when leaving a project, phabricator leaves behind some cruft in the form of materialized memberships for milestones of that project.

Tue, Sep 1, 9:42 PM · Policy, Projects
mavit added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

MYSQL_PWD can be observed always

Tue, Sep 1, 8:02 PM · Bug Report
IgoSha added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

The main problem here is that command "./bin/storage dump" exposes password on system process list in clear text. It happens due to way the storage tool calls mysqldump command. In my opinion this is universally applicable to every Linux distribution Phabricator can run on.

Tue, Sep 1, 1:44 PM · Bug Report

Sat, Aug 29

MagicInventor added a comment to T13568: In "arc land --incremental", rebased branches are not repeatedly rebased as changes iterate.
Sat, Aug 29, 12:19 AM · Arcanist
MagicInventor updated MagicInventor.
Sat, Aug 29, 12:11 AM

Aug 24 2020

epriestley added a comment to T5055: Distribution mechanism for arc extensions.

New user is told "install dinosaurs, you can trust epriestley.

Aug 24 2020, 4:49 PM · Arcanist

Aug 22 2020

avivey added a comment to T5055: Distribution mechanism for arc extensions.

The public key won't necessarily be available to Phabricator (because it's kinda funny to have the public key and signature in the same place). We'll just register the fingerprints I guess?

I think the public key has to be available -- you can't verify signatures otherwise.

Aug 22 2020, 6:28 AM · Arcanist

Aug 21 2020

epriestley added a comment to T5055: Distribution mechanism for arc extensions.

Distribution would just be zip/tgz files for each package

Aug 21 2020, 5:01 PM · Arcanist
avivey added a comment to T5055: Distribution mechanism for arc extensions.

I think I'm going to start working on the Arcanist side of this soon...

Aug 21 2020, 12:15 PM · Arcanist
kuba-orlik raised a concern with rARC7ddaed9aba1a: Improve "arc land" behavior in the presence of merge conflicts and change….

This commit has introduced an issue when landing a commit that's been merged with the target branch already.

Aug 21 2020, 12:04 PM
alexnb awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Love token.
Aug 21 2020, 8:31 AM · Differential, Quick Look

Aug 20 2020

Firehed added a comment to T13575: PHP built-in webserver fails on POST.

For what it's worth, the only reason I was trying to figure out stuff with the built-in server was because at the time trying to get Phabricator running in Docker correctly was... not nearly as easy as I would have liked. Quickly skimming online suggests that's improved in the interim.

Aug 20 2020, 8:06 PM · Infrastructure
avivey added a comment to T13575: PHP built-in webserver fails on POST.

Yeah, it might make sense to drop it; I use it because it's easier to setup then Apache and the error log is right in my console, but setting up a real server isn't that much of a bother, except for Apple changing the rugs on you every other day (Soon with both x86 and ARM versions!)

Aug 20 2020, 7:39 PM · Infrastructure
epriestley added a project to T13575: PHP built-in webserver fails on POST: Infrastructure.
Aug 20 2020, 6:48 PM · Infrastructure
epriestley added a comment to T13575: PHP built-in webserver fails on POST.

I wonder if maintaining support for the builtin webserver is worthwhile -- I never use it, and I feel like I only see it referenced when users report bugs like this in the vein of "PHP builtin webserver has been completely broken for 13 years", which suggests it's probably not seeing very much use in the wild, either.

Aug 20 2020, 6:47 PM · Infrastructure
avivey created T13575: PHP built-in webserver fails on POST.
Aug 20 2020, 5:43 PM · Infrastructure
artms requested review of D20972: `arc patch --arcbundle` might require authentification if it can't find base commit.
Aug 20 2020, 5:58 AM
artms planned changes to D20972: `arc patch --arcbundle` might require authentification if it can't find base commit.
Aug 20 2020, 5:58 AM

Aug 17 2020

epriestley added a subtask for T13574: Make responsive UI elements respond to container width, not window width: T13521: FormationView could do more Javascript magic around device layouts and header elements.
Aug 17 2020, 3:52 PM · Design
epriestley added a parent task for T13521: FormationView could do more Javascript magic around device layouts and header elements: T13574: Make responsive UI elements respond to container width, not window width.
Aug 17 2020, 3:52 PM · Differential
epriestley triaged T13574: Make responsive UI elements respond to container width, not window width as Low priority.
Aug 17 2020, 3:52 PM · Design
epriestley added a comment to T13573: When printing, render dates in an absolute, context-free format.

See also T9854: Support date/time reformatting in Remarkup for a related change, although I think neither feature directly impacts the other.

Aug 17 2020, 3:34 PM · Infrastructure
epriestley updated the task description for T13573: When printing, render dates in an absolute, context-free format.
Aug 17 2020, 3:33 PM · Infrastructure
epriestley triaged T13573: When printing, render dates in an absolute, context-free format as Normal priority.
Aug 17 2020, 3:32 PM · Infrastructure
epriestley triaged T13572: Daemon overseers may have a slow memory leak, possibly in FuturePool as Low priority.
Aug 17 2020, 3:17 PM · Daemons

Aug 14 2020

epriestley committed rP82f98747a4e3: (stable) Coerce Chrome into breaking monospaced text when printing tables to… (authored by epriestley).
(stable) Coerce Chrome into breaking monospaced text when printing tables to…
Aug 14 2020, 6:52 PM
Krinkle renamed T5270: Allow creation of a Parent task (new task with a preset dependency) from Allow adding dependencies directly when creating a Maniphest (sub-)task to Allow creation of a Parent task (new task with a preset dependency).
Aug 14 2020, 6:15 PM · Maniphest

Aug 13 2020

epriestley triaged T13571: When viewing LFS files in Differential or Diffusion, show blob content where reasonable as Normal priority.
Aug 13 2020, 8:12 PM · Diffusion, Differential
epriestley claimed T13570: Amazon is retiring SMTP V3 Signatures.

I think every other AWS interaction already uses v4, since D14978 (January 2016).

Aug 13 2020, 4:00 PM · Mail
aeiser updated the task description for T13570: Amazon is retiring SMTP V3 Signatures.
Aug 13 2020, 1:55 PM · Mail
aeiser created T13570: Amazon is retiring SMTP V3 Signatures.
Aug 13 2020, 1:54 PM · Mail

Aug 12 2020

epriestley requested review of D21450: Move task and revision closure to the "publishing" step of the commit import pipeline.
Aug 12 2020, 9:20 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21450: Move task and revision closure to the "publishing" step of the commit import pipeline.
Aug 12 2020, 9:19 PM · Differential
epriestley triaged T13569: When running worker tasks in-process, subtasks which fail incorrectly cause the parent tasks to fail as Wishlist priority.
Aug 12 2020, 8:32 PM · Daemons
epriestley requested review of D21449: Make "CommitData" wrap and persist a "CommitRef" record.
Aug 12 2020, 8:03 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21449: Make "CommitData" wrap and persist a "CommitRef" record.
Aug 12 2020, 8:02 PM · Differential
epriestley requested review of D21448: Wrap all direct access to author/committer properties on "CommitData".
Aug 12 2020, 7:44 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21448: Wrap all direct access to author/committer properties on "CommitData".
Aug 12 2020, 7:42 PM · Differential
epriestley added a comment to D21445: Change sshd templates so they use the new ssh-auth syntax.

Mostly for my own notes:

Aug 12 2020, 7:27 PM
epriestley added a comment to T11827: ssh-auth hangs on FreeBSD.

Internally, see also PHI1785.

Aug 12 2020, 7:22 PM · Diffusion, Bug Report
epriestley added a comment to D21445: Change sshd templates so they use the new ssh-auth syntax.

The root cause is a bug in SSHD which was fixed in January 2017, see T11827.

Aug 12 2020, 7:21 PM
epriestley requested review of D21447: Turn "bypassCache" into a no-op in "diffusion.querycommits".
Aug 12 2020, 7:12 PM
kuba-orlik updated the summary of D21445: Change sshd templates so they use the new ssh-auth syntax.
Aug 12 2020, 7:12 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21447: Turn "bypassCache" into a no-op in "diffusion.querycommits".
Aug 12 2020, 7:11 PM · Differential
epriestley requested review of D21446: Build "DiffusionCommitRef" objects from "internal.commit.search", not "diffusion.querycommits", in the message parser worker.
Aug 12 2020, 7:09 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21446: Build "DiffusionCommitRef" objects from "internal.commit.search", not "diffusion.querycommits", in the message parser worker.
Aug 12 2020, 7:08 PM · Differential
kuba-orlik requested review of D21445: Change sshd templates so they use the new ssh-auth syntax.
Aug 12 2020, 7:04 PM
epriestley requested review of D21444: Remove "bin/repository lookup-users" workflow.
Aug 12 2020, 7:03 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21444: Remove "bin/repository lookup-users" workflow.
Aug 12 2020, 7:02 PM · Differential
epriestley requested review of D21443: Add "internal.commit.search" to replace the cache bypass mode of "diffusion.querycommits".
Aug 12 2020, 6:43 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21443: Add "internal.commit.search" to replace the cache bypass mode of "diffusion.querycommits".
Aug 12 2020, 6:41 PM · Differential
epriestley requested review of D21442: Lift Diffusion Conduit call proxying to the root level of Conduit.
Aug 12 2020, 6:33 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21442: Lift Diffusion Conduit call proxying to the root level of Conduit.
Aug 12 2020, 6:32 PM · Differential
epriestley requested review of D21441: Delete some commit dead parsing code.
Aug 12 2020, 4:32 PM
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: D21441: Delete some commit dead parsing code.
Aug 12 2020, 4:31 PM · Differential
Harbormaster failed to build B24842: rP46695c76ebfe: Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and… for rP46695c76ebfe: Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and…!
Aug 12 2020, 4:08 PM
Harbormaster failed to build B24841: rPc6de7c66a3c6: Remove the "Graph" view as a dedicated repository view for rPc6de7c66a3c6: Remove the "Graph" view as a dedicated repository view!
Aug 12 2020, 4:07 PM
epriestley committed rP72f149bf399a: Require rows passed to "loadAllFromArray()" have unique keys (authored by epriestley).
Require rows passed to "loadAllFromArray()" have unique keys
Aug 12 2020, 4:05 PM
epriestley added a reverting change for D21399: Fix an issue where querying for a large number of projects by slug could paginate incorrectly: rP72f149bf399a: Require rows passed to "loadAllFromArray()" have unique keys.
Aug 12 2020, 4:05 PM
epriestley closed D21400: Require rows passed to "loadAllFromArray()" have unique keys.
Aug 12 2020, 4:05 PM
epriestley committed rP429543b6376f: Fix some content/background overflow issues with commit graph lists (authored by epriestley).
Fix some content/background overflow issues with commit graph lists
Aug 12 2020, 4:04 PM
epriestley committed rP0b64092d25d0: Improve handle/status list display on devices in commit graph lists (authored by epriestley).
Improve handle/status list display on devices in commit graph lists
Aug 12 2020, 4:04 PM
epriestley committed rP49af92e90325: Improve commit action item layout on mobile (authored by epriestley).
Improve commit action item layout on mobile
Aug 12 2020, 4:04 PM
epriestley closed D21440: Fix some content/background overflow issues with commit graph lists.
Aug 12 2020, 4:04 PM
epriestley closed D21431: Improve handle/status list display on devices in commit graph lists.
Aug 12 2020, 4:04 PM
epriestley closed D21430: Improve commit action item layout on mobile.
Aug 12 2020, 4:04 PM
epriestley committed rP57f9450bcfc0: Improve desktop and mobile layouts for new "CommitGridView" (authored by epriestley).
Improve desktop and mobile layouts for new "CommitGridView"
Aug 12 2020, 4:04 PM
epriestley committed rP8aec3f916b39: Unify more build, property, auditor, and status information into… (authored by epriestley).
Unify more build, property, auditor, and status information into…
Aug 12 2020, 4:04 PM
epriestley closed D21418: Improve desktop and mobile layouts for new "CommitGridView".
Aug 12 2020, 4:04 PM
epriestley closed D21417: Unify more build, property, auditor, and status information into "CommitGraphView".
Aug 12 2020, 4:04 PM
epriestley triaged T13568: In "arc land --incremental", rebased branches are not repeatedly rebased as changes iterate as Low priority.
Aug 12 2020, 4:02 PM · Arcanist
epriestley committed rP36dac46ff263: Clean up some minor commit list CSS (authored by epriestley).
Clean up some minor commit list CSS
Aug 12 2020, 4:00 PM
epriestley closed D21416: Clean up some minor commit list CSS.
Aug 12 2020, 4:00 PM
epriestley committed rP57ee6649aa3f: Remove "PhabricatorAuditListView" (authored by epriestley).
Remove "PhabricatorAuditListView"
Aug 12 2020, 4:00 PM
epriestley closed D21415: Remove "PhabricatorAuditListView".
Aug 12 2020, 4:00 PM
epriestley committed rP2b0632b442a2: Remove "DiffusionHistoryTableView" and "DiffusionHistoryView" (authored by epriestley).
Remove "DiffusionHistoryTableView" and "DiffusionHistoryView"
Aug 12 2020, 4:00 PM
epriestley closed D21414: Remove "DiffusionHistoryTableView" and "DiffusionHistoryView".
Aug 12 2020, 4:00 PM
epriestley committed rP7087c0439a7f: Move the view of merged changes to "DiffusionCommitGraphView" (authored by epriestley).
Move the view of merged changes to "DiffusionCommitGraphView"
Aug 12 2020, 4:00 PM
epriestley closed D21413: Move the view of merged changes to "DiffusionCommitGraphView".
Aug 12 2020, 3:59 PM
epriestley committed rPcd09ba5e19d7: Replace "DiffusionCommitListView" with "DiffusionCommitGraphView" (authored by epriestley).
Replace "DiffusionCommitListView" with "DiffusionCommitGraphView"
Aug 12 2020, 3:59 PM
epriestley closed D21412: Replace "DiffusionCommitListView" with "DiffusionCommitGraphView".
Aug 12 2020, 3:59 PM
epriestley committed rP9fa25253844e: Improve rendering of history graph in "CommitGraphView" (authored by epriestley).
Improve rendering of history graph in "CommitGraphView"
Aug 12 2020, 3:59 PM
epriestley committed rP46695c76ebfe: Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and… (authored by epriestley).
Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and…
Aug 12 2020, 3:59 PM
epriestley closed D21411: Improve rendering of history graph in "CommitGraphView".
Aug 12 2020, 3:59 PM
epriestley closed D21410: Introduce "DiffusionCommitGraphView", which unifies "HistoryListView" and "HistoryTableView".
Aug 12 2020, 3:59 PM
epriestley committed rPc6de7c66a3c6: Remove the "Graph" view as a dedicated repository view (authored by epriestley).
Remove the "Graph" view as a dedicated repository view
Aug 12 2020, 3:59 PM
epriestley closed D21409: Remove the "Graph" view as a dedicated repository view.
Aug 12 2020, 3:59 PM
epriestley committed rP9afc5c628757: Remove "Recent Commits" from repository landing page (authored by epriestley).
Remove "Recent Commits" from repository landing page
Aug 12 2020, 3:59 PM
epriestley closed D21408: Remove "Recent Commits" from repository landing page.
Aug 12 2020, 3:59 PM
epriestley committed rPc8a279957dc1: Remove "DiffusionTagTableView" (authored by epriestley).
Remove "DiffusionTagTableView"
Aug 12 2020, 3:59 PM
epriestley closed D21407: Remove "DiffusionTagTableView".
Aug 12 2020, 3:59 PM
epriestley committed rP60e9f641907a: Remove the "authored" subheader from commits (authored by epriestley).
Remove the "authored" subheader from commits
Aug 12 2020, 3:59 PM
epriestley closed D21406: Remove the "authored" subheader from commits.
Aug 12 2020, 3:58 PM