Turn "bypassCache" into a no-op in "diffusion.querycommits"
7d6874d9f099
Actions

Description

Turn "bypassCache" into a no-op in "diffusion.querycommits"

Summary: Ref T13552. The internal caller for this now uses "internal.commit.search", which is always authority-reading. No legitimate external caller should rely on the behavior of "bypassCache"; no-op it to simplify behavior.

Test Plan: Called "diffusion.querycommits", saw the same data as before.

Maniphest Tasks: T13552

Differential Revision: https://secure.phabricator.com/D21447

Details

Provenance

epriestley	Authored on Aug 12 2020, 7:09 PM
epriestley	Pushed on Sep 16 2020, 12:36 AM

Differential Revision

D21447: Turn "bypassCache" into a no-op in "diffusion.querycommits"

Parents

rP3a80efa440f0: Build "DiffusionCommitRef" objects from "internal.commit.search", not…

Branches

Unknown

Tags

Unknown

Tasks

T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch

Build Status

Buildable 24897
Build 34351: Run Core Tests

Event Timeline

epriestley committed rP7d6874d9f099: Turn "bypassCache" into a no-op in "diffusion.querycommits" (authored by epriestley).Sep 16 2020, 12:36 AM

epriestley added a task: T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch.

epriestley added an edge: D21447: Turn "bypassCache" into a no-op in "diffusion.querycommits".

Harbormaster failed to build B24897: rP7d6874d9f099: Turn "bypassCache" into a no-op in "diffusion.querycommits"!Sep 16 2020, 12:47 AM

Harbormaster completed building B24897: rP7d6874d9f099: Turn "bypassCache" into a no-op in "diffusion.querycommits".Sep 16 2020, 2:01 AM

Changes (1)

Path

Size

src/

applications/

diffusion/

conduit/

DiffusionQueryCommitsConduitAPIMethod.php

rP7d6874d9f099

View Options

src/applications/diffusion/conduit/DiffusionQueryCommitsConduitAPIMethod.php