Fix a false negative in lint for "xsprintf()"-family functions
ClosedPublic
Actions

Authored by epriestley on Sep 5 2020, 12:07 AM.

Details

Reviewers: None
Maniphest Tasks: T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path
Commits: rARC73847a4b194b: Fix a false negative in lint for "xsprintf()"-family functions

Summary

Ref T13577. This lint rule correctly detects the error in pht('x %s y') but the narrow test for n_STRING_SCALAR prevents it from detecting the error in pht('x %s y'.'z').

Make the test broader.

Test Plan

Ran arc lint on HTTPSFuture.php, got a detection of the issue in T13577.
Added a failing test and made it pass.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 5 2020, 12:07 AM

Harbormaster completed remote builds in B24873: Diff 51058.Sep 5 2020, 12:07 AM

epriestley requested review of this revision.Sep 5 2020, 12:07 AM

epriestley mentioned this in T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path.Sep 5 2020, 12:09 AM

epriestley mentioned this in D21454: Fix a missing "pht()" parameter in HTTPSFuture.Sep 5 2020, 12:09 AM

epriestley mentioned this in D21456: Fix additional "xsprintf()"-family static parameter errors.Sep 5 2020, 12:32 AM

epriestley mentioned this in D21457: Fix additional "xprintf()"-class static parameter lint errors.Sep 8 2020, 3:55 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 8 2020, 6:45 PM

Closed by commit rARC73847a4b194b: Fix a false negative in lint for "xsprintf()"-family functions (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rP6e1b5da1121c: Fix additional "xprintf()"-class static parameter lint errors.

epriestley mentioned this in rARC1c327208d7ba: Fix a missing "pht()" parameter in HTTPSFuture.

epriestley added a commit: rARC73847a4b194b: Fix a false negative in lint for "xsprintf()"-family functions.

epriestley mentioned this in rARC7112ee3d5960: Fix additional "xsprintf()"-family static parameter errors.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

ArcanistFormattedStringXHPASTLinterRule.php

7 lines

__tests__/

formatted-string/

formatted-string.lint-test

5 lines

Diff 51066

View Options

src/lint/linter/xhpast/rules/ArcanistFormattedStringXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/formatted-string/formatted-string.lint-test

Fix a false negative in lint for "xsprintf()"-family functionsClosedPublicActions