Paths

Table of Contentst

Allow AAST to extract string literal values from HEREDOCs
83e63aeb078b
Actions

Description

Allow AAST to extract string literal values from HEREDOCs

Summary:
Ref T13577. I'd like to arc lint --everything to find other bad calls to pht() and similar functions, but n_HEREDOC nodes currently can not generate a response to "getStringLiteralValue()".

Support literal extraction from heredocs.

Test Plan: Added a test, made it pass. Will lint everything.

Maniphest Tasks: T13577

Differential Revision: https://secure.phabricator.com/D21455

Details

Provenance

epriestley	Authored on Sep 5 2020, 12:24 AM
epriestley	Pushed on Sep 8 2020, 6:45 PM

Differential Revision

D21455: Allow AAST to extract string literal values from HEREDOCs

Parents

rARC1c327208d7ba: Fix a missing "pht()" parameter in HTTPSFuture

Branches

Unknown

Tags

Unknown

Tasks

T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path

Build Status

Buildable 24880
Build 34326: Run Core Tests

Event Timeline

epriestley committed rARC83e63aeb078b: Allow AAST to extract string literal values from HEREDOCs (authored by epriestley).Sep 8 2020, 6:45 PM

epriestley added a task: T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path.

epriestley added an edge: D21455: Allow AAST to extract string literal values from HEREDOCs.

Harbormaster completed building B24880: rARC83e63aeb078b: Allow AAST to extract string literal values from HEREDOCs.Sep 8 2020, 6:46 PM

Changes (2)

Path

Size

src/

lint/

linter/

xhpast/

rules/

__tests__/

formatted-string/

formatted-string.lint-test

parser/

xhpast/

api/

XHPASTNode.php

rARC83e63aeb078b

View Options

src/lint/linter/xhpast/rules/tests/formatted-string/formatted-string.lint-test