Allow AAST to extract string literal values from HEREDOCs
ClosedPublic
Actions

Authored by epriestley on Sep 5 2020, 12:26 AM.

Details

Reviewers: None
Maniphest Tasks: T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path
Commits: rARC83e63aeb078b: Allow AAST to extract string literal values from HEREDOCs

Summary

Ref T13577. I'd like to arc lint --everything to find other bad calls to pht() and similar functions, but n_HEREDOC nodes currently can not generate a response to "getStringLiteralValue()".

Support literal extraction from heredocs.

Test Plan

Added a test, made it pass. Will lint everything.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 5 2020, 12:26 AM

Harbormaster completed remote builds in B24875: Diff 51060.Sep 5 2020, 12:26 AM

epriestley requested review of this revision.Sep 5 2020, 12:26 AM

epriestley mentioned this in T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path.Sep 5 2020, 12:32 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 8 2020, 6:46 PM

Closed by commit rARC83e63aeb078b: Allow AAST to extract string literal values from HEREDOCs (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC83e63aeb078b: Allow AAST to extract string literal values from HEREDOCs.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

xhpast/

rules/

__tests__/

formatted-string/

formatted-string.lint-test

11 lines

parser/

xhpast/

api/

XHPASTNode.php

56 lines

Diff 51065

View Options

src/lint/linter/xhpast/rules/tests/formatted-string/formatted-string.lint-test

View Options

src/parser/xhpast/api/XHPASTNode.php

Allow AAST to extract string literal values from HEREDOCsClosedPublicActions