Page MenuHomePhabricator

Allow AAST to extract string literal values from HEREDOCs
ClosedPublic

Authored by epriestley on Sat, Sep 5, 12:26 AM.

Details

Summary

Ref T13577. I'd like to arc lint --everything to find other bad calls to pht() and similar functions, but n_HEREDOC nodes currently can not generate a response to "getStringLiteralValue()".

Support literal extraction from heredocs.

Test Plan

Added a test, made it pass. Will lint everything.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.