Page MenuHomePhabricator

Allow AAST to extract string literal values from HEREDOCs
ClosedPublic

Authored by epriestley on Sep 5 2020, 12:26 AM.
Tags
None
Referenced Files
F18798682: D21455.id.diff
Fri, Oct 17, 7:44 AM
F18706932: D21455.diff
Sun, Sep 28, 5:40 PM
F18705358: D21455.diff
Sun, Sep 28, 10:56 AM
F18638078: D21455.diff
Sep 17 2025, 9:17 AM
F18637038: D21455.diff
Sep 17 2025, 6:13 AM
F18634412: D21455.id.diff
Sep 16 2025, 10:16 PM
F18627608: D21455.diff
Sep 16 2025, 4:23 AM
F18623518: D21455.diff
Sep 15 2025, 4:07 PM
Subscribers
None

Details

Summary

Ref T13577. I'd like to arc lint --everything to find other bad calls to pht() and similar functions, but n_HEREDOC nodes currently can not generate a response to "getStringLiteralValue()".

Support literal extraction from heredocs.

Test Plan

Added a test, made it pass. Will lint everything.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable