Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon…
7daaaa8463e2
Actions

Description

Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon Overseer

Summary: Ref T13579. This property was removed in D21425, but I missed this usage site. Remove the assignment; this class no longer tracks the subprocess PID directly.

Test Plan: Searched for "->pid", no further hits.

Maniphest Tasks: T13579

Differential Revision: https://secure.phabricator.com/D21452

Details

Provenance

epriestley	Authored on Sep 4 2020, 11:37 PM
epriestley	Pushed on Sep 4 2020, 11:41 PM

Differential Revision

D21452: Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon Overseer

Parents

rP0854425d191f: When printing timestamps on paper: use an absolute, context-free date format

Branches

Unknown

Tags

Unknown

Tasks

T13579: Overseer may fatal when trying to write to "pid" property in "annihilateProcessGroup()"

Build Status

Buildable 24870
Build 34311: Run Core Tests

Event Timeline

epriestley committed rP7daaaa8463e2: Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon… (authored by epriestley).Sep 4 2020, 11:41 PM

epriestley added an edge: D21452: Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon Overseer.

epriestley added a task: T13579: Overseer may fatal when trying to write to "pid" property in "annihilateProcessGroup()".

Harbormaster completed building B24870: rP7daaaa8463e2: Remove obsolete write to "pid" property in "annihilateProcessGroup()" in Daemon….Sep 4 2020, 11:42 PM

Changes (1)

Path

Size

src/

infrastructure/

daemon/

PhutilDaemonHandle.php

rP7daaaa8463e2

View Options

src/infrastructure/daemon/PhutilDaemonHandle.php