Page MenuHomePhabricator
Feed All Stories

Mar 26 2018

epriestley accepted D19261: Remove accidental sprintf injection in error reporting.

I'll take a look at the tests, definitely doesn't look related.

Mar 26 2018, 8:34 PM
alexmv requested review of D19261: Remove accidental sprintf injection in error reporting.

I'm getting permanent build failures on this diff, which look unrelated to the diff itself?

Mar 26 2018, 6:03 PM
mydeveloperday accepted D19258: Support logged-out access to the document rendering endpoint.
Mar 26 2018, 2:25 PM
mydeveloperday accepted D19260: Render directly embedded image data represented as a string in Jupyter notebooks.
Mar 26 2018, 2:25 PM
mydeveloperday accepted D19259: Minor document rendering fixes: dropdown for synchronous files, URI normalization for default renderers.
Mar 26 2018, 2:24 PM
epriestley requested review of D19260: Render directly embedded image data represented as a string in Jupyter notebooks.
Mar 26 2018, 2:24 PM
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19260: Render directly embedded image data represented as a string in Jupyter notebooks.
Mar 26 2018, 2:23 PM · Plans, Files, Differential, Diffusion
epriestley requested review of D19259: Minor document rendering fixes: dropdown for synchronous files, URI normalization for default renderers.
Mar 26 2018, 2:21 PM
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19259: Minor document rendering fixes: dropdown for synchronous files, URI normalization for default renderers.
Mar 26 2018, 2:20 PM · Plans, Files, Differential, Diffusion
epriestley requested review of D19258: Support logged-out access to the document rendering endpoint.
Mar 26 2018, 2:17 PM
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19258: Support logged-out access to the document rendering endpoint.
Mar 26 2018, 2:16 PM · Plans, Files, Differential, Diffusion
epriestley committed rP5e710959bed9: (stable) Drop uniqueness constraint on PushEvent request ID (authored by epriestley).
(stable) Drop uniqueness constraint on PushEvent request ID
Mar 26 2018, 2:02 PM
epriestley committed rPf583406ba93a: Drop uniqueness constraint on PushEvent request ID (authored by epriestley).
Drop uniqueness constraint on PushEvent request ID
Mar 26 2018, 2:02 PM
epriestley closed D19257: Drop uniqueness constraint on PushEvent request ID.
Mar 26 2018, 2:02 PM
epriestley requested review of D19257: Drop uniqueness constraint on PushEvent request ID.
Mar 26 2018, 1:59 PM

Mar 24 2018

NDKilla added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

the best part of being so unethical

Mar 24 2018, 10:25 PM · Phacility

Mar 23 2018

epriestley edited the content of Changelog.
Mar 23 2018, 9:50 PM
epriestley committed rP8c5aceec6090: (stable) Promote 2018 Week 12 (authored by epriestley).
(stable) Promote 2018 Week 12
Mar 23 2018, 9:49 PM
epriestley created 2018 Week 12 (Late March).
Mar 23 2018, 9:49 PM
epriestley committed rPbba1b185f834: Improve minor client behaviors for document rendering (authored by epriestley).
Improve minor client behaviors for document rendering
Mar 23 2018, 9:09 PM
epriestley closed D19256: Improve minor client behaviors for document rendering.
Mar 23 2018, 9:09 PM
epriestley requested review of D19256: Improve minor client behaviors for document rendering.
Mar 23 2018, 8:50 PM
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19256: Improve minor client behaviors for document rendering.
Mar 23 2018, 8:49 PM · Plans, Files, Differential, Diffusion
epriestley committed rP49063647515c: Add a JSON document rendering engine (authored by epriestley).
Add a JSON document rendering engine
Mar 23 2018, 7:29 PM
epriestley closed D19255: Add a JSON document rendering engine.
Mar 23 2018, 7:29 PM
epriestley committed rPd2727d24da6e: Add an abstract "Text" document engine and a "Source" document engine (authored by epriestley).
Add an abstract "Text" document engine and a "Source" document engine
Mar 23 2018, 7:28 PM
epriestley closed D19254: Add an abstract "Text" document engine and a "Source" document engine.
Mar 23 2018, 7:28 PM
mydeveloperday accepted D19255: Add a JSON document rendering engine.
Mar 23 2018, 4:12 PM
epriestley requested review of D19255: Add a JSON document rendering engine.
Mar 23 2018, 3:03 PM
jparise edited the content of Community Resources.
Mar 23 2018, 2:56 PM
mydeveloperday accepted D19254: Add an abstract "Text" document engine and a "Source" document engine.
Mar 23 2018, 2:45 PM
epriestley requested review of D19254: Add an abstract "Text" document engine and a "Source" document engine.
Mar 23 2018, 2:42 PM
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19254: Add an abstract "Text" document engine and a "Source" document engine.
Mar 23 2018, 2:41 PM · Plans, Files, Differential, Diffusion
epriestley committed rPcbf3d3c37154: Add a very rough, proof-of-concept Jupyter notebook document engine (authored by epriestley).
Add a very rough, proof-of-concept Jupyter notebook document engine
Mar 23 2018, 2:14 PM
epriestley closed D19253: Add a very rough, proof-of-concept Jupyter notebook document engine.
Mar 23 2018, 2:14 PM
epriestley committed rPfb4ce851c4ae: Add a PDF document "rendering" engine (authored by epriestley).
Add a PDF document "rendering" engine
Mar 23 2018, 2:14 PM
epriestley closed D19252: Add a PDF document "rendering" engine.
Mar 23 2018, 2:14 PM
mydeveloperday added a comment to rP8b658706a8c4: Add a basic Remarkup document rendering engine.

if you are OK with me doing so, I'd like be happy to act as a reviewer so I can learn what your doing.

Mar 23 2018, 2:12 PM
epriestley committed rP8b658706a8c4: Add a basic Remarkup document rendering engine (authored by epriestley).
Add a basic Remarkup document rendering engine
Mar 23 2018, 2:08 PM
epriestley closed D19251: Add a basic Remarkup document rendering engine.
Mar 23 2018, 2:07 PM
epriestley requested review of D19253: Add a very rough, proof-of-concept Jupyter notebook document engine.
Mar 23 2018, 2:07 PM
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19253: Add a very rough, proof-of-concept Jupyter notebook document engine.
Mar 23 2018, 2:06 PM · Plans, Files, Differential, Diffusion
mydeveloperday added a comment to D19251: Add a basic Remarkup document rendering engine.

if you were writing a custom DocumentEngine for say .myformat which is perhaps traditionally mapped to the mime type of text/plain, then I'm guessing adding the following, is a good way to get your engine to be picked as the "default" viewer

Mar 23 2018, 12:12 PM
epriestley requested review of D19252: Add a PDF document "rendering" engine.
Mar 23 2018, 12:11 PM
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19252: Add a PDF document "rendering" engine.
Mar 23 2018, 12:10 PM · Plans, Files, Differential, Diffusion
epriestley updated the task description for T13112: Safari, PDFs, and Content-Security-Policy interact oddly.
Mar 23 2018, 11:50 AM · Safari, Security, Files
epriestley closed T13112: Safari, PDFs, and Content-Security-Policy interact oddly as Resolved.

Actually, it seems like rel="noreferrer" fixes this. This is bizarre so maybe this is a problem with a spooky ghost haunting my computer?

Mar 23 2018, 11:48 AM · Safari, Security, Files
epriestley triaged T13112: Safari, PDFs, and Content-Security-Policy interact oddly as Normal priority.
Mar 23 2018, 11:47 AM · Safari, Security, Files
epriestley added a comment to D19251: Add a basic Remarkup document rendering engine.

\z is a "better" version of $ and should usually be used instead of $:

Mar 23 2018, 11:38 AM
mydeveloperday added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

I really like this, Remarkup idea, I think there are many text based files that people add to reviews which would be easily transformed to something more readable by being transfer directly to Remarkup, even for example something as simple as CSV,

Mar 23 2018, 11:27 AM · Plans, Files, Differential, Diffusion
avivey accepted D19251: Add a basic Remarkup document rendering engine.

(What's \z in the regexp?)

Mar 23 2018, 11:24 AM
mydeveloperday awarded D19251: Add a basic Remarkup document rendering engine a Like token.
Mar 23 2018, 11:19 AM
epriestley requested review of D19251: Add a basic Remarkup document rendering engine.
Mar 23 2018, 11:05 AM
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19251: Add a basic Remarkup document rendering engine.
Mar 23 2018, 11:04 AM · Plans, Files, Differential, Diffusion

Mar 22 2018

epriestley committed rPdf3c937dab8c: Record lock timing information on PushEvents (authored by epriestley).
Record lock timing information on PushEvents
Mar 22 2018, 8:46 PM
epriestley closed D19250: Record lock timing information on PushEvents.
Mar 22 2018, 8:46 PM
epriestley committed rP69bff489d4ec: Generate a random unique "Request ID" for SSH requests so processes can… (authored by epriestley).
Generate a random unique "Request ID" for SSH requests so processes can…
Mar 22 2018, 8:44 PM
epriestley closed D19249: Generate a random unique "Request ID" for SSH requests so processes can coordinate better.
Mar 22 2018, 8:44 PM
epriestley committed rPe010aaca4329: accidentally a word (authored by epriestley).
accidentally a word
Mar 22 2018, 8:43 PM
epriestley closed D19248: accidentally a word.
Mar 22 2018, 8:43 PM
epriestley committed rP859b27497095: Provide more information to users during `git push` while waiting for write… (authored by epriestley).
Provide more information to users during `git push` while waiting for write…
Mar 22 2018, 8:42 PM
epriestley closed D19247: Provide more information to users during `git push` while waiting for write locks.
Mar 22 2018, 8:42 PM
epriestley added a comment to T13111: Periodically run `git prune` on Git working copies.

That's a reasonable point. The details of PHI386 weren't very indicative one way or another since I didn't end up GC'ing the repository multiple times. I suppose I can go GC it again during the deployment window this week and see how long it takes.

Mar 22 2018, 8:27 PM · Phacility, Diffusion
asherkin added a comment to T13111: Periodically run `git prune` on Git working copies.

Previously, in PHI386, an unusually large repository for the same instance took about 5 hours to git gc.

Mar 22 2018, 8:23 PM · Phacility, Diffusion
asherkin accepted D19247: Provide more information to users during `git push` while waiting for write locks.
Mar 22 2018, 8:15 PM
epriestley requested review of D19250: Record lock timing information on PushEvents.
Mar 22 2018, 8:10 PM
epriestley added a revision to T13109: Improve cluster write feedback and write routing: D19250: Record lock timing information on PushEvents.
Mar 22 2018, 8:09 PM · Diffusion
epriestley requested review of D19249: Generate a random unique "Request ID" for SSH requests so processes can coordinate better.
Mar 22 2018, 7:57 PM
epriestley added a revision to T13109: Improve cluster write feedback and write routing: D19249: Generate a random unique "Request ID" for SSH requests so processes can coordinate better.
Mar 22 2018, 7:56 PM · Diffusion
epriestley added a comment to T13109: Improve cluster write feedback and write routing.

Modify the PushEvent table to contain more information about locks and waits (e.g., active queue status; how long the push waited for the write lock; how long the push spent synchronizing).

Mar 22 2018, 7:27 PM · Diffusion
jmeador added a comment to rPc8583b016daf: When workflow dialog buttons are clicked, disable the button.

Thanks, D19248.

Mar 22 2018, 6:32 PM
epriestley requested review of D19248: accidentally a word.
Mar 22 2018, 6:01 PM
epriestley added a comment to rPc8583b016daf: When workflow dialog buttons are clicked, disable the button.

Thanks, D19248.

Mar 22 2018, 6:00 PM
epriestley updated the diff for D19247: Provide more information to users during `git push` while waiting for write locks.
  • Add a missing return; for the case when the locking writer hasn't written their durable lock row yet.
Mar 22 2018, 5:35 PM
epriestley added a comment to D19247: Provide more information to users during `git push` while waiting for write locks.

Thanks!

Mar 22 2018, 5:34 PM
epriestley triaged T13111: Periodically run `git prune` on Git working copies as Normal priority.
Mar 22 2018, 4:56 PM · Phacility, Diffusion
demo created E1672: Test demo.
Mar 22 2018, 1:44 PM
asherkin added inline comments to D19247: Provide more information to users during `git push` while waiting for write locks.
Mar 22 2018, 1:02 PM
mydeveloperday awarded T13105: Plans: Rich presentation and diff rendering pipelines for various file types a Like token.
Mar 22 2018, 9:59 AM · Plans, Files, Differential, Diffusion
jmeador added inline comments to rPc8583b016daf: When workflow dialog buttons are clicked, disable the button.
Mar 22 2018, 7:23 AM
epriestley requested review of D19247: Provide more information to users during `git push` while waiting for write locks.
Mar 22 2018, 2:12 AM
epriestley added a revision to T13109: Improve cluster write feedback and write routing: D19247: Provide more information to users during `git push` while waiting for write locks.
Mar 22 2018, 2:11 AM · Diffusion
NDKilla added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

These people are good, I like them.

Mar 22 2018, 1:52 AM · Phacility
epriestley added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

I kind of wish I could see PHI415. Do people send in support tickets about path of exile?

Mar 22 2018, 1:50 AM · Phacility
NDKilla added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

See PHI415.

Mar 22 2018, 1:47 AM · Phacility
NDKilla added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

Wow I feel unethical looking at your profile now.

Mar 22 2018, 1:46 AM · Phacility

Mar 21 2018

epriestley added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

wow every piece of gear you have is better than all the gear I own put together

Mar 21 2018, 11:48 PM · Phacility
jcox awarded T13107: Git, Slowly and Painfully a 100 token.
Mar 21 2018, 10:52 PM · Guides
NDKilla added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

Nice nice. I've had a few kaoms and some other opop 1000% unethical gear because I've never made it past act 1 in TRUE ETHICAL SSF.

Mar 21 2018, 10:50 PM · Phacility
thoughtpolice awarded T13107: Git, Slowly and Painfully a 100 token.
Mar 21 2018, 9:53 PM · Guides
epriestley committed rPc8583b016daf: When workflow dialog buttons are clicked, disable the button (authored by epriestley).
When workflow dialog buttons are clicked, disable the button
Mar 21 2018, 6:58 PM
epriestley closed T11145: Dialog submit buttons don't disable on click as Resolved by committing rPc8583b016daf: When workflow dialog buttons are clicked, disable the button.
Mar 21 2018, 6:58 PM · Restricted Project, PHUI, Bug Report
epriestley closed D19246: When workflow dialog buttons are clicked, disable the button.
Mar 21 2018, 6:58 PM
epriestley committed rP9e278a89ba30: If a Workflow form receives a redirect response, don't re-enable the submit… (authored by epriestley).
If a Workflow form receives a redirect response, don't re-enable the submit…
Mar 21 2018, 6:56 PM
epriestley closed D19245: If a Workflow form receives a redirect response, don't re-enable the submit buttons.
Mar 21 2018, 6:56 PM
epriestley requested review of D19246: When workflow dialog buttons are clicked, disable the button.
Mar 21 2018, 6:56 PM
epriestley committed rP6ed123e0801a: Propagate "unexpandable" PHIDs to feed notification recipient expansion (authored by epriestley).
Propagate "unexpandable" PHIDs to feed notification recipient expansion
Mar 21 2018, 6:56 PM
epriestley closed D19244: Propagate "unexpandable" PHIDs to feed notification recipient expansion.
Mar 21 2018, 6:56 PM
epriestley added a revision to T11145: Dialog submit buttons don't disable on click: D19246: When workflow dialog buttons are clicked, disable the button.
Mar 21 2018, 6:55 PM · Restricted Project, PHUI, Bug Report
epriestley added a revision to T13108: Plans: 2018 Week 12 Bonus Content: D19246: When workflow dialog buttons are clicked, disable the button.
Mar 21 2018, 6:55 PM · Plans