Remove accidental sprintf injection in error reporting
ClosedPublic
Actions

Authored by alexmv on Mar 26 2018, 5:38 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCbf3d32e34e79: Remove accidental sprintf injection in error reporting

Summary

STDERR output with %s in it could cause:

ERROR 2: fprintf(): Too few arguments at [/usr/local/arcanist/src/workflow/ArcanistFeatureWorkflow.php:170]

Test Plan

Untested.

Diff Detail

Repository

rARC Arcanist

Branch

sprintf-injection

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19927
Build 27013: Run Core Tests
Build 27012: arc lint + arc unit

Event Timeline

alexmv created this revision.Mar 26 2018, 5:38 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 26 2018, 5:38 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster failed remote builds in B19927: Diff 46107!Mar 26 2018, 5:38 PM

Harbormaster failed remote builds in B19927: Diff 46107!Mar 26 2018, 5:56 PM

I'm getting permanent build failures on this diff, which look unrelated to the diff itself?

I'll take a look at the tests, definitely doesn't look related.

This revision is now accepted and ready to land.Mar 26 2018, 8:34 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 26 2018, 8:34 PM

alexmv closed this revision.Mar 26 2018, 8:56 PM

The test failures are just T10093, i.e. arc didn't push the changes to the staging environment. Most common reason is that you're working off a local fork, not the One True Upstream Repository?

Yeah, that's prbably exactly it -- we push staging refs to a different namespace to not clutter the standard tag namespace, which is likely the problem.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistFeatureWorkflow.php

2 lines

Diff 46107

View Options

src/workflow/ArcanistFeatureWorkflow.php

Remove accidental sprintf injection in error reportingClosedPublicActions