Page MenuHomePhabricator
Differential D19260

Render directly embedded image data represented as a string in Jupyter notebooks
ClosedPublic
Actions

Authored by epriestley on Mar 26 2018, 2:23 PM.

Details

Reviewers
mydeveloperday
Maniphest Tasks
T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits
rPc5b244bfd04f: Render directly embedded image data represented as a string in Jupyter notebooks
Summary

Depends on D19259. Ref T13105. Some examples represent image data as ["da", "ta"] while others represent it as "data". Accept either.

Test Plan

Rendered example notebooks with both kinds of images.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 26 2018, 2:23 PM
epriestley requested review of this revision.Mar 26 2018, 2:24 PM
mydeveloperday accepted this revision.Mar 26 2018, 2:25 PM
This revision is now accepted and ready to land.Mar 26 2018, 2:25 PM
Closed by commit rPc5b244bfd04f: Render directly embedded image data represented as a string in Jupyter notebooks (authored by epriestley). · Explain WhyMar 28 2018, 10:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46112

View Options

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

Loading...
Phabricator · Built by Phacility