Page MenuHomePhabricator
Differential D19260

Render directly embedded image data represented as a string in Jupyter notebooks
ClosedPublic
Actions

Authored by epriestley on Mar 26 2018, 2:23 PM.
Tags
None
Referenced Files
F13096724: D19260.diff
Thu, Apr 25, 6:34 PM
Unknown Object (File)
Wed, Apr 24, 10:56 PM
Unknown Object (File)
Sat, Apr 20, 6:26 AM
Unknown Object (File)
Fri, Apr 19, 7:35 PM
Unknown Object (File)
Sun, Mar 31, 11:26 AM
Unknown Object (File)
Sun, Mar 31, 11:26 AM
Unknown Object (File)
Sun, Mar 31, 11:26 AM
Unknown Object (File)
Sun, Mar 31, 11:26 AM
View All Files
Subscribers
None

Details

Reviewers
mydeveloperday
Maniphest Tasks
T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits
rPc5b244bfd04f: Render directly embedded image data represented as a string in Jupyter notebooks
Summary

Depends on D19259. Ref T13105. Some examples represent image data as ["da", "ta"] while others represent it as "data". Accept either.

Test Plan

Rendered example notebooks with both kinds of images.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
files/
document/
3 lines

Diff 46112

View Options

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

Loading...
Phabricator · Built by Phacility