Page MenuHomePhabricator

Minor document rendering fixes: dropdown for synchronous files, URI normalization for default renderers
ClosedPublic

Authored by epriestley on Mar 26 2018, 2:20 PM.
Tags
None
Referenced Files
F18754947: D19259.id46105.diff
Sun, Oct 5, 2:31 AM
F18745718: D19259.id46111.diff
Fri, Oct 3, 8:57 AM
F18719809: D19259.diff
Mon, Sep 29, 5:40 PM
F18585722: D19259.diff
Sep 11 2025, 4:12 PM
F18563515: D19259.id46111.diff
Sep 9 2025, 7:37 AM
F18509476: D19259.id.diff
Sep 5 2025, 3:25 AM
F18502484: D19259.diff
Sep 4 2025, 10:28 PM
F18408478: D19259.diff
Aug 30 2025, 2:45 AM
Subscribers
None

Details

Summary

Depends on D19258. Ref T13105.

  • When the default renderer is an Ajax renderer, don't replace the URI. For example, when viewing a Jupyter notebook, the URI should remain /F123, not instantly change to /view/123/jupyter/.
  • Fix an issue where non-ajax renderers could fail to display the dropdown menu properly.
Test Plan
  • Viewed a Jupyter notebook, stayed on the same URI.
  • Changed rendering, got different URIs.
  • Viewed a JSON file and toggled renderers via dropdown.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable