Page MenuHomePhabricator

Improve minor client behaviors for document rendering
ClosedPublic

Authored by epriestley on Mar 23 2018, 8:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 7:35 PM
Unknown Object (File)
Tue, Dec 10, 7:55 AM
Unknown Object (File)
Fri, Dec 6, 9:06 AM
Unknown Object (File)
Sun, Dec 1, 7:04 AM
Unknown Object (File)
Fri, Nov 29, 5:01 PM
Unknown Object (File)
Thu, Nov 28, 3:16 AM
Unknown Object (File)
Thu, Nov 28, 1:34 AM
Unknown Object (File)
Wed, Nov 27, 2:32 PM
Subscribers
None

Details

Summary

Ref T13105. This adds various small client-side improvements to document rendering.

  • In the menu, show which renderer is in use.
  • Make linking to lines work.
  • Make URIs persist information about which rendering engine is in use.
  • Improve the UI feedback for transitions between document types.
  • Load slower documents asynchronously by default.
  • Discard irrelevant requests if you spam the view menu.
Test Plan

Loaded files, linked to lines, swapped between modes, copy/pasted URLs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 23 2018, 9:09 PM
This revision was automatically updated to reflect the committed changes.