Page MenuHomePhabricator

When workflow dialog buttons are clicked, disable the button
ClosedPublic

Authored by epriestley on Mar 21 2018, 6:54 PM.
Tags
None
Referenced Files
F18152896: D19246.id46076.diff
Thu, Aug 14, 7:18 PM
F18127052: D19246.id.diff
Wed, Aug 13, 3:11 PM
F18110234: D19246.diff
Mon, Aug 11, 5:34 PM
F18095006: D19246.id.diff
Thu, Aug 7, 10:29 PM
F17848952: D19246.id.diff
Jul 27 2025, 7:57 AM
Unknown Object (File)
May 31 2025, 12:13 PM
Unknown Object (File)
May 8 2025, 12:33 AM
Unknown Object (File)
May 2 2025, 2:46 PM
Subscribers
None

Details

Summary

Depends on D19245. Fixes T11145. Ref T13108. See PHI488. Disable workflow buttons when they're clicked to prevent accidental client-side double submission.

This might have some weird side effects but we should normally never need to re-use a workflow dialog form so it's not immediately obvious that this can break anything.

Test Plan
  • Added sleep(1) to the Mute controller and the Maniphest task controller.
  • Added phlog(...) to the Mute controller.
  • Opened the mute dialog, mashed the button a thousand times.
    • Before: Saw a bunch of logs.
    • After: Button immediately disables, saw only one log.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 21 2018, 6:58 PM
This revision was automatically updated to reflect the committed changes.