Page MenuHomePhabricator
Differential D19254

Add an abstract "Text" document engine and a "Source" document engine
ClosedPublic
Actions

Authored by epriestley on Mar 23 2018, 2:41 PM.

Details

Reviewers
mydeveloperday
Maniphest Tasks
T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits
rPd2727d24da6e: Add an abstract "Text" document engine and a "Source" document engine
Summary

Ref T13105. Allow normal text files to be rendered as documents, and add a "source code" rendering engine.

Test Plan

Viewed some source code.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 23 2018, 2:41 PM
Harbormaster completed remote builds in B19914: Diff 46096.Mar 23 2018, 2:42 PM
epriestley requested review of this revision.Mar 23 2018, 2:42 PM
mydeveloperday accepted this revision.Mar 23 2018, 2:45 PM
This revision is now accepted and ready to land.Mar 23 2018, 2:45 PM
epriestley added a child revision: D19255: Add a JSON document rendering engine.Mar 23 2018, 3:02 PM
Closed by commit rPd2727d24da6e: Add an abstract "Text" document engine and a "Source" document engine (authored by epriestley). · Explain WhyMar 23 2018, 7:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
4 lines
applications/
files/
document/
30 lines
33 lines
webroot/
rsrc/
css/
layout/
20 lines
phui/
4 lines

Diff 46098

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/files/document/PhabricatorSourceDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorTextDocumentEngine.php

Loading...
View Options

webroot/rsrc/css/layout/phabricator-source-code-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-property-list-view.css

Loading...
Phabricator · Built by Phacility