Differential D19254

Add an abstract "Text" document engine and a "Source" document engine
ClosedPublic
Actions

Authored by epriestley on Mar 23 2018, 2:41 PM.

Details

Reviewers

mydeveloperday

Maniphest Tasks

T13105: Plans: Rich presentation and diff rendering pipelines for various file types

Commits

rPd2727d24da6e: Add an abstract "Text" document engine and a "Source" document engine

Summary

Ref T13105. Allow normal text files to be rendered as documents, and add a "source code" rendering engine.

Test Plan

Viewed some source code.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 23 2018, 2:41 PM

Harbormaster completed remote builds in B19914: Diff 46096.Mar 23 2018, 2:42 PM

epriestley requested review of this revision.Mar 23 2018, 2:42 PM

mydeveloperday accepted this revision.Mar 23 2018, 2:45 PM

This revision is now accepted and ready to land.Mar 23 2018, 2:45 PM

epriestley added a child revision: D19255: Add a JSON document rendering engine.Mar 23 2018, 3:02 PM

Closed by commit rPd2727d24da6e: Add an abstract "Text" document engine and a "Source" document engine (authored by epriestley). · Explain WhyMar 23 2018, 7:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

10 lines

src/

__phutil_library_map__.php

4 lines

applications/

files/

document/

PhabricatorSourceDocumentEngine.php

30 lines

PhabricatorTextDocumentEngine.php

33 lines

webroot/

rsrc/

css/

layout/

phabricator-source-code-view.css

20 lines

phui/

phui-property-list-view.css

4 lines

Diff 46098

View Options

resources/celerity/map.php

View Options

src/__phutil_library_map__.php

View Options

src/applications/files/document/PhabricatorSourceDocumentEngine.php

View Options

src/applications/files/document/PhabricatorTextDocumentEngine.php

View Options

webroot/rsrc/css/layout/phabricator-source-code-view.css

View Options

webroot/rsrc/css/phui/phui-property-list-view.css

Add an abstract "Text" document engine and a "Source" document engineClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46098

resources/celerity/map.php

src/__phutil_library_map__.php

src/applications/files/document/PhabricatorSourceDocumentEngine.php

src/applications/files/document/PhabricatorTextDocumentEngine.php

webroot/rsrc/css/layout/phabricator-source-code-view.css

webroot/rsrc/css/phui/phui-property-list-view.css

Add an abstract "Text" document engine and a "Source" document engine
ClosedPublic
Actions

Revision Contents
Changeset List