Differential D19254

Add an abstract "Text" document engine and a "Source" document engine
ClosedPublic
Actions

Authored by epriestley on Mar 23 2018, 2:41 PM.

Tags

None

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13105: Plans: Rich presentation and diff rendering pipelines for various file types

Commits

rPd2727d24da6e: Add an abstract "Text" document engine and a "Source" document engine

Summary

Ref T13105. Allow normal text files to be rendered as documents, and add a "source code" rendering engine.

Test Plan

Viewed some source code.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mar 23 2018, 2:41 PM

Harbormaster completed remote builds in B19914: Diff 46096.Mar 23 2018, 2:42 PM

epriestley requested review of this revision.Mar 23 2018, 2:42 PM

mydeveloperday accepted this revision.Mar 23 2018, 2:45 PM

This revision is now accepted and ready to land.Mar 23 2018, 2:45 PM

epriestley added a child revision: D19255: Add a JSON document rendering engine.Mar 23 2018, 3:02 PM

Closed by commit rPd2727d24da6e: Add an abstract "Text" document engine and a "Source" document engine (authored by epriestley). · Explain WhyMar 23 2018, 7:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			resources/celerity/map.php (10 lines)
M			src/__phutil_library_map__.php (4 lines)
A	M		src/applications/files/document/PhabricatorSourceDocumentEngine.php (30 lines)
A	M		src/applications/files/document/PhabricatorTextDocumentEngine.php (33 lines)
M			webroot/rsrc/css/layout/phabricator-source-code-view.css (20 lines)
M			webroot/rsrc/css/phui/phui-property-list-view.css (4 lines)

Diff 46098

resources/celerity/map.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/files/document/PhabricatorSourceDocumentEngine.php

Loading...

src/applications/files/document/PhabricatorTextDocumentEngine.php

Loading...

webroot/rsrc/css/layout/phabricator-source-code-view.css

Loading...

webroot/rsrc/css/phui/phui-property-list-view.css

Loading...