Page MenuHomePhabricator
Feed All Stories

Mar 21 2018

epriestley requested review of D19245: If a Workflow form receives a redirect response, don't re-enable the submit buttons.
Mar 21 2018, 6:47 PM
epriestley added a revision to T13108: Plans: 2018 Week 12 Bonus Content: D19245: If a Workflow form receives a redirect response, don't re-enable the submit buttons.
Mar 21 2018, 6:46 PM · Plans
epriestley updated the task description for T13108: Plans: 2018 Week 12 Bonus Content.
Mar 21 2018, 6:20 PM · Plans
epriestley requested review of D19244: Propagate "unexpandable" PHIDs to feed notification recipient expansion.
Mar 21 2018, 6:17 PM
epriestley added a revision to T13108: Plans: 2018 Week 12 Bonus Content: D19244: Propagate "unexpandable" PHIDs to feed notification recipient expansion.
Mar 21 2018, 6:15 PM · Plans
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.

See PHI431. See PHI426. ... I suspect these lead to T731 and T10574, practically.

Mar 21 2018, 4:05 PM · Plans, Differential
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.

See PHI483. There's currently a bad interaction between builds completing and drafts unpublishing, described in greater detail in T13108.

Mar 21 2018, 3:54 PM · Plans, Differential
epriestley updated the task description for T13108: Plans: 2018 Week 12 Bonus Content.
Mar 21 2018, 3:28 PM · Plans
epriestley triaged T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions as Normal priority.
Mar 21 2018, 3:27 PM · Plans, Differential
epriestley committed rP73b68bc2a619: Fix a possible `count(null)` in DifferentialRevisionActionTransaction (authored by tolbrino).
Fix a possible `count(null)` in DifferentialRevisionActionTransaction
Mar 21 2018, 2:39 PM
epriestley closed D19242: Fix a possible `count(null)` in DifferentialRevisionActionTransaction.
Mar 21 2018, 2:39 PM
epriestley accepted D19242: Fix a possible `count(null)` in DifferentialRevisionActionTransaction.

Thanks!

Mar 21 2018, 2:39 PM
tolbrino requested review of D19242: Fix a possible `count(null)` in DifferentialRevisionActionTransaction.
Mar 21 2018, 8:51 AM

Mar 20 2018

epriestley committed rP3bf8d5682ed0: Fix outdated link for Font Awesome icon set (authored by Krinkle).
Fix outdated link for Font Awesome icon set
Mar 20 2018, 10:51 PM
epriestley closed D19241: Fix outdated link for Font Awesome icon set.
Mar 20 2018, 10:51 PM
epriestley accepted D19241: Fix outdated link for Font Awesome icon set.
Mar 20 2018, 10:50 PM
Krinkle requested review of D19241: Fix outdated link for Font Awesome icon set.
Mar 20 2018, 10:38 PM
epriestley added a comment to T13108: Plans: 2018 Week 12 Bonus Content.

On complex build statuses, which has come up more than a handful of times but which I haven't aggregated well:

Mar 20 2018, 5:03 PM · Plans
epriestley added a comment to T11798: Allow harbormaster build logs to be downloaded via the API.

(Note that it will only work for more-recent logs, T13088 will have some guidance for older logs eventually.)

Mar 20 2018, 4:17 PM · Harbormaster
epriestley closed T11798: Allow harbormaster build logs to be downloaded via the API as Resolved.

I missed this task when collecting T13088, but this is supported after D19151.

Mar 20 2018, 4:17 PM · Harbormaster
epriestley added a comment to T13108: Plans: 2018 Week 12 Bonus Content.

This is sort of a race. Here's what happens:

Mar 20 2018, 4:09 PM · Plans
epriestley added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

I only play True Ethical SSF Hardcore so I have of never seen a Kaom's or worn a piece of gear with more than 4 links on it, and I'm definitely not very good at the game, but one thing that's been going better for me this league is that I've been doing builds with critical strike.

Mar 20 2018, 3:33 PM · Phacility
NDKilla awarded T13097: Plans: Path of Exile 3.2.0 (Bestiary League) a The World Burns token.
Mar 20 2018, 3:16 PM · Phacility
NDKilla added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

People here play path of exile? noice. I think I got to like, level 30 in beastiary, then started playing in standard again.

Mar 20 2018, 3:15 PM · Phacility
epriestley abandoned D19240: Revision with an intentional lint failure.
Mar 20 2018, 2:53 PM
epriestley added a comment to T13108: Plans: 2018 Week 12 Bonus Content.

D19240 exhibited the same behavior on a local lint failure so this is almost certainly a mundane bug rather than some sort of exotic race.

Mar 20 2018, 2:53 PM · Plans
epriestley requested review of D19240: Revision with an intentional lint failure.
Mar 20 2018, 2:52 PM
epriestley added a revision to T13108: Plans: 2018 Week 12 Bonus Content: D19240: Revision with an intentional lint failure.
Mar 20 2018, 2:50 PM · Plans
epriestley added a comment to T13108: Plans: 2018 Week 12 Bonus Content.

I had a local test failure there

Mar 20 2018, 2:47 PM · Plans
epriestley added a comment to T13108: Plans: 2018 Week 12 Bonus Content.

From reading the code, the behavior should already be (A): that is, we should already get this right in cases (3) and (4).

Mar 20 2018, 2:46 PM · Plans
epriestley added a comment to T13108: Plans: 2018 Week 12 Bonus Content.

See PHI483. Some of the mail rules around builds and drafts are kind of whack right now.

Mar 20 2018, 1:57 PM · Plans

Mar 19 2018

epriestley updated the task description for T13108: Plans: 2018 Week 12 Bonus Content.
Mar 19 2018, 10:27 PM · Plans
epriestley committed rP4aafce686202: Add filesize limits for document rendering engines and support partial/complete… (authored by epriestley).
Add filesize limits for document rendering engines and support partial/complete…
Mar 19 2018, 10:18 PM
epriestley closed D19239: Add filesize limits for document rendering engines and support partial/complete rendering.
Mar 19 2018, 10:18 PM
epriestley committed rPf646153f4dbe: Add an async driver for document rendering and a crude "Hexdump" document engine (authored by epriestley).
Add an async driver for document rendering and a crude "Hexdump" document engine
Mar 19 2018, 10:18 PM
epriestley closed D19238: Add an async driver for document rendering and a crude "Hexdump" document engine.
Mar 19 2018, 10:18 PM
epriestley committed rP01f22a8d06c9: Roughly modularize document rendering in Files (authored by epriestley).
Roughly modularize document rendering in Files
Mar 19 2018, 10:17 PM
epriestley closed D19237: Roughly modularize document rendering in Files.
Mar 19 2018, 10:17 PM
epriestley requested review of D19239: Add filesize limits for document rendering engines and support partial/complete rendering.
Mar 19 2018, 7:41 PM
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19239: Add filesize limits for document rendering engines and support partial/complete rendering.
Mar 19 2018, 7:40 PM · Plans, Files, Differential, Diffusion
epriestley requested review of D19238: Add an async driver for document rendering and a crude "Hexdump" document engine.
Mar 19 2018, 7:40 PM
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19238: Add an async driver for document rendering and a crude "Hexdump" document engine.
Mar 19 2018, 5:59 PM · Plans, Files, Differential, Diffusion
mydeveloperday awarded D19237: Roughly modularize document rendering in Files a Like token.
Mar 19 2018, 4:45 PM
epriestley requested review of D19237: Roughly modularize document rendering in Files.
Mar 19 2018, 4:43 PM
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19237: Roughly modularize document rendering in Files.
Mar 19 2018, 4:42 PM · Plans, Files, Differential, Diffusion
epriestley closed T12988: Remove flag "--master" from bin/remote as Resolved.

I removed this in rCORE36d2ef5dffe441ba1175e362bb73f0e43a9f70a2.

Mar 19 2018, 2:55 PM · Ops, Phacility
epriestley added a comment to T12993: Datasource queries with many "JOIN ... LIKE" can have explosive complexity.

See also T13102/PHI442. The MySQL setting optimizer_search_depth=0 may fix the weird explosive complexity here.

Mar 19 2018, 2:55 PM · Infrastructure, Typeahead, Search
epriestley updated the task description for T13098: Plans: Arcanist toolsets and extensions.
Mar 19 2018, 2:43 PM · Arcanist, Plans
epriestley added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

The Arc Hierophant is still alive, but he managed to get a Scaeva to drop shortly after the last update. I brought a Reave Juggernaut to 82 with it, although I've only made 1-2 tiers of progress in maps.

Mar 19 2018, 2:35 PM · Phacility
epriestley updated the task description for T13108: Plans: 2018 Week 12 Bonus Content.
Mar 19 2018, 2:08 PM · Plans
epriestley triaged T13109: Improve cluster write feedback and write routing as Normal priority.
Mar 19 2018, 2:07 PM · Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

Ideally, I think Diffusion, Files and Paste should all have the highlighting/encoding options and share more of the same code, with Diffusion being distinguished by having blame (and, I suppose, symbol linking) available.

Mar 19 2018, 1:48 PM · Plans, Files, Differential, Diffusion
avivey added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

I'm wondering how this should interact with T8407: Control diffusion's syntax highlighting.

Mar 19 2018, 1:11 PM · Plans, Files, Differential, Diffusion
avivey awarded T13105: Plans: Rich presentation and diff rendering pipelines for various file types a Love token.
Mar 19 2018, 1:04 PM · Plans, Files, Differential, Diffusion
DominicFrei added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.

Maaaybe Iam misinterpreting but if enabling sort by priority why not show in workboards something like [...]

Mar 19 2018, 11:41 AM · Restricted Project, Workboards (v3), Restricted Project
mydeveloperday added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

It would be great if there was an ability for installations to write custom viewers for formats that are either more obscure (MIF Framemaker format), or even in house formats (.myformat)

Mar 19 2018, 11:18 AM · Plans, Files, Differential, Diffusion

Mar 18 2018

epriestley committed rPc5e4bd8187c6: Fix some minor errors (DarkConsole warning, unstable Ferret sort) (authored by epriestley).
Fix some minor errors (DarkConsole warning, unstable Ferret sort)
Mar 18 2018, 10:12 PM
epriestley closed D19236: Fix some minor errors (DarkConsole warning, unstable Ferret sort).
Mar 18 2018, 10:12 PM
epriestley requested review of D19236: Fix some minor errors (DarkConsole warning, unstable Ferret sort).
Mar 18 2018, 10:03 PM
mydeveloperday added a comment to T12994: Add a setup warning if MYSQLI_ASYNC is not defined (support for MySQLi async).

I don't run my Phabricator instance on Ubuntu but instead on RHEL6 (and with PHP7, which I know isn't officially support)

Mar 18 2018, 12:19 PM · Database, Infrastructure
avivey added a project to T10611: No option to specify a Space when editing a Project's visibility policy: Projects.
Mar 18 2018, 10:20 AM · Projects, Restricted Project, Feature Request, Spaces

Mar 17 2018

tiguchi awarded T9821: Allow Harbormaster build plans to run on branch push instead of per-commit a Like token.
Mar 17 2018, 6:38 PM · Restricted Project, Harbormaster
sshannin added a comment to T13106: Task detail pages are issuing an egregious number of queries?.

For what it's worth, after spot-checking a few tasks on my install, all seem to query the same policy 10ish times in succession near the end of the load.

Mar 17 2018, 5:35 PM · Performance
epriestley added a comment to T13083: Plans: Portals and Facts.

The task.open-count.status counts open tasks that are the result of a status change (an existing task being closed, or a closed task being reopened). Since it's much more common for existing open tasks to be closed than for existing closed tasks to be reopened, the series should go negative pretty quickly and stay there over time, more or less ending up with a big negative number of "number of tasks ever closed".

Mar 17 2018, 5:16 PM · Plans, Facts, Dashboards
sshannin added a comment to T13083: Plans: Portals and Facts.

Not sure if it's expected in the current state, but here's one that doesn't seem well-formed: https://secure.phabricator.com/fact/chart/?y1=tasks.open-count.status

Mar 17 2018, 4:54 PM · Plans, Facts, Dashboards
bobek edited the content of Organizations Using Phabricator.
Mar 17 2018, 4:11 PM
csilvers added a comment to T12976: Use a server for pygments?.

If writing, deploying, and maintaining this server doensn't seem like much work to you (and it may reasonably not be), write this server yourself and replace the pygmentize binary on your system with a lightweight client written in a language with a fast startup time that just calls through to the server.

Mar 17 2018, 2:25 AM · Differential
ekubischta added a comment to T13070: Deprecate and remove `feed.http-hooks`.

aaaannnndddd..... I found it. D19050

Mar 17 2018, 1:32 AM · Feed
20after4 awarded T13103: Document favicon customization and validate the "ui.favicons" configuration option a Love token.
Mar 17 2018, 1:29 AM · Files, Aphront, Infrastructure
epriestley added a comment to T13070: Deprecate and remove `feed.http-hooks`.

What steps did you take to try to find the documentation?

Mar 17 2018, 1:11 AM · Feed
ekubischta added a comment to T13070: Deprecate and remove `feed.http-hooks`.

We currently use this extension at BisManOnline to integrate with our CRM system. Also, I believe that the Phabulous Slack Bot uses it as well https://github.com/etcinit/phabulous

Mar 17 2018, 1:09 AM · Feed
epriestley committed rP7e43b7405512: Give all commands from DiffusionCommandEngine a default 15 minute timeout (authored by epriestley).
Give all commands from DiffusionCommandEngine a default 15 minute timeout
Mar 17 2018, 12:22 AM
epriestley closed D19235: Give all commands from DiffusionCommandEngine a default 15 minute timeout.
Mar 17 2018, 12:22 AM
epriestley requested review of D19235: Give all commands from DiffusionCommandEngine a default 15 minute timeout.
Mar 17 2018, 12:16 AM
epriestley added a revision to T13108: Plans: 2018 Week 12 Bonus Content: D19235: Give all commands from DiffusionCommandEngine a default 15 minute timeout.
Mar 17 2018, 12:15 AM · Plans
epriestley added a comment to T13108: Plans: 2018 Week 12 Bonus Content.

See PHI364. An install encountered a held lock issue...

Mar 17 2018, 12:00 AM · Plans

Mar 16 2018

epriestley updated the task description for T13108: Plans: 2018 Week 12 Bonus Content.
Mar 16 2018, 11:42 PM · Plans
epriestley edited the content of Changelog.
Mar 16 2018, 11:37 PM
epriestley committed rPHU47cfa511ca67: (stable) Promote 2018 Week 11 (authored by epriestley).
(stable) Promote 2018 Week 11
Mar 16 2018, 11:37 PM
epriestley committed rPf03d6d6a2a85: (stable) Promote 2018 Week 11 (authored by epriestley).
(stable) Promote 2018 Week 11
Mar 16 2018, 11:37 PM
epriestley created 2018 Week 11 (Mid March).
Mar 16 2018, 11:37 PM
epriestley moved T13108: Plans: 2018 Week 12 Bonus Content from Backlog to Soon on the Plans board.
Mar 16 2018, 10:57 PM · Plans
epriestley moved T13105: Plans: Rich presentation and diff rendering pipelines for various file types from Backlog to Soon on the Plans board.
Mar 16 2018, 10:57 PM · Plans, Files, Differential, Diffusion
epriestley triaged T13108: Plans: 2018 Week 12 Bonus Content as Normal priority.
Mar 16 2018, 10:57 PM · Plans
epriestley closed T13102: Plans: 2018 Week 11 Bonus Content as Resolved.
Mar 16 2018, 10:56 PM · Plans
epriestley added a comment to T13102: Plans: 2018 Week 11 Bonus Content.

See PHI364. An install encountered a held lock issue in a cluster which resolved itself immediately when I appeared onsite.

Mar 16 2018, 10:56 PM · Plans
epriestley committed rP2fa904921e1a: Render object monograms and embedding references more gracefully when building… (authored by epriestley).
Render object monograms and embedding references more gracefully when building…
Mar 16 2018, 10:44 PM
epriestley closed T8845: Headings which resolve with markup become an `X` in Table of Contents on Wiki as Resolved by committing rP2fa904921e1a: Render object monograms and embedding references more gracefully when building….
Mar 16 2018, 10:44 PM · libphutil, Remarkup
epriestley closed D19234: Render object monograms and embedding references more gracefully when building a Remarkup table of contents.
Mar 16 2018, 10:44 PM
epriestley requested review of D19234: Render object monograms and embedding references more gracefully when building a Remarkup table of contents.
Mar 16 2018, 10:38 PM
epriestley added a revision to T8845: Headings which resolve with markup become an `X` in Table of Contents on Wiki: D19234: Render object monograms and embedding references more gracefully when building a Remarkup table of contents.
Mar 16 2018, 10:37 PM · libphutil, Remarkup
epriestley added a revision to T13102: Plans: 2018 Week 11 Bonus Content: D19234: Render object monograms and embedding references more gracefully when building a Remarkup table of contents.
Mar 16 2018, 10:37 PM · Plans
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Mar 16 2018, 10:33 PM · Plans, Harbormaster
epriestley updated the task description for T13102: Plans: 2018 Week 11 Bonus Content.
Mar 16 2018, 10:24 PM · Plans
epriestley committed rPdbc72a05bc39: Correct the behavior of "Desktop Only" in Notifications preferences (authored by epriestley).
Correct the behavior of "Desktop Only" in Notifications preferences
Mar 16 2018, 10:18 PM
epriestley closed D19233: Correct the behavior of "Desktop Only" in Notifications preferences.
Mar 16 2018, 10:17 PM
epriestley requested review of D19233: Correct the behavior of "Desktop Only" in Notifications preferences.
Mar 16 2018, 10:14 PM
epriestley added a revision to T13102: Plans: 2018 Week 11 Bonus Content: D19233: Correct the behavior of "Desktop Only" in Notifications preferences.
Mar 16 2018, 10:13 PM · Plans
jmeador added a comment to rP667955b8aeca: Clarify that a PHUITagView API argument is boolean, not a value in "millimeters".

This is a buff to API humor

Mar 16 2018, 8:31 PM
epriestley committed rPfa6cd200e878: Reduce the severity of policy fatals when building the Harbormaster "build… (authored by epriestley).
Reduce the severity of policy fatals when building the Harbormaster "build…
Mar 16 2018, 8:28 PM