Page MenuHomePhabricator

Generate a random unique "Request ID" for SSH requests so processes can coordinate better
ClosedPublic

Authored by epriestley on Mar 22 2018, 7:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:15 AM
Unknown Object (File)
Sun, Mar 31, 5:44 AM
Unknown Object (File)
Sun, Mar 31, 5:44 AM
Unknown Object (File)
Sun, Mar 31, 5:44 AM
Unknown Object (File)
Sun, Mar 31, 5:43 AM
Unknown Object (File)
Fri, Mar 29, 3:45 AM
Unknown Object (File)
Feb 14 2024, 12:02 AM
Unknown Object (File)
Jan 17 2024, 8:54 PM
Subscribers
None

Details

Summary

Depends on D19247. Ref T13109. When we receive an SSH request, generate a random unique ID for the request. Then thread it down through the process tree.

The immediate goal is to let the ssh-exec process coordinate with commit-hook process and log information about read and write lock wait times. Today, there's no way for ssh-exec to interact with the PushEvent, but this is the most helpful place to store this data for users.

Test Plan

Made pushes, saw the PushEvent table populate with a random request ID. Exported data and saw the ID preserved in the export.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 22 2018, 8:44 PM
This revision was automatically updated to reflect the committed changes.