Page MenuHomePhabricator

Provide more information to users during `git push` while waiting for write locks
ClosedPublic

Authored by epriestley on Mar 22 2018, 2:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 4, 9:59 PM
Unknown Object (File)
Feb 18 2024, 3:41 PM
Unknown Object (File)
Feb 12 2024, 2:00 AM
Unknown Object (File)
Feb 3 2024, 6:32 PM
Unknown Object (File)
Dec 21 2023, 11:42 PM
Unknown Object (File)
Nov 30 2023, 4:53 AM
Unknown Object (File)
Nov 25 2023, 7:02 PM
Unknown Object (File)
Nov 17 2023, 8:35 PM
Subscribers

Details

Summary

Ref T13109. Make it slightly more clear what the scope of the write and read locks are, and slightly more clear that we're actively acquiring locks, not just sitting around waiting.

While waiting on another writer, show who we're waiting on so you can walk over to their desk and glare at them.

Test Plan

Added sleep(15) after willWrite(). Pushed in two windows. Saw new, more informative messages. In the second window, saw the new guidance:

  1. Waiting for hector to finish writing (on device "repo1.local.phacility.net" for 11s)...

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asherkin added inline comments.
src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php
789

Missing return?

  • Add a missing return; for the case when the locking writer hasn't written their durable lock row yet.
This revision is now accepted and ready to land.Mar 22 2018, 8:15 PM
This revision was automatically updated to reflect the committed changes.