Paths

Table of Contentst

Differential D19247

Provide more information to users during `git push` while waiting for write locks
ClosedPublic
Actions

Authored by epriestley on Mar 22 2018, 2:11 AM.

Details

Reviewers

asherkin

Maniphest Tasks

T13109: Improve cluster write feedback and write routing

Commits

rP859b27497095: Provide more information to users during `git push` while waiting for write…

Summary

Ref T13109. Make it slightly more clear what the scope of the write and read locks are, and slightly more clear that we're actively acquiring locks, not just sitting around waiting.

While waiting on another writer, show who we're waiting on so you can walk over to their desk and glare at them.

Test Plan

Added sleep(15) after willWrite(). Pushed in two windows. Saw new, more informative messages. In the second window, saw the new guidance:

Waiting for hector to finish writing (on device "repo1.local.phacility.net" for 11s)...

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 22 2018, 2:11 AM

Harbormaster completed remote builds in B19898: Diff 46080.Mar 22 2018, 2:12 AM

epriestley requested review of this revision.Mar 22 2018, 2:12 AM

asherkin added a subscriber: asherkin.Mar 22 2018, 1:02 PM

asherkin added inline comments.

src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php
789	Missing `return`?

Thanks!

Add a missing return; for the case when the locking writer hasn't written their durable lock row yet.

Harbormaster completed remote builds in B19899: Diff 46081.Mar 22 2018, 5:35 PM

Harbormaster completed remote builds in B19899: Diff 46081.

epriestley added a child revision: D19249: Generate a random unique "Request ID" for SSH requests so processes can coordinate better.Mar 22 2018, 7:56 PM

asherkin accepted this revision.Mar 22 2018, 8:15 PM

This revision is now accepted and ready to land.Mar 22 2018, 8:15 PM

Closed by commit rP859b27497095: Provide more information to users during `git push` while waiting for write… (authored by epriestley). · Explain WhyMar 22 2018, 8:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

protocol/

DiffusionRepositoryClusterEngine.php

60 lines

repository/

storage/

PhabricatorRepositoryWorkingCopyVersion.php

32 lines

Diff 46086

View Options

src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php