Page MenuHomePhabricator
Feed All Stories

Apr 4 2017

epriestley added a revision to T12464: Move away from SHA1 in Files: Restricted Differential Revision.
Apr 4 2017, 10:54 PM · Files
epriestley added a revision to T12464: Move away from SHA1 in Files: Unknown Object (Differential Revision).
Apr 4 2017, 10:49 PM · Files
epriestley added a revision to T12464: Move away from SHA1 in Files: Unknown Object (Differential Revision).
Apr 4 2017, 10:38 PM · Files
epriestley updated the task description for T12464: Move away from SHA1 in Files.
Apr 4 2017, 10:34 PM · Files
kfsone added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

How about this:

Apr 4 2017, 10:32 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
chad awarded T12464: Move away from SHA1 in Files a Y So Serious token.
Apr 4 2017, 10:25 PM · Files
epriestley added a revision to T12464: Move away from SHA1 in Files: Unknown Object (Differential Revision).
Apr 4 2017, 10:24 PM · Files
gregprice added a project to T12505: Ownership rules whose owning package is a milestone fail to show as accepted: Restricted Project.
Apr 4 2017, 9:51 PM · Restricted Project, Projects, Owners, Bug Report
alexmv created T12505: Ownership rules whose owning package is a milestone fail to show as accepted.
Apr 4 2017, 9:44 PM · Restricted Project, Projects, Owners, Bug Report
epriestley added a revision to T12464: Move away from SHA1 in Files: Unknown Object (Differential Revision).
Apr 4 2017, 9:40 PM · Files
epriestley added a revision to T12464: Move away from SHA1 in Files: Unknown Object (Differential Revision).
Apr 4 2017, 9:32 PM · Files
chad added a comment to T12504: Files "Temporary" badge is white-on-grey.

1mon9v.jpg (400×600 px, 63 KB)

Apr 4 2017, 9:01 PM · Files, PHUI
epriestley added a revision to T11357: Move Files to EditEngine and modern APIs: Unknown Object (Differential Revision).
Apr 4 2017, 7:28 PM · Restricted Project, Files
epriestley moved T12504: Files "Temporary" badge is white-on-grey from Backlog to vNext on the Files board.
Apr 4 2017, 6:56 PM · Files, PHUI
epriestley created T12504: Files "Temporary" badge is white-on-grey.
Apr 4 2017, 6:56 PM · Files, PHUI
epriestley created T12503: Curtain sections may overflow boundaries in the UI.
Apr 4 2017, 6:52 PM · PHUI
dreadlord2203 added a comment to T8238: Formally support side-band change handoff in external repositories.

@avivey Implementation of T8092 is eagerly awaited, I am merely proposing a stop-gap solution of hiding the diff and base tags listed on the Diffusion UI for a repo when the same repo is being used as a staging area.
This would greatly reduce the UI clutter and allow teams to use tags as an effective version tracking solution.

Apr 4 2017, 6:04 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley closed T12502: Creating a task in the non-default space causes exception in feed renderer as Resolved by committing Restricted Diffusion Commit.
Apr 4 2017, 5:24 PM · Bug Report
20after4 added a revision to T12450: New Search Configuration Errata: Unknown Object (Differential Revision).
Apr 4 2017, 5:18 PM · Search
20after4 added a revision to T8285: Global advanced search only shows max. 100 results; pagination link ("Next") shown but empty: Unknown Object (Differential Revision).
Apr 4 2017, 5:15 PM · Search
epriestley added a revision to T8348: `arc download` doesn't support chunked downloads: Unknown Object (Differential Revision).
Apr 4 2017, 4:53 PM · Restricted Project, Files, Arcanist
20after4 added 1 mock(s) for T8646: Provide more context for search results, particularly wiki documents: M1474: Show snippets in search results....
Apr 4 2017, 4:40 PM · Design, Search, Restricted Project
20after4 added 1 task(s) for M1474: Show snippets in search results...: T8646: Provide more context for search results, particularly wiki documents.
Apr 4 2017, 4:40 PM · Search
20after4 created M1474: Show snippets in search results....
Apr 4 2017, 4:39 PM · Search
epriestley added a revision to T11357: Move Files to EditEngine and modern APIs: Unknown Object (Differential Revision).
Apr 4 2017, 4:10 PM · Restricted Project, Files
epriestley added a revision to T11357: Move Files to EditEngine and modern APIs: Unknown Object (Differential Revision).
Apr 4 2017, 3:50 PM · Restricted Project, Files
epriestley added a revision to T11357: Move Files to EditEngine and modern APIs: Unknown Object (Differential Revision).
Apr 4 2017, 3:04 PM · Restricted Project, Files
epriestley added a revision to T11357: Move Files to EditEngine and modern APIs: Unknown Object (Differential Revision).
Apr 4 2017, 2:47 PM · Restricted Project, Files
epriestley removed a project from T7954: Make it easier to upload XHProf profiles: Files.

(This isn't really very closely related to the Files application anymore, just cleaning up that board a little.)

Apr 4 2017, 1:01 PM · Infrastructure, XHProf
epriestley added a revision to T12502: Creating a task in the non-default space causes exception in feed renderer: Unknown Object (Differential Revision).
Apr 4 2017, 12:56 PM · Bug Report
lambdafu updated the task description for T12502: Creating a task in the non-default space causes exception in feed renderer.
Apr 4 2017, 10:21 AM · Bug Report
lambdafu updated the task description for T12502: Creating a task in the non-default space causes exception in feed renderer.
Apr 4 2017, 10:21 AM · Bug Report
lambdafu created T12502: Creating a task in the non-default space causes exception in feed renderer.
Apr 4 2017, 10:15 AM · Bug Report
jimmysastra awarded T10578: Provide 'Sort by Points' option in workboards a Like token.
Apr 4 2017, 2:17 AM · Workboards (v3), Feature Request
20after4 added a revision to T12500: Render highlighted search result body snippets in global search results views: Unknown Object (Differential Revision).
Apr 4 2017, 2:10 AM · Elasticsearch, Search, Feature Request
chad added Q605: Is it possible to sort by a custom field? I created a custom field called `Impact` that accepts integers. But can seemingly only sort by `Priority` in the Workboards. (Answer 538).
Apr 4 2017, 2:07 AM
jimmysastra updated Q605: Is it possible to sort by a custom field? I created a custom field called `Impact` that accepts integers. But can seemingly only sort by `Priority` in the Workboards. from Is it possible to sort by a custom field in Phabricator? I created a custom field called `Impact` that accepts integers. But can seemingly only sort by `Priority` in the Workboards. to Is it possible to sort by a custom field? I created a custom field called `Impact` that accepts integers. But can seemingly only sort by `Priority` in the Workboards..
Apr 4 2017, 1:34 AM
jimmysastra updated Q605: Is it possible to sort by a custom field? I created a custom field called `Impact` that accepts integers. But can seemingly only sort by `Priority` in the Workboards. from to Is it possible to sort by a custom field in Phabricator? I created a custom field called `Impact` that accepts integers. But can seemingly only sort by `Priority` in the Workboards..
Apr 4 2017, 1:34 AM
gregprice added a comment to T12501: `arc patch` blows up when the revision's parent has already landed.

I'm also slightly confused because, as someone just reminded me, the usual behavior of arc patch is to apply the patch to the appropriate base commit for the revision, not to try to do it on the current HEAD. In this context, that seems like it'd mean applying it directly to the arcpatch-A branch, rather than try to cherry-pick that commit up on top of where the user ran arc patch from.

Apr 4 2017, 1:15 AM · Arcanist, Restricted Project, Bug Report
gregprice added a comment to T12501: `arc patch` blows up when the revision's parent has already landed.

Also T6482 seems like it's fixed. I've been quite appreciating how Arcanist is increasingly aware of dependencies between revisions.

Apr 4 2017, 1:03 AM · Arcanist, Restricted Project, Bug Report
gregprice created T12501: `arc patch` blows up when the revision's parent has already landed.
Apr 4 2017, 1:01 AM · Arcanist, Restricted Project, Bug Report
epriestley closed T12481: Obtain a link to harbormaster build output from a commit or review. as Resolved.

Great! Let us know if you run into anything else.

Apr 4 2017, 12:52 AM · Feature Request
cos added a comment to T12481: Obtain a link to harbormaster build output from a commit or review..

thanks, this worked for me!

Apr 4 2017, 12:22 AM · Feature Request

Apr 3 2017

avivey added a comment to T8238: Formally support side-band change handoff in external repositories.

Yeah, the long-term plans are "automatic staging areas", which are essentially some kind of hidden refs (Probably using T8092 though, not just hiding stuff).

Apr 3 2017, 9:52 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
DanSheps added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

It was a little unclear in the walkthrough you gave on how to use it. Are the field types (animal.type plant.habitat) suppose to be hidden by default on when using a specific subtype (animal.type on plant subtype)?

Apr 3 2017, 9:34 PM · EditEngine, Maniphest, Custom Fields, Feature Request
ztas closed Q604: What happened to the menu counters? as resolved.
Apr 3 2017, 8:22 PM
ztas added Q604: What happened to the menu counters? (Answer 537).
Apr 3 2017, 8:22 PM
avivey updated the question details for Q604: What happened to the menu counters?.
Apr 3 2017, 7:48 PM
avivey added Q604: What happened to the menu counters? (Answer 536).
Apr 3 2017, 7:48 PM
• NeoAct awarded T12451: Finding your subscriptions / cards on Phacility is non-obvious a Like token.
Apr 3 2017, 7:26 PM · Phortune, Phacility
ztas updated Q604: What happened to the menu counters? from to What happened to the menu counters?.
Apr 3 2017, 7:14 PM
• Admins added a member for Localization: • Admins.
Apr 3 2017, 6:48 PM
20after4 created T12500: Render highlighted search result body snippets in global search results views.
Apr 3 2017, 5:41 PM · Elasticsearch, Search, Feature Request
epriestley added a comment to T12494: "Use Results..." button from Maniphest missing in the stable release.

Oh, of course. Good catch.

Apr 3 2017, 5:08 PM · Bug Report
chad closed T12494: "Use Results..." button from Maniphest missing in the stable release as Invalid.

This feature was promoted in the week 12 release, see notes: https://secure.phabricator.com/w/changelog/2017.12/. Please remember to always upgrade Phabricator before filing a bug report, this task would not have needed to have been filed if you followed our guidelines on Contributing Bug Reports, specifically https://secure.phabricator.com/book/phabcontrib/article/bug_reports/#common-fixes

Apr 3 2017, 5:07 PM · Bug Report
epriestley added a comment to T12496: "differential.sticky-accept" isn't working because of overbroad accept downgrading.

I cherry-picked this to stable and will plan to push it to the cluster tomorrow morning.

Apr 3 2017, 4:58 PM · Differential
epriestley closed T12496: "differential.sticky-accept" isn't working because of overbroad accept downgrading, a subtask of T10967: Move Differential reviewers back to a dedicated database storage table, as Resolved.
Apr 3 2017, 4:55 PM · Restricted Project, Infrastructure, Differential
epriestley closed T12496: "differential.sticky-accept" isn't working because of overbroad accept downgrading as Resolved by committing Restricted Diffusion Commit.
Apr 3 2017, 4:55 PM · Differential
epriestley moved T7501: Documentation for Files from vNext to Far Future on the Files board.
Apr 3 2017, 4:05 PM · Files, Documentation
aleb added a comment to T12498: Cannot get the details about the reviewers of a revision through Conduit.

We need to check programmatically whether all the reviewers approved. Any suggestion how this could be done?

Apr 3 2017, 4:02 PM · Feature Request
epriestley added a comment to T12497: Cannot set a mailing list user to watch a project.

This is also not a valid feature request.

Apr 3 2017, 3:59 PM · Mailing Lists, Bug Report
epriestley closed T12499: Official docker Image as Invalid.
Apr 3 2017, 3:58 PM · Feature Request
rat created T12499: Official docker Image.
Apr 3 2017, 3:55 PM · Feature Request
aleb added a comment to T12497: Cannot set a mailing list user to watch a project.

Could you reopen and set it as feature request?

Apr 3 2017, 3:55 PM · Mailing Lists, Bug Report
epriestley added a revision to T12496: "differential.sticky-accept" isn't working because of overbroad accept downgrading: Unknown Object (Differential Revision).
Apr 3 2017, 3:38 PM · Differential
epriestley removed a project from T10900: Repository content search with `hg grep` returns matches found in old versions of files: Search.

(This isn't related to the "Search" application, even though it's about searching for things.)

Apr 3 2017, 3:26 PM · Mercurial, Diffusion
epriestley closed T12497: Cannot set a mailing list user to watch a project as Invalid.

This does not describe a bug in Phabricator.

Apr 3 2017, 3:22 PM · Mailing Lists, Bug Report
epriestley closed T12498: Cannot get the details about the reviewers of a revision through Conduit as Invalid.
Apr 3 2017, 3:21 PM · Feature Request
20after4 added a comment to T7860: When users search for "#x y", treat "#x" as a project hashtag.

I implemented this recently but then pulled it out because ... project slug lookup is a gigantic mess right now.

Apr 3 2017, 3:16 PM · Search
aleb created T12498: Cannot get the details about the reviewers of a revision through Conduit.
Apr 3 2017, 3:11 PM · Feature Request
aleb created T12497: Cannot set a mailing list user to watch a project.
Apr 3 2017, 2:57 PM · Mailing Lists, Bug Report
20after4 added a comment to T8238: Formally support side-band change handoff in external repositories.

@dreadlord2203 indeed, hiding those tags would be useful. I found one problem with using a separate repository for change handoff, and that is access control. If you maintain several repositories with different access controls, then you would have to duplicate each of them and maintain a second set of access controls for the corresponding staging repositories. This is a lot of extra work and it would be easy to make a mistake and leak the staging repo to people who shouldn't be able to see it.

Apr 3 2017, 2:48 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
20after4 awarded T12493: Upgrading: Fulltext Search Services a Love token.
Apr 3 2017, 2:44 PM · Elasticsearch, Search, Guides
epriestley edited the content of Changelog.
Apr 3 2017, 11:22 AM
epriestley created 2017 Week 13 (Very Early April).
Apr 3 2017, 11:22 AM
epriestley added a comment to T12496: "differential.sticky-accept" isn't working because of overbroad accept downgrading.

I've gotten way behind this week so I'm going to cut and deploy the release now to try to catch up, then fix this afterwards and deploy it separately.

Apr 3 2017, 11:12 AM · Differential
epriestley added a subtask for T10967: Move Differential reviewers back to a dedicated database storage table: T12496: "differential.sticky-accept" isn't working because of overbroad accept downgrading.
Apr 3 2017, 11:10 AM · Restricted Project, Infrastructure, Differential
epriestley added a parent task for T12496: "differential.sticky-accept" isn't working because of overbroad accept downgrading: T10967: Move Differential reviewers back to a dedicated database storage table.
Apr 3 2017, 11:10 AM · Differential
epriestley created T12496: "differential.sticky-accept" isn't working because of overbroad accept downgrading.
Apr 3 2017, 11:10 AM · Differential
epriestley added a comment to T12494: "Use Results..." button from Maniphest missing in the stable release.

I can't reproduce this in production (8f7983a5be3a56db5b79dc7c3a0eb470f1d7ca02):

Apr 3 2017, 10:54 AM · Bug Report
agenticarus created T12495: Provide a conduit method to retrieve inline comments associated with a diff.
Apr 3 2017, 9:14 AM · Feature Request
Volans added a comment to T10215: Provide tools to combat and recover from abuse.

As a small step towards a more general solution I think it would be very helpful to allow the admins to easily revert changes, where revert means that there will be no traces left of the vandal action after the revert.

Apr 3 2017, 8:50 AM · Abuse
remusvrm updated the task description for T12494: "Use Results..." button from Maniphest missing in the stable release.
Apr 3 2017, 8:46 AM · Bug Report
remusvrm created T12494: "Use Results..." button from Maniphest missing in the stable release.
Apr 3 2017, 8:45 AM · Bug Report
remusvrm updated Q603: Is it possible to change the statuses of Pondor from UI? from to Is it possible to change the statuses of Pondor from UI?.
Apr 3 2017, 8:38 AM · Ponder
dreadlord2203 added a comment to T8238: Formally support side-band change handoff in external repositories.

@avivey I am exploring that solution as well, I was just wondering if hiding the diff and base tags is a doable solution wanted by the community by large.
We have multiple hosted repositories inter-dependent on each other, and our setup is still in its nascent stage. So I would prefer to not manage duplicate repositories until we finalize on our long term setup.

Apr 3 2017, 6:15 AM · Restricted Project, Restricted Project, Diffusion, Harbormaster
cos added a comment to T12481: Obtain a link to harbormaster build output from a commit or review..

thanks, I didn't think to use containerPHIDs, I'll give this a go this coming week and let you know if it works for me. Thanks!

Apr 3 2017, 3:01 AM · Feature Request
epriestley closed T12480: Be able to obtain the commits (related objects) associated with a task and the reviews associated with a commit as Resolved by committing Restricted Diffusion Commit.
Apr 3 2017, 2:50 AM · Feature Request
epriestley closed T12461: more consistency between results of maniphest.query and .search as Resolved by committing Restricted Diffusion Commit.
Apr 3 2017, 12:44 AM · Feature Request
epriestley added a comment to T12481: Obtain a link to harbormaster build output from a commit or review..

Not everything you need here has modern API methods, but I think you can get pretty close:

Apr 3 2017, 12:43 AM · Feature Request
epriestley added a comment to T12480: Be able to obtain the commits (related objects) associated with a task and the reviews associated with a commit.

D17604 adds the six edge types representing relationships between tasks, revisions, and commits to edge.search.

Apr 3 2017, 12:29 AM · Feature Request
epriestley added a revision to T12480: Be able to obtain the commits (related objects) associated with a task and the reviews associated with a commit: Unknown Object (Differential Revision).
Apr 3 2017, 12:28 AM · Feature Request
epriestley added a comment to T12461: more consistency between results of maniphest.query and .search.

D17603 makes maniphest.search return a "description" field, which looks like this:

Apr 3 2017, 12:17 AM · Feature Request
epriestley added a revision to T12461: more consistency between results of maniphest.query and .search: Unknown Object (Differential Revision).
Apr 3 2017, 12:14 AM · Feature Request

Apr 2 2017

Grimeh added a comment to T7789: Support Git Large File Storage.

Some feedback on this for if it's ever prioritised and picked up again, we've been using this internally for an Unreal Engine 4 based game project's binary assets for about 7 months now, we haven't run into any issues. Works great for us.

Apr 2 2017, 11:16 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T12450: New Search Configuration Errata.

If you can run bin/whatever, policies no longer matter since you can bin/storage shell or any other number of dangerous things.

Apr 2 2017, 9:56 PM · Search
20after4 added a comment to T12450: New Search Configuration Errata.

Maybe let bin/search commands target a specific service.

Apr 2 2017, 8:56 PM · Search
epriestley added a comment to T12450: New Search Configuration Errata.

PhabricatorEnv::beginScopedEnv(); works anywhere if this makes more sense as, like, bin/search self-test or something rather than a unit test.

Apr 2 2017, 8:52 PM · Search
20after4 added a comment to T12450: New Search Configuration Errata.

It would be nice to build a practical test suite instead, where we put specific documents into the index and then search for them.

Apr 2 2017, 8:49 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 8:08 PM · Search