Page MenuHomePhabricator
Create Task
Maniphest T7860

When users search for "#x y", treat "#x" as a project hashtag
Open, LowPublic
Actions

Description

Steps to reproduce: Search for "wikidata arrayobject".

Expected behavior: I expected T92487 to be found. The word "arrayobject" is in a comment and can be found, but "wikidata" is a project tag and is not in the fulltext search index. Yes, I'm aware of the project tag filter on the search page, but this is not accessible from the top-right search box. Also in my use-case I don't care much where the word "wikidata" is mentioned. It should be found wherever it is, not only in the project tags.

Proposal: Please add the project tags to the fulltext search index.

Original report: https://phabricator.wikimedia.org/T92630

Revisions and Commits

rPHU libphutil
D17669rPHU6fe33623cda6 Make the query compiler emit intermediate tokens
rP Phabricator
D17670rPcb49acc2ca71 Update Phabricator to use intermediate tokens from the query compiler

Related Objects
Search...

Event Timeline

qgil created this task.Apr 20 2015, 8:23 AM
qgil raised the priority of this task from to Needs Triage.
qgil updated the task description. (Show Details)
qgil added a project: Search.
qgil added a subscriber: qgil.
epriestley added a subscriber: epriestley.Apr 23 2015, 7:31 PM

I think it's reasonable for #x y to mean "documents matching query y in project #x", but I don't think x y should mean this on its own.

Technically speaking, it's also impractical to do a huge reindex rebuild every time someone renames a project: we potentially need to reindex millions of objects if project tags are part of the content corpus.

epriestley triaged this task as Low priority.EditedApr 23 2015, 10:43 PM

I have half a diff for this, but project slug lookup is a gigantic mess right now.

chad merged a task: T10790: search results should show maniphest tags.Apr 13 2016, 1:11 AM
chad added a subscriber: ofbeaton.
chad mentioned this in T10790: search results should show maniphest tags.Apr 13 2016, 1:14 AM
20after4 added a subscriber: 20after4.Apr 13 2016, 9:33 AM
michaeljs1990 added a subscriber: michaeljs1990.May 12 2016, 7:11 PM
Herald added a subscriber: eadler. · View Herald TranscriptMay 12 2016, 7:11 PM
epriestley mentioned this in D17509: Updated PhabricatorElasticFulltextStorageEngine for elasticsearch 5.Mar 20 2017, 1:52 PM
epriestley mentioned this in T10639: Implement a complex Gmail-style "to:<name>" query language.Mar 26 2017, 12:36 PM
epriestley moved this task from Backlog to v2 on the Search board.Mar 26 2017, 12:41 PM
20after4 added a comment.Apr 3 2017, 3:16 PM

I implemented this recently but then pulled it out because ... project slug lookup is a gigantic mess right now.

epriestley renamed this task from Project tags can not be found via the fulltext search index to When users search for "#x y", treat "#x" as a project hashtag.Apr 12 2017, 2:38 PM
epriestley added a revision: D17669: Make the query compiler emit intermediate tokens.Apr 12 2017, 10:43 PM
epriestley added a revision: D17670: Update Phabricator to use intermediate tokens from the query compiler.
epriestley added a commit: rPHU6fe33623cda6: Make the query compiler emit intermediate tokens.Apr 13 2017, 2:06 AM
epriestley added a commit: rPcb49acc2ca71: Update Phabricator to use intermediate tokens from the query compiler.
aklapper added a subscriber: aklapper.Jun 17 2017, 10:27 PM
Phabricator · Built by Phacility