Page MenuHomePhabricator
Create Task
Maniphest T8285

Global advanced search only shows max. 100 results; pagination link ("Next") shown but empty
Closed, ResolvedPublic
Actions

Description

(Upstreaming from https://phabricator.wikimedia.org/T92960 )

Steps

  1. The (Maniphest) query https://secure.phabricator.com/maniphest/query/QpntSZ73PDm0/#R lists 114 results.
  2. The very same (global) query https://secure.phabricator.com/search/query/_e.FBzJiXvZA/#R lists the first 100 results.
  3. Click "Next" at the bottom to get to https://secure.phabricator.com/search/query/_e.FBzJiXvZA/?offset=100

Actual results
That page incorrectly says "No results returned for that query." instead of displaying the remaining 14 tasks.

Expected results

  • I'd expect the second page to display the remaining results.
  • If that's a performance issue, I'd expect some info displayed that the results are limited to 100 and not complete. Plus no "Next" button should be shown.

Revisions and Commits

rP Phabricator
AbandonedD17615 Don't apply offset to elasticsearch query
D17667rP4bf968148cb8 Fix pagination of fulltext search results

Related Objects

Event Timeline

aklapper created this task.May 21 2015, 12:26 PM
aklapper raised the priority of this task from to Needs Triage.
aklapper updated the task description. (Show Details)
aklapper added a project: Search.
aklapper added a subscriber: aklapper.
Herald added a subscriber: qgil. · View Herald TranscriptMay 21 2015, 12:26 PM
fabe added a subscriber: fabe.May 21 2015, 12:51 PM

Didn't look at the code yet but it seems like the offset is somehow counted double (try playing with the offset parameter). Decreasing/Increasing it by one will add/remove two results each.
To get the remaining 14 tasks you can do a offset=50 (which will skip the first 100 tasks).

epriestley triaged this task as Normal priority.May 21 2015, 2:25 PM
epriestley added a subscriber: epriestley.

Yeah, this is a bug with the interaction between offsets and limits in the underlying fulltext search query (which finds documents matching the search terms) and policy-aware, cursor-based paging in the application-level query (which filters out documents you can't see). I wasn't able to find a clean fix in 5 minutes of poking at it.

andypuettmann added a subscriber: andypuettmann.Jul 3 2015, 10:48 AM
mario-seidel added a subscriber: mario-seidel.Jul 3 2015, 11:07 AM
epriestley merged a task: T9130: issue on phabricator website: second page of an advanced search is not accessible.Aug 11 2015, 12:21 PM
epriestley added a subscriber: infrance.
ofbeaton added a subscriber: ofbeaton.Jul 29 2016, 3:31 AM

Ran into this today on this install. Seatrched for open/close tasks with term "javascript".
https://secure.phabricator.com/search/query/qi_sDFEgnw9i/#R

says there is a page 2, page 2 is empty. Hopefully this 2nd example helps diagnose the problem.

Herald added a subscriber: eadler. · View Herald TranscriptJul 29 2016, 3:31 AM
ofbeaton awarded a token.Jul 29 2016, 3:31 AM
epriestley moved this task from Backlog to v2 on the Search board.Dec 8 2016, 6:49 PM
epriestley mentioned this in T12353: Convert PhabricatorSearchDocumentQuery to cursor based paging.Mar 5 2017, 12:18 PM
epriestley mentioned this in D17608: Add highlighting support to Elasticsearch fulltext engine.Apr 4 2017, 4:03 PM
20after4 added a revision: D17615: Don't apply offset to elasticsearch query.Apr 4 2017, 5:15 PM
epriestley added a revision: D17667: Fix pagination of fulltext search results.Apr 12 2017, 9:58 PM
epriestley added a comment.Apr 13 2017, 12:57 AM

I'm only like 85% sure that D17667 really fixes things so yell if it still looks ~weird~.

epriestley closed this task as Resolved by committing rP4bf968148cb8: Fix pagination of fulltext search results.Apr 13 2017, 12:57 AM
epriestley added a commit: rP4bf968148cb8: Fix pagination of fulltext search results.
Phabricator · Built by Phacility