Page MenuHomePhabricator

Provide a conduit method to retrieve inline comments associated with a diff
Closed, ResolvedPublic

Description

I want to write an IntelliJ plugin that surfaces "inlines" for the current diff in the editor view - "comments" would not need to be supported.

With the deprecation of differential.getrevisioncomments there does not seem to be a way to retrieve any comments/inlines for a diff, and even that method does not return file/line information for inlines.

I am not sure if "inlines" are part of a revision or part of a diff so I am not sure what the correct naming scheme would be.

Bonus possibilities:

  • it might be nice to be able to mark the inline comments as "done" from inside IntelliJ.
  • adding a new comment through differential.createinline already exists, could I use that to "reply" to a comment?

Event Timeline

Thanks epriestley!

Like I said in the other task, I'm happy to contribute to the development of this feature - although I'd be a new contributor :).

epriestley claimed this task.
epriestley added a subscriber: epriestley.

transaction.search now returns comments and inlines, including path, line, length, and reply information.