Page MenuHomePhabricator
Feed All Stories

Dec 5 2015

epriestley created 2015 Week 49 (Very Early December).
Dec 5 2015, 12:14 AM

Dec 4 2015

epriestley created T9905: Upgrading: ApplicationEditor changes in Maniphest.
Dec 4 2015, 11:59 PM · Maniphest, Installing & Upgrading
epriestley closed T9904: The Paste app doesn't work as Resolved.

Cool, let us know if you run into anything else.

Dec 4 2015, 11:47 PM · Paste
nickz added a comment to T9904: The Paste app doesn't work.

Yeah, I upgraded my dev instance to Head which doesn't have this issue. Thanks!

Dec 4 2015, 11:46 PM · Paste
epriestley added a comment to T9904: The Paste app doesn't work.

(At the least, I can't reproduce these issues at HEAD.)

Dec 4 2015, 11:43 PM · Paste
epriestley edited P1902 (An Untitled Masterwork).
Dec 4 2015, 11:43 PM
epriestley added a comment to T9904: The Paste app doesn't work.

You're a few days out of date -- I believe both of these issues are fixed at HEAD. Can you upgrade and let me know if you're still seeing issues?

Dec 4 2015, 11:43 PM · Paste
nickz updated the title for P1901 test1 from untitled to test1.
Dec 4 2015, 11:39 PM
nickz created T9904: The Paste app doesn't work.
Dec 4 2015, 11:38 PM · Paste
avivey added a comment to T9724: "ssh-exec" sometimes hangs when git cloning larger repos .

I can reproduce this on my dev install (Ubuntu 14.04.3 LTS, git 2.6, OpenSSH_6.6.1p1 Ubuntu-2ubuntu2.3, OpenSSL 1.0.1f 6 Jan 2014, PHP 5.5.9-1ubuntu4.14):

$ git clone --depth 5  ssh://git@localhost:7422/diffusion/MNG
Cloning into 'MNG'...
remote: Counting objects: 3560, done.
remote: Compressing objects: 100% (2960/2960), done.
Receiving objects:  99% (3525/3560), 153.83 MiB | 102.55 MiB/s
<hang>
Dec 4 2015, 11:38 PM · Git
cspeckmim added a comment to T9900: Figlet does not properly render apostrophes with some characters.

From a first glance it looks like the renderer may be the issue (tested the font in phabricator with figlet installed via homebrew):

figlet-test.png (740×1 px, 375 KB)

Dec 4 2015, 11:02 PM · Contributor Onboarding, Remarkup
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 11:01 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T4580: Auto saving forms doesn't save dynamic form visibility state: Unknown Object (Differential Revision).
Dec 4 2015, 11:01 PM · Maniphest
puls added a revision to T9903: Header buttons on dashboard panels are lost when panels are embedded in a tab panel: Unknown Object (Differential Revision).
Dec 4 2015, 10:43 PM · Dashboards
puls added a comment to T9903: Header buttons on dashboard panels are lost when panels are embedded in a tab panel.

Yes, exactly that.

Dec 4 2015, 10:22 PM · Dashboards
epriestley added a comment to T9903: Header buttons on dashboard panels are lost when panels are embedded in a tab panel.

Specifically, you're talking about this?

Dec 4 2015, 10:21 PM · Dashboards
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 10:19 PM · Restricted Project, ApplicationEditor, Transactions
puls created T9903: Header buttons on dashboard panels are lost when panels are embedded in a tab panel.
Dec 4 2015, 10:17 PM · Dashboards
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 10:13 PM · Restricted Project, ApplicationEditor, Transactions
chad updated the task description for T9897: Unbeta Feedback on Phame.
Dec 4 2015, 9:25 PM · Phame
• dnhoang1122 closed Q233: How to set phabricator to where fixes are assigned back to a user? as resolved.
Dec 4 2015, 9:14 PM
epriestley added a comment to T9901: Provide self-contained Arcanist executable.

will the patch be reviewed and merged

Dec 4 2015, 9:12 PM · Arcanist
develop7 added a comment to T9901: Provide self-contained Arcanist executable.

@epriestley I don't think T9901 belongs here, as I've wanted to have arcanist "packaged", not whole Phabricator. And I've worked with PHP before, of I'm quite aware of how complex packaging and installation could be. But I'm not sure that applies to arcanist. Anyway, T4200#57593 has been red, so let me add my 2¢ relevant to my proposed approach (which is, after more thinking it through, to build and distribute an single-file self-contained arc executable along with every Phabricator instance).

Dec 4 2015, 9:09 PM · Arcanist
chad added a revision to T9897: Unbeta Feedback on Phame: Unknown Object (Differential Revision).
Dec 4 2015, 9:07 PM · Phame
chad added Q233: How to set phabricator to where fixes are assigned back to a user? (Answer 271).
Dec 4 2015, 8:36 PM
jboning added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

I think we're going to work around this by changing our base config value to git:upstream, git:merge-base(origin/master) and decreeing that if you want to do this sort of dependent feature thing, you have to explicitly set child-feature's upstream to feature. arc feature does that automatically, so we might just encourage people to start using that.

Dec 4 2015, 8:29 PM · Restricted Project, Restricted Project, Arcanist
• dnhoang1122 added a comment to Q233: How to set phabricator to where fixes are assigned back to a user?.

sorry all our work are going through maniphest.

Dec 4 2015, 8:24 PM
chad added a comment to Q233: How to set phabricator to where fixes are assigned back to a user?.

Are you referring to Maniphest, Differential, or Audit? What is your workflow now? This question is fairly vague.

Dec 4 2015, 8:16 PM
epriestley added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

That's the workflow I use, but I --amend "feature" when updating it.

Dec 4 2015, 8:14 PM · Restricted Project, Restricted Project, Arcanist
• dnhoang1122 updated Q233: How to set phabricator to where fixes are assigned back to a user? from to How to set phabricator to where fixes are assigned back to a user?.
Dec 4 2015, 8:08 PM
jboning added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

pretty big rough edges for the workflows it intends to enable

What are these, specifically? Is this entire task moot?

Dec 4 2015, 8:05 PM · Restricted Project, Restricted Project, Arcanist
epriestley closed T6226: Conduit-created task always results in [Reopened] tag in the email subject as Resolved.

Task creation slightly ahead of HEAD through maniphest.edit now hit essentially the exact same code as the web UI, and no longer appear to do this "[Reopened]" stuff.

Dec 4 2015, 8:04 PM · Restricted Project, Maniphest, Conduit
epriestley renamed T7303: Provide OAuth access to Conduit from Provide a way to create/edit tasks through the OAuth API to Provide OAuth access to Conduit.
Dec 4 2015, 7:58 PM · Restricted Project, Conduit, Restricted Project
epriestley closed T8289: project parameter for task creation should accept hashtags and project IDs (numbers) not just canonical names as Resolved.

This hasn't hit HEAD yet, but will be resolved indirectly as part of changes in connection with T9132 shortly as that rolls out.

Dec 4 2015, 7:57 PM · Wikimedia, Maniphest
epriestley closed T8289: project parameter for task creation should accept hashtags and project IDs (numbers) not just canonical names, a subtask of T4777: Allow passing a "project(s)" URL parameter to "Create Task" form, as Resolved.
Dec 4 2015, 7:57 PM · Maniphest
epriestley created T9902: Phacility invite flow incorrectly associates "x@y.com" with user who previously accepted that invite, even if they have removed the address.
Dec 4 2015, 7:52 PM · Phacility
epriestley closed T6408: Allow users (or at least admins) to share saved queries as Resolved.

See T4103 (or create a wiki page or dashboard).

Dec 4 2015, 7:37 PM · Maniphest
epriestley closed T6288: Projects - when creating project from Maniphest, icon doesn't show as Wontfix.

I'm removing this "Create Project" workflow entirely in connection with T9132, obsoleting this task.

Dec 4 2015, 7:36 PM · Projects, Maniphest
epriestley moved T6226: Conduit-created task always results in [Reopened] tag in the email subject from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:33 PM · Restricted Project, Maniphest, Conduit
epriestley moved T6205: Replace "Associate Projects" action in task editing form with "Edit Projects" from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:33 PM · Projects, Transactions, Maniphest
epriestley updated subscribers of T6205: Replace "Associate Projects" action in task editing form with "Edit Projects".

This is now fairly easy to implement and the race stuff isn't a problem anymore, but I'm not sure it's worthwhile from a product perspective. We could pursue these things fairly easily now:

Dec 4 2015, 7:33 PM · Projects, Transactions, Maniphest
epriestley moved T5158: Maniphest custom field refuses to use non-empty default value from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:19 PM · Maniphest, Custom Fields, Transactions
epriestley added a comment to T9901: Provide self-contained Arcanist executable.

See T4200.

Dec 4 2015, 7:18 PM · Arcanist
epriestley closed T9901: Provide self-contained Arcanist executable as Wontfix.
Dec 4 2015, 7:17 PM · Arcanist
epriestley closed T4699: Improve email interaction with Maniphest as Resolved.

I think this is mostly either resolved or obsoleted by "Email Commands" (Help → Email Commands in Maniphest). We also backed away from hashtags implying project associations, and that seems like it was a good call.

Dec 4 2015, 7:17 PM · Mail, Maniphest
epriestley closed T4623: Allow system agents to create tasks they can't edit afterwards as Wontfix.

We haven't seen other use cases for this. OAuth or Nuance are more likely approaches from an upstream viewpoint.

Dec 4 2015, 7:14 PM · Conduit, Maniphest
epriestley moved T4580: Auto saving forms doesn't save dynamic form visibility state from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:13 PM · Maniphest
epriestley moved T4316: Allow a comment to be added on the Maniphest edit interface from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:13 PM · Maniphest
epriestley moved T5622: "copy" attribute for custom fields is not working, at least for text fields from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:13 PM · Maniphest, Custom Fields
epriestley moved T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:12 PM · Maniphest
epriestley moved T7303: Provide OAuth access to Conduit from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:11 PM · Restricted Project, Conduit, Restricted Project
epriestley moved T7250: Actions in wrong order after merging duplicates + reopening from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:11 PM · Maniphest
epriestley moved T7661: Object creation is often accompanied by transaction records which aren't of much use from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:10 PM · Transactions, Maniphest
develop7 renamed T9901: Provide self-contained Arcanist executable from Generate self-contained Arcanist executable to Provide self-contained Arcanist executable.
Dec 4 2015, 7:09 PM · Arcanist
epriestley moved T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:09 PM · Maniphest, Herald
epriestley moved T8055: "copy":true does not work in Maniphest custom field configuration from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:09 PM · Maniphest
develop7 created T9901: Provide self-contained Arcanist executable.
Dec 4 2015, 7:09 PM · Arcanist
epriestley moved T8289: project parameter for task creation should accept hashtags and project IDs (numbers) not just canonical names from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:08 PM · Wikimedia, Maniphest
epriestley moved T8903: Removing projects by editing a task in-place from a query result list doesn't refresh properly from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:07 PM · Maniphest
epriestley moved T9238: Field-level policy controls are not made clear in the UI from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:06 PM · Maniphest
epriestley moved T9496: Allow Maniphest custom statuses (and priorities) to be disabled from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:06 PM · Maniphest
epriestley moved T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:06 PM · Modernization, Maniphest
epriestley moved T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed from Backlog to vNext on the Maniphest board.
Dec 4 2015, 7:06 PM · Maniphest, Installing & Upgrading
epriestley edited projects for T9652: Request for test case management application, added: Unnamed Manual Test Case Application; removed Roadmap, Maniphest.
Dec 4 2015, 7:06 PM · Restricted Project, Unnamed Manual Test Case Application
epriestley created Unnamed Manual Test Case Application.
Dec 4 2015, 7:06 PM
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 6:59 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 6:17 PM · Restricted Project, ApplicationEditor, Transactions
epriestley placed T9889: Object selector dialog does not work in Elasticsearch 2.0 up for grabs.
Dec 4 2015, 4:50 PM · Elasticsearch
• joebloggs87 assigned T9889: Object selector dialog does not work in Elasticsearch 2.0 to joe.
Dec 4 2015, 4:50 PM · Elasticsearch
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 3:59 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 3:34 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 3:13 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 3:00 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a comment to T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.

Actually, you probably also don't really care about removing the comment event anyway, since it can't change policies and you can't comment on objects when creating them, and I think your listener doesn't actually end up doing anything special for the actions that are available? So this might be mostly moot anyway, but in an ideal world I'll get through the main "edit" event shortly too.

Dec 4 2015, 2:56 PM · Maniphest, Installing & Upgrading
epriestley added a comment to T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.

Quick update here: ApplicationEditor/EditEngine have caught up with this, so the current plan is to indirectly remove this event in at least some cases (currently: changes made from the "Comments" area) after the stable cut on Saturday. You can upgrade to this week's stable safely but we should make sure things are in a good place before you move beyond that.

Dec 4 2015, 2:54 PM · Maniphest, Installing & Upgrading
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 2:43 PM · Restricted Project, ApplicationEditor, Transactions
epriestley renamed T9898: `git branch --contains X` has cost in the realm of O(commits * branches) from git:branch-unique() is absurdly slow to `git branch --contains X` has cost in the realm of O(commits * branches).
Dec 4 2015, 2:03 PM · Restricted Project, Restricted Project, Arcanist
sandip_karande added a comment to Q231: Group commits on random hashtags specified in SVN commit message (Answer 269).

Thank you Chad for your reply.

Dec 4 2015, 2:03 PM
epriestley added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

pretty big rough edges for the workflows it intends to enable

Dec 4 2015, 1:48 PM · Restricted Project, Restricted Project, Arcanist
epriestley triaged T9899: Chatbot requires access to the database as Wishlist priority.

I think there are two issues here:

Dec 4 2015, 1:16 PM · Phabot
epriestley renamed T9900: Figlet does not properly render apostrophes with some characters from Figlet does not properly render apostrophe's with some characters to Figlet doe's not properly render apostrophe's with some character's.
Dec 4 2015, 1:03 PM · Contributor Onboarding, Remarkup
• VitaminCpp added a comment to T9724: "ssh-exec" sometimes hangs when git cloning larger repos .

Again I attached strace to narrow down the problem further.

Dec 4 2015, 1:02 PM · Git
epriestley triaged T9900: Figlet does not properly render apostrophes with some characters as Wishlist priority.
Dec 4 2015, 12:37 PM · Contributor Onboarding, Remarkup
epriestley added a comment to T9900: Figlet does not properly render apostrophes with some characters.

I think this is a problem only with the default font, it seems OK in other fonts:

Dec 4 2015, 12:36 PM · Contributor Onboarding, Remarkup
epriestley added a comment to T4209: Multiserver / High-Availability Configuration.

I think the first SSH connection is still more expensive than several HTTP connections, and we can't easily just pool all traffic from a host over a single connection because a host may run multiple instances of Phabricator -- and we already built all the HTTP stuff anyway.

Dec 4 2015, 12:20 PM · Restricted Project, Phacility
• Basheer closed T9894: Object selector dialog does not work in Elasticsearch 1.7.2 as Resolved.
Dec 4 2015, 11:37 AM · Elasticsearch
• Basheer added a comment to T9894: Object selector dialog does not work in Elasticsearch 1.7.2.

A quick update here, as per our analysis we came to know that the current issue was arised due to the elastic search related issue and we have fixed it. Now everything is working fine. :-)

Dec 4 2015, 11:36 AM · Elasticsearch
• Basheer added a comment to T9894: Object selector dialog does not work in Elasticsearch 1.7.2.

Upgraded the phabricator search to elastic search using the following command.

Dec 4 2015, 11:04 AM · Elasticsearch
cspeckmim created T9900: Figlet does not properly render apostrophes with some characters.
Dec 4 2015, 10:09 AM · Contributor Onboarding, Remarkup
Arcank added a comment to T9873: arc alias outputs a confusing message when adding a shell command alias.

Thank you!

Dec 4 2015, 9:41 AM · Arcanist
johnny-bit added a comment to T9360: Unbeta Phame.
In T9360#146722, @chad wrote:

DocumentPro is way better than Oblivious

Dec 4 2015, 9:35 AM · Phame
20after4 added a comment to T4209: Multiserver / High-Availability Configuration.

Specifically, performance from the Diffusion browse views.

Dec 4 2015, 9:05 AM · Restricted Project, Phacility
jgelens edited the content of Organizations Using Phabricator.
Dec 4 2015, 9:02 AM
chad added a comment to T9894: Object selector dialog does not work in Elasticsearch 1.7.2.

Unfortunately, given the lack of reproducible instructions and no other reports, there isn't anything currently for the upstream to do on this ticket except to ask whoever is having it, to provide us with more details. If we can't reproduce something, there isn't really much more we can do. The onus is on you to help with that effort.

Dec 4 2015, 7:41 AM · Elasticsearch
chad added a comment to T9894: Object selector dialog does not work in Elasticsearch 1.7.2.

Upgraded the phabricator search features to elasticsearch.

Dec 4 2015, 7:38 AM · Elasticsearch
• Basheer added a comment to T9894: Object selector dialog does not work in Elasticsearch 1.7.2.

I have updated the phabricator tio recent version on Dec 2.

Dec 4 2015, 6:35 AM · Elasticsearch
michel-slm added a revision to T7293: Add support for ansible-lint: Unknown Object (Differential Revision).
Dec 4 2015, 4:33 AM · Arcanist, Lint
chad edited projects for T9899: Chatbot requires access to the database, added: Phabot; removed Chatlog.
Dec 4 2015, 2:34 AM · Phabot
epriestley closed T9873: arc alias outputs a confusing message when adding a shell command alias as Resolved by committing Restricted Diffusion Commit.
Dec 4 2015, 2:31 AM · Arcanist
dgoldstein added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).
$ time git branch --contains 1eb050dff95372999c17b06d6c4caa63ce3f1659
* langpack_as_js_module
Dec 4 2015, 2:28 AM · Restricted Project, Restricted Project, Arcanist