Page MenuHomePhabricator
Create Task
Maniphest T9496

Allow Maniphest custom statuses (and priorities) to be disabled
Closed, ResolvedPublic
Actions

Description

We had a custom status named "Blocked" which was a custom open status for Maniphest. I personally disagreed with the existence of this status and we only had a relatively small of tasks using it. As such, I decided the remove the custom status, restoring maniphest.statuses to the default value. One unintended side effect, however, was that all tasks which were previously in the "blocked" status became closed.

blocked.png (1×1 px, 196 KB)

As a quick fix I just ran UPDATE phabricator_maniphest.maniphest_task SET status = 'open' WHERE status = 'blocked', but maybe there should be a cleaner way?

blocked2.png (1×1 px, 153 KB)

Revisions and Commits

rP Phabricator
D14681rP92175488e954 Allow Maniphest statuses and priorities to be disabled

Event Timeline

joshuaspence created this task.Oct 1 2015, 9:55 PM
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Maniphest.
joshuaspence added a subscriber: joshuaspence.
epriestley added a subscriber: epriestley.Oct 1 2015, 10:14 PM

I think that's basically the best we can hope for? Slightly cleaner is to use the batch editor before you remove the status to leave an audit trail and a comment like "We're getting rid of the blocked status so I'm moving this to Open, see Txxx for discussion." Or what were you thinking?

joshuaspence added a comment.Oct 1 2015, 10:21 PM

Maybe the removed status should be stored in the database somewhere? That way, we can show @josh changed the status to "Blocked" and with some sort of strikethrough text or something?

I think my main issue was that it wasn't obvious what would happen when I did this, so at the very least we should warn about it.

epriestley added a comment.Oct 1 2015, 10:22 PM

I suppose we could let you disable statuses so new tasks can't be put into those states, while still retaining history for them.

joshuaspence added a comment.Oct 1 2015, 10:23 PM

Another option would be to hide transactions which would result in an "Unknown Object" being rendered, which is maybe too magical but it minimises clutter in the UI (I really dislike seeing "Unknown Object" in the UI).

joshuaspence added a comment.Oct 1 2015, 10:23 PM
In T9496#138811, @epriestley wrote:

I suppose we could let you disable statuses so new tasks can't be put into those states, while still retaining history for them.

+1

cburroughs added a subscriber: cburroughs.Oct 2 2015, 12:21 PM
epriestley renamed this task from Removing a custom status has unexpected side effects to Allow Maniphest custom statuses (and priorities) to be disabled.Oct 18 2015, 2:45 PM
epriestley moved this task from Backlog to vNext on the Maniphest board.Dec 4 2015, 7:06 PM
epriestley claimed this task.Dec 5 2015, 6:41 PM
epriestley triaged this task as Normal priority.
epriestley added a revision: D14681: Allow Maniphest statuses and priorities to be disabled.Dec 5 2015, 6:44 PM
epriestley closed this task as Resolved by committing rP92175488e954: Allow Maniphest statuses and priorities to be disabled.Dec 5 2015, 7:01 PM
epriestley added a commit: rP92175488e954: Allow Maniphest statuses and priorities to be disabled.
Phabricator · Built by Phacility