Page MenuHomePhabricator

Auto saving forms doesn't save dynamic form visibility state
Closed, ResolvedPublic

Description

Steps to reproduce:

  1. Open a comment form for a task.
  2. Change the "Action" from "Comment" to "Add CCs". The form element to add a list of CCs should appear.
  3. Reload the page.

What I should see:

  1. The old comment text.
  2. The "Action" selector changed to "Add CCs"
  3. The form element for list of CCs

What I see instead:

  1. The old comment text.
  2. The "Action" selector changed to "Add CCs"

And there isn't any form element for list of CC's, or atleast it isn't visible.

Event Timeline

skyronic raised the priority of this task from to Needs Triage.
skyronic updated the task description. (Show Details)
skyronic added subscribers: skyronic, chad.
epriestley triaged this task as Normal priority.Mar 10 2014, 2:24 AM
epriestley added a subscriber: epriestley.

We marshall the entire form in Differential but do so in a hard-coded way. In Maniphest, we marshall only the comment text. The assumption is that the comment is like 1000x more work than fiddling with the "Action" dropdown, but we should generalize this code and marshall the entire form in all cases.