Page MenuHomePhabricator

nickz (Nick Zheng)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jul 23 2014, 10:45 PM (276 w, 6 d)
Availability
Available

Recent Activity

Oct 17 2018

nickz added a comment to T13109: Improve cluster write feedback and write routing.

@epriestley : our current phabricator version is c46be2a70b4db72d61e76690ef095384de2c3f91 that was landed on 04/13, will there be any issues if we directly cherry pick the recent two versions without pulling any other changes?
rP51073b972ece: Try to route cluster writes to nodes which won't need to synchronize first.Wed, Oct 17, 3:08 PM
rPbc6c8c0e93a7: Explicitly shuffle nodes before selecting one for cluster sync.

Oct 17 2018, 7:37 PM · Diffusion

Apr 6 2017

nickz created P2035 Error when upgrading Phabricator to the latest stable version.
Apr 6 2017, 7:48 PM

Mar 15 2016

nickz added a comment to T9069: arc patch can't handle binary file correctly.

Yeah, we still run into the same problem from time to time:
error: the patch applies to 'hadoop-scala/lib/driven-plugin-1.3.6-hosted-ga-11.jar' (49f50831fe1109b164f56c8e823132aa5f5171c9), which does not match the current contents.

Mar 15 2016, 9:10 PM · Customer Impact, Differential, Restricted Project, Arcanist

Feb 26 2016

nickz committed rP6861af0cbb0b: When the push phase of "Land Revision" fails, show the error in the UI (authored by nickz).
When the push phase of "Land Revision" fails, show the error in the UI
Feb 26 2016, 5:38 PM
nickz closed D15350: When the push phase of "Land Revision" fails, show the error in the UI by committing rP6861af0cbb0b: When the push phase of "Land Revision" fails, show the error in the UI.
Feb 26 2016, 5:38 PM
epriestley awarded D15350: When the push phase of "Land Revision" fails, show the error in the UI a Like token.
Feb 26 2016, 2:20 PM
nickz updated the diff for D15350: When the push phase of "Land Revision" fails, show the error in the UI.
  • remove the change made by accident
Feb 26 2016, 5:38 AM
nickz retitled D15350: When the push phase of "Land Revision" fails, show the error in the UI from to When the push phase of "Land Revision" fails, show the error in the UI.
Feb 26 2016, 5:36 AM

Feb 25 2016

nickz added a comment to T10447: When the push phase of "Land Revision" fails, show the error in the UI.

When I put var_dump() in other parts of the code, I can see the output from /var/log/apache/error.log, but just can't see any output for the ones I mentioned above.

Feb 25 2016, 3:26 PM · Drydock (v3)

Feb 24 2016

nickz added a comment to T10447: When the push phase of "Land Revision" fails, show the error in the UI.

It looks like "git push" in DrydockLandRepositoryOperation.php doesn't get executed.
I put some var_dump as the following, and click "Land Revision", but no related log printed out.

Feb 24 2016, 11:51 PM · Drydock (v3)

Jan 13 2016

nickz added a comment to T10092: User reports Drydock not parallelizing working copy builds.

Okay, I am able to expand further by adding more requests. Thanks for the explaining!

Jan 13 2016, 11:00 PM · Drydock

Jan 6 2016

nickz added a comment to T9994: Merge conflicts causes resources not being able to be released.

This looks much better! Thanks!

Jan 6 2016, 12:34 AM · Drydock, Differential, Bug Report

Dec 24 2015

nickz added a comment to T9994: Merge conflicts causes resources not being able to be released.

This works for me now! Thanks!

Dec 24 2015, 12:58 AM · Drydock, Differential, Bug Report

Dec 19 2015

nickz added a comment to rP8eec9e2c0ef2: Provide a more straightforward way to revoke SSH keys by finding and….

Thank you!

Dec 19 2015, 8:00 PM
nickz added a comment to D14823: Provide a more straightforward way to revoke SSH keys by finding and destroying the objects.

Thanks! I added you to Blessed Committers, so you should be able to land this yourself.
(The project page also has some instructions on how to get access configured, now.)

Dec 19 2015, 7:53 PM
nickz committed rP8eec9e2c0ef2: Provide a more straightforward way to revoke SSH keys by finding and… (authored by nickz).
Provide a more straightforward way to revoke SSH keys by finding and…
Dec 19 2015, 7:52 PM
nickz closed D14823: Provide a more straightforward way to revoke SSH keys by finding and destroying the objects by committing rP8eec9e2c0ef2: Provide a more straightforward way to revoke SSH keys by finding and….
Dec 19 2015, 7:52 PM
nickz updated the diff for D14823: Provide a more straightforward way to revoke SSH keys by finding and destroying the objects.

Updated based on Evan's comments.

Dec 19 2015, 5:44 PM
epriestley awarded D14823: Provide a more straightforward way to revoke SSH keys by finding and destroying the objects a Piece of Eight token.
Dec 19 2015, 11:37 AM
nickz updated the test plan for D14823: Provide a more straightforward way to revoke SSH keys by finding and destroying the objects.
Dec 19 2015, 7:20 AM
nickz retitled D14823: Provide a more straightforward way to revoke SSH keys by finding and destroying the objects from to Provide a more straightforward way to revoke SSH keys by finding and destroying the objects.
Dec 19 2015, 7:20 AM
nickz added a revision to T9967: Provide a more straightforward way to revoke SSH keys by finding and destroying the objects: D14823: Provide a more straightforward way to revoke SSH keys by finding and destroying the objects.
Dec 19 2015, 7:20 AM · Auth, Feature Request

Dec 18 2015

nickz added a comment to T9994: Merge conflicts causes resources not being able to be released.

Thanks @epriestley! I'll try it out.

Dec 18 2015, 8:45 PM · Drydock, Differential, Bug Report

Dec 15 2015

nickz updated subscribers of T9994: Merge conflicts causes resources not being able to be released.
Dec 15 2015, 9:20 PM · Drydock, Differential, Bug Report
nickz added a comment to T9994: Merge conflicts causes resources not being able to be released.

It looks like it counts the total working copies. I thought the limit is for every single repo: when I set the the limit to be 5, I expect that every single repo can have 5 copies at most. This is not scalable: when more and more repos get created, we have to adjust the limit.

Dec 15 2015, 7:56 PM · Drydock, Differential, Bug Report
nickz added a comment to T9994: Merge conflicts causes resources not being able to be released.

Also why can't a new lease get another resource when previous lease holds a resource? I set the limit of the working copy to be 5, so there should be enough resources available to be used.

Dec 15 2015, 7:35 PM · Drydock, Differential, Bug Report
nickz created T9994: Merge conflicts causes resources not being able to be released.
Dec 15 2015, 7:12 PM · Drydock, Differential, Bug Report

Dec 14 2015

nickz added a comment to T9952: Let "Land Revision" target branches other than master.

Thanks for taking care of this!

Dec 14 2015, 10:31 PM · Differential
nickz added a comment to T9952: Let "Land Revision" target branches other than master.

I tested this feature and noticed that the browse button beside "Onto Branch" was not clickable unless I removed the pre-populated default branch.

Dec 14 2015, 10:22 PM · Differential
nickz added a comment to T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles).

Thanks for thinking through all of these! Let me know if there is anything I can help with.

Dec 14 2015, 5:29 PM · Owners, Files, ApplicationSearch
nickz added a comment to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

Ok, got it. Do you think it's reasonable to search using a package name?

Dec 14 2015, 6:21 AM · Maniphest, Phame, Owners, Arcanist, Conduit
nickz added a comment to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

You are right for the cases you described. But the case I mentinoed is that /src/infrastructure/PhabricatorEditor.php doesn't exist in both Arcanist and libutil.

Dec 14 2015, 12:18 AM · Maniphest, Phame, Owners, Arcanist, Conduit
nickz added a comment to T9967: Provide a more straightforward way to revoke SSH keys by finding and destroying the objects.

Thanks for the workaround!

Dec 14 2015, 12:09 AM · Auth, Feature Request
nickz added a comment to T9967: Provide a more straightforward way to revoke SSH keys by finding and destroying the objects.

Do you have the public key (or the private key), or do you just know which user has a compromised key but not know which key is compromised?
That is, which of these commands would you be able to run if they were available?

./bin/auth revoke-public-key /path/to/compromised_public_key.pub
./bin/auth revoke-private-key /path/to/compromised_private_key.key
./bin/auth revoke-all-keys-for-user username
Dec 14 2015, 12:07 AM · Auth, Feature Request

Dec 13 2015

nickz added a comment to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

I can't reproduce that. Here's a search using "Path", which seems to work correctly:


Can you give me more details about how to reproduce the issue you're seeing?

Dec 13 2015, 11:56 PM · Maniphest, Phame, Owners, Arcanist, Conduit

Dec 11 2015

nickz created T9967: Provide a more straightforward way to revoke SSH keys by finding and destroying the objects.
Dec 11 2015, 10:50 PM · Auth, Feature Request
nickz added a comment to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

You might already know, but I noticed that the owners search is broken if I use "path" instead of "Repositories" to query. Also it would be great if we can use the package name to search.

Dec 11 2015, 9:56 PM · Maniphest, Phame, Owners, Arcanist, Conduit

Dec 4 2015

nickz added a comment to T9904: The Paste app doesn't work.

Yeah, I upgraded my dev instance to Head which doesn't have this issue. Thanks!

Dec 4 2015, 11:46 PM · Paste
nickz updated the title for P1901 test1 from untitled to test1.
Dec 4 2015, 11:39 PM
nickz created T9904: The Paste app doesn't work.
Dec 4 2015, 11:38 PM · Paste

Nov 30 2015

nickz added a comment to D14589: Partially revert D14511 to fix "INLINE COMMENTS" in mail.

Indeed, it works after I turned it back on. Thanks!

Nov 30 2015, 10:18 PM
nickz added a comment to D14589: Partially revert D14511 to fix "INLINE COMMENTS" in mail.

I tested the change and this partially works, now I see the email shows like the following:
INLINE COMMENTS

urls.py:5 test inline comments.
Nov 30 2015, 7:19 PM

Nov 24 2015

nickz created T9847: bug: race condition in updating reviews.
Nov 24 2015, 10:35 PM · Differential

Nov 16 2015

nickz added a comment to T9802: `arc land` continues when the merge fails.

Okay, it turned out he installed Arcanist using brew, not sure why it caused the difference though. I have updated our wiki page asking people to install Arcanist by following the instruction at https://secure.phabricator.com/book/phabricator/article/arcanist/.

Nov 16 2015, 10:30 PM · Arcanist
nickz added a comment to T9802: `arc land` continues when the merge fails.

His version:

Nov 16 2015, 7:31 PM · Arcanist
nickz created T9802: `arc land` continues when the merge fails.
Nov 16 2015, 7:12 PM · Arcanist

Nov 10 2015

nickz awarded T3277: `arc cleanup` to cleanup branches used by `arc patch` a Love token.
Nov 10 2015, 12:52 AM · Arcanist

Oct 21 2015

nickz added a comment to P1871 Daemon error.

If I click any of the following tasks:

Oct 21 2015, 8:38 PM
nickz added a comment to P1871 Daemon error.

The new commits got stuck at importing:

Oct 21 2015, 8:24 PM
nickz added a comment to P1871 Daemon error.

If I go look at the task, I see this:

Oct 21 2015, 8:17 PM
nickz edited P1871 Daemon error.
Oct 21 2015, 8:12 PM

Aug 31 2015

nickz edited P1850 using differential.updaterevision.
Aug 31 2015, 6:30 PM

Aug 28 2015

nickz edited P1849 create repo.
Aug 28 2015, 12:20 AM

Aug 14 2015

nickz edited P1842 mysql.host.
Aug 14 2015, 9:47 PM

Aug 12 2015

nickz added a comment to T8004: Highlight files owned by self/project when viewing revision.

@epriestley, thanks for consolidating my request into this task! Some comments: a person could be an owner of multiple packages, it would be better to indicate all files with their package names instead of only indicate the files you are an owner of; We actually don't need to put the package name on each line, we can group the files by package and put the package name to each group. One benefit of indicating all files with package names is everybody see the same, there will be less confusion (in most cases we can assume everybody knows if s/he is an owner of a package).

Aug 12 2015, 7:42 AM · Owners, Differential

Aug 5 2015

nickz created T9069: arc patch can't handle binary file correctly.
Aug 5 2015, 12:27 AM · Customer Impact, Differential, Restricted Project, Arcanist

Jul 29 2015

nickz added a comment to P1835 FATAL ERROR.

thanks!

Jul 29 2015, 12:24 AM
nickz edited P1835 FATAL ERROR.
Jul 29 2015, 12:05 AM

Jul 27 2015

nickz added a comment to T8921: arc diff failing due to "invalid type" error.

Good catch! Thanks!!!

Jul 27 2015, 4:41 PM · Arcanist

Jul 26 2015

nickz added a comment to T8921: arc diff failing due to "invalid type" error.

EX10301:pinboard nickz$ arc diff --trace
libphutil loaded from '/Users/nickz/Arcanist/libphutil/src'.
arcanist loaded from '/Users/nickz/Arcanist/arcanist/src'.
Config: Reading user configuration file "/Users/nickz/.arcrc"...
Config: Did not find system configuration at "/etc/arcconfig".
Working Copy: Reading .arcconfig from "/Users/nickz/code/pinboard/.arcconfig".
Working Copy: Path "/Users/nickz/code/pinboard" is part of git working copy "/Users/nickz/code/pinboard".
Working Copy: Project root is at "/Users/nickz/code/pinboard".
Config: Did not find local configuration at "/Users/nickz/code/pinboard/.git/arc/config".
Loading phutil library from '/Users/nickz/code/pinboard/.phabricator-libs/affogatolinter'...
Loading phutil library from '/Users/nickz/code/pinboard/.phabricator-libs/owners'...

[0] <conduit> conduit.connect() <bytes = 455>
[1] <http> https://phabricator.pinadmin.com/api/conduit.connect

<<< [1] <http> 1,675,525 us
<<< [0] <conduit> 1,675,896 us

[2] <exec> $ git diff --no-ext-diff --no-textconv --raw 'HEAD' --
[3] <exec> $ git ls-files --others --exclude-standard

<<< [2] <exec> 139,713 us
<<< [3] <exec> 138,967 us

[4] <exec> $ git diff-files --name-only

<<< [4] <exec> 69,617 us

[5] <event> diff.didCollectChanges <listeners = 0>

<<< [5] <event> 54 us

[6] <exec> $ git rev-parse --verify HEAD^

<<< [6] <exec> 29,763 us

[7] <exec> $ git merge-base 'origin/master' HEAD

<<< [7] <exec> 31,620 us

[8] <exec> $ git rev-parse 'HEAD'

<<< [8] <exec> 28,088 us

[9] <exec> $ git log --first-parent --format=medium '955511af274213958dceec8da321a786467ed6bc'..'cd5209c7bf769de9e293afa3b8a90327a28a3d48'

<<< [9] <exec> 31,014 us

[10] <conduit> differential.query() <bytes = 291>
[11] <http> https://phabricator.pinadmin.com/api/differential.query

<<< [11] <http> 1,275,340 us
<<< [10] <conduit> 1,275,577 us

[12] <exec> $ git rev-parse --git-dir

<<< [12] <exec> 6,059 us
You have a saved revision message in '.git/arc/create-message'.
Message begins:

Jul 26 2015, 5:36 AM · Arcanist

Jul 24 2015

nickz added a comment to T8921: arc diff failing due to "invalid type" error.

Yes, arc up to date:

Jul 24 2015, 11:44 PM · Arcanist
nickz reopened T8921: arc diff failing due to "invalid type" error as "Open".
Jul 24 2015, 11:40 PM · Arcanist
nickz added a comment to T8921: arc diff failing due to "invalid type" error.

after updating to the latest version, I still got the error:

Jul 24 2015, 11:13 PM · Arcanist

Jul 21 2015

nickz created T8921: arc diff failing due to "invalid type" error.
Jul 21 2015, 11:46 PM · Arcanist

Jul 17 2015

nickz added a comment to T8812: Herald Rule does not send mails.

Cool, thanks!

Jul 17 2015, 5:06 PM · Herald
nickz added a comment to T8812: Herald Rule does not send mails.

Ah, yeah, I believe that's the issue, I thought the mailing list user doesn't have to be given the read permission specifically. Thanks a lot for looking!

Jul 17 2015, 5:01 PM · Herald

Jul 16 2015

nickz created T8863: Herald "Send an Email" action doesn't work.
Jul 16 2015, 9:17 PM · Herald
nickz edited P1825 (An Untitled Masterwork).
Jul 16 2015, 8:23 PM

Jul 15 2015

nickz added a comment to T8805: Improve error checking for third-party unit test engines.

is the following the same or different one?

Jul 15 2015, 9:30 PM · Arcanist

Jul 14 2015

nickz added a comment to T8805: Improve error checking for third-party unit test engines.

To us, this happens only when the lint fails. If no lintable change, it seems fine no matter if a unit test gets run or not.

Jul 14 2015, 10:48 PM · Arcanist

Jun 4 2015

nickz added a comment to F471547: Screen Shot 2015-06-04 at 1.12.43 PM.png.

Jun 4 2015, 8:22 PM

May 26 2015

nickz added a comment to T8317: Can't add a new path to an owner's package.

Let me know if you need more information.

May 26 2015, 5:23 PM · Owners
nickz created T8317: Can't add a new path to an owner's package.
May 26 2015, 5:22 PM · Owners

Apr 10 2015

nickz added a comment to T4245: Make repository URIs slightly prettier.

We'd like this to be done soon as well. People have been complaining about using callsigns.

Apr 10 2015, 6:28 PM · Prioritized, Diffusion (v3), KDE, Restricted Project

Feb 12 2015

nickz added a comment to T7166: Putting project to CCs as a condition of Herald Rule doesn't get triggered.

Okay, thanks @epriestley!

Feb 12 2015, 9:21 PM · Herald
nickz added a comment to T7166: Putting project to CCs as a condition of Herald Rule doesn't get triggered.

It would be great if we know the ETA for the fix no matter soon or not soon.

Feb 12 2015, 8:18 PM · Herald

Feb 11 2015

nickz added a comment to T7166: Putting project to CCs as a condition of Herald Rule doesn't get triggered.

Is this the same as the herald based replacement for project mentions + email (T6819) ?

Feb 11 2015, 5:39 PM · Herald

Feb 10 2015

nickz added a comment to T7166: Putting project to CCs as a condition of Herald Rule doesn't get triggered.

Hi Chad, Yes, without this fixed, we are not able to move forward for all tasks which need putting a project to CCs as a condition of the Herald Rule. Yes, it's up to your guys' priority list. But I hope this can be address very soon. Thanks!

Feb 10 2015, 11:56 PM · Herald
nickz added a comment to T7166: Putting project to CCs as a condition of Herald Rule doesn't get triggered.

@chad, have you found the root cause?

Feb 10 2015, 7:59 PM · Herald

Feb 9 2015

nickz added a comment to T7166: Putting project to CCs as a condition of Herald Rule doesn't get triggered.

@chad, I am glad you can reproduce it.

Feb 9 2015, 7:40 PM · Herald
nickz added a comment to T7166: Putting project to CCs as a condition of Herald Rule doesn't get triggered.

Anything I can do to faster the process to fix the bug?

Feb 9 2015, 5:41 PM · Herald

Feb 4 2015

nickz added a comment to T7166: Putting project to CCs as a condition of Herald Rule doesn't get triggered.

sterling matches a user in remarkup, while #sterling matches a project. Did you verify the sterling in the subscribers section clicks through to the project and not some user also named sterling? (Or said differently, did you type sterling as initially reported (not a bug and probably due to the issue I am describing) or #sterling (a bug)?)

Feb 4 2015, 11:10 PM · Herald
nickz created T7166: Putting project to CCs as a condition of Herald Rule doesn't get triggered.
Feb 4 2015, 7:56 PM · Herald

Aug 20 2014

nickz added a comment to T992: Send rich HTML mail bodies without impacting reply handling functionality.

Add myself as a follower.

Aug 20 2014, 12:39 AM · Mail, Differential

Aug 19 2014

nickz added a comment to F192631: Screen_Shot_2014-08-19_at_4.36.52_PM.png.

Aug 19 2014, 11:39 PM
nickz added a comment to T5260: Need a way to define common include/exclude patterns in lint.

Thanks Evan!

Aug 19 2014, 8:05 PM · Arcanist