Page MenuHomePhabricator

dgoldstein (David Goldstein)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 18 2015, 3:47 AM (380 w, 5 d)
Availability
Available

Recent Activity

Aug 10 2016

dgoldstein added a comment to T9410: Policy behavior for Herald rules is murky and inconsistent.

Yay

Aug 10 2016, 1:25 AM · Restricted Project, Herald, Restricted Project

May 6 2016

dgoldstein awarded T1022: arc patch fails to properly apply a patch which changes a symlink to a real file a Like token.
May 6 2016, 12:31 AM · Arcanist

Apr 27 2016

dgoldstein added a comment to T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.

I guess I was hoping for a timeline. Or an explanation of why it's hard
and not done yet. That page seems to me to say "we'll get to it when we
feel like it" (ok not a totally fair paraphrase, but it's one way to read
it). Waiting a year for a minor feature that would drastically improve one
of my workflows just makes it feel like you guys aren't being very
responsive to feedback about how the UI could be made better. And I have
plenty of other complaints about the ui - just haven't bothered filing most
of them.

Apr 27 2016, 11:26 PM · Restricted Project, User Delight, Maniphest
dgoldstein added a comment to T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.

that was not a particularly helpful response

Apr 27 2016, 11:00 PM · Restricted Project, User Delight, Maniphest
dgoldstein added a comment to T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.

Any updates here? This task has been open for over a year now and it's something I wish for approximately weekly.

Apr 27 2016, 10:33 PM · Restricted Project, User Delight, Maniphest

Mar 9 2016

dgoldstein added a comment to T10419: Sample herald rule results.

Thanks for all the examples - definitely makes sense that these behaviors are a bit of a different class than ones that actually examine file content.

Mar 9 2016, 4:30 AM · Herald, Feature Request
dgoldstein added a comment to T10419: Sample herald rule results.

I suppose the rules I am writing are fairly lint-like; part of this
reflects the sorry state of our lint infrastructure, though it is probably
a bit more flexible than herald. Having said that, sometimes I do want to
have rules that subscribe me to various diffs, before I figure out how to
automate my own advice; is there a way to add subscribers via lint rules?

Mar 9 2016, 4:01 AM · Herald, Feature Request

Mar 8 2016

dgoldstein awarded T9410: Policy behavior for Herald rules is murky and inconsistent a Orange Medal token.
Mar 8 2016, 11:58 PM · Restricted Project, Herald, Restricted Project
dgoldstein created T10542: personal herald rules should be able to be visible to more than just their owner.
Mar 8 2016, 7:19 AM · Herald, Feature Request
dgoldstein added a comment to T10419: Sample herald rule results.

Ok so I just took it for a spin while editing herald rules. While it sort of solves my problems, it's very much a poor-man's solution - it's completely out of the way from the "create a herald rule" workflow - ideally, on the page where I'm creating or editing a herald rule, the test console should be right there so I can try out my new rule without necessarily having to save it; also it would filter to just trying that rule instead of trying all the rules, which would cut down on visual noise. This sort of change would make it much easier for the non-power user to create working herald rules.

Mar 8 2016, 7:14 AM · Herald, Feature Request

Feb 23 2016

dgoldstein added a comment to T10419: Sample herald rule results.

Derp. I'll check it out.

Feb 23 2016, 2:10 AM · Herald, Feature Request
dgoldstein added a comment to T10419: Sample herald rule results.

what test console?

Feb 23 2016, 1:30 AM · Herald, Feature Request
dgoldstein created T10419: Sample herald rule results.
Feb 23 2016, 1:16 AM · Herald, Feature Request

Jan 5 2016

dgoldstein added a comment to T10088: ability to wontfix a maniphest task via an email command.

Mmm I didn't know that existed - will be super useful. Sorry for the bogus
task.

Jan 5 2016, 11:27 PM · Maniphest, Restricted Project, Feature Request
dgoldstein created T10088: ability to wontfix a maniphest task via an email command.
Jan 5 2016, 10:48 PM · Maniphest, Restricted Project, Feature Request

Dec 18 2015

dgoldstein added a project to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Restricted Project.

thx for deduping

Dec 18 2015, 6:11 AM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
dgoldstein added a comment to T10009: phabricator and maniphest should recognize links to themselves.

er better example: T1023 v. https://secure.phabricator.com/T1023. Ideally both would be handled the same way.

Dec 18 2015, 5:15 AM · Maniphest, Restricted Project, Feature Request

Dec 4 2015

dgoldstein added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).
$ time git branch --contains 1eb050dff95372999c17b06d6c4caa63ce3f1659
* langpack_as_js_module
Dec 4 2015, 2:28 AM · Restricted Project, Restricted Project, Arcanist
dgoldstein added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

Here's the first part of a trace of an arc diff for me (includes most of
the pre-commit-message work):

Dec 4 2015, 1:49 AM · Restricted Project, Restricted Project, Arcanist
dgoldstein added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

this repros reliably for me - 100% of the time.

Dec 4 2015, 1:46 AM · Restricted Project, Restricted Project, Arcanist
dgoldstein created T9898: `git branch --contains X` has cost in the realm of O(commits * branches).
Dec 4 2015, 1:19 AM · Restricted Project, Restricted Project, Arcanist

Sep 10 2015

dgoldstein added a comment to T7776: Loading delta between two diffs in Differential can result in diffs for large files failing to load.

@jhurwitz do you remember a diff that we saw this on?

Sep 10 2015, 12:43 AM · Restricted Project, Restricted Project, Differential

Aug 19 2015

dgoldstein closed T9220: test task as Resolved.
Aug 19 2015, 1:41 AM

Aug 3 2015

dgoldstein awarded T7820: Add "Closed, Duplicate" option to Status Action in Maniphest a Love token.
Aug 3 2015, 11:40 PM · Restricted Project, User Delight, Maniphest
dgoldstein added a project to T7819: Allow Merge Duplicates to work in either direction: Restricted Project.
Aug 3 2015, 10:28 PM · Restricted Project, User Delight, Maniphest
dgoldstein created T9052: "close as duplicate" workflow should allow me to close the task I'm looking at as a dupe of another.
Aug 3 2015, 9:52 PM · Maniphest, Restricted Project
dgoldstein added a comment to T8573: All reviewers should be allowed to mark a comment as done.

+1 to this.

Aug 3 2015, 9:45 PM · Restricted Project, Differential, Restricted Project

Mar 31 2015

dgoldstein created T7706: arc diff --update only uses first line of commit message.
Mar 31 2015, 12:45 AM · Restricted Project, Restricted Project, Arcanist

Mar 19 2015

dgoldstein added a comment to T7617: Make it easier to know why herald adds reviewers.

+1000 to improving serverside lint support. I have no problem with "can't
auto-change code" as the few uses of that we have have drawn some
complaints.

Mar 19 2015, 11:16 PM · Restricted Project, Herald

Mar 18 2015

dgoldstein added a comment to T7617: Make it easier to know why herald adds reviewers.

that would be nice (maybe even ideal) if lint was actually a reliable thing
for us.

Mar 18 2015, 10:45 PM · Restricted Project, Herald
dgoldstein added a comment to T7617: Make it easier to know why herald adds reviewers.

there are plenty of cases where we do want a security review instead of
just lint warnings - it's definitely not as simple as converting everything
to lint rules. And part of the problem is that lint isn't expressive
enough - and in some cases can't possibly be.

Mar 18 2015, 10:26 PM · Restricted Project, Herald
dgoldstein added a comment to T7617: Make it easier to know why herald adds reviewers.

So I guess I should explain more about our use case.

Mar 18 2015, 10:02 PM · Restricted Project, Herald
dgoldstein created T7617: Make it easier to know why herald adds reviewers.
Mar 18 2015, 4:07 AM · Restricted Project, Herald