arc alias outputs a confusing message when adding a shell command alias
WHAT HAPPENS
$ arc alias foo '!foo'
Aliased 'arc foo' to 'arc !foo'.
WHAT SHOULD HAPPEN
$ arc alias foo '!foo'
Aliased 'arc foo' to 'foo'.
Note that when running 'arc foo', it correctly runs 'foo'.
| Restricted Differential Revision | Restricted Diffusion Commit |
Aliased 'arc foo' to 'foo'.
I think we could be clearer than this. It could be misleading in cases like this:
Aliased 'arc review' to 'diff'.
Without context, I might expect arc review to now mean arc diff, when it really just means diff.
It would be more clear for the output to be explicit:
Aliased 'arc review' to shell command 'ls'.
Note that the comment when removing the alias has also this "issue":
$ arc alias foo
'arc foo' is currently aliased to 'arc !foo'.