Page MenuHomePhabricator
Feed All Stories

Dec 5 2015

epriestley closed T5162: Add Herald action value for content creator / author as Wontfix.

This doesn't describe a use case (per Contributing Feature Requests) except by reference to requiring projects (which is covered by T6030).

Dec 5 2015, 8:42 PM · Herald
epriestley closed T9206: Herald unable to place task up for grabs as Resolved by committing Restricted Diffusion Commit.
Dec 5 2015, 8:39 PM · Typeahead, Herald
epriestley added a revision to T9206: Herald unable to place task up for grabs: Unknown Object (Differential Revision).
Dec 5 2015, 8:38 PM · Typeahead, Herald
epriestley added a comment to T9352: Write some custom Herald glue for driving builds through Owners.

At HEAD, you can now edit this field via the owners.edit Conduit API method.

Dec 5 2015, 8:27 PM · Harbormaster, Herald, Owners, Prioritized
epriestley closed T9601: Herald rule not working as expected as Invalid.

No clue how to reproduce. If you see it again, grab the field value too? My guess is that it's something like the reviewer PHID ending up as the project PHID instead of your PHID and "Reviewer" needing to be updated to "Reviewers" or similar.

Dec 5 2015, 8:26 PM · Herald
epriestley added a comment to T7661: Object creation is often accompanied by transaction records which aren't of much use.

This is related to T5158, I'm going to split things up like this:

Dec 5 2015, 7:27 PM · Transactions, Maniphest
epriestley reopened T5158: Maniphest custom field refuses to use non-empty default value as "Open".

Ah, I figured out how to reproduce this.

Dec 5 2015, 7:25 PM · Transactions, Custom Fields, Maniphest
epriestley renamed T7661: Object creation is often accompanied by transaction records which aren't of much use from Custom field default isn't populated at creation to Object creation is often accompanied by transaction records which aren't of much use.
Dec 5 2015, 7:22 PM · Transactions, Maniphest
epriestley closed T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions as Resolved by committing Restricted Diffusion Commit.
Dec 5 2015, 7:20 PM · Maniphest, Herald
epriestley added a comment to T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions.

I think it wasn't that bad thanks to a similar set of changes elsewhere from D14669, which I wrote yesterday.

Dec 5 2015, 7:19 PM · Maniphest, Herald
epriestley added a revision to T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions: Unknown Object (Differential Revision).
Dec 5 2015, 7:17 PM · Maniphest, Herald
epriestley added a revision to T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions: Unknown Object (Differential Revision).
Dec 5 2015, 7:12 PM · Maniphest, Herald
epriestley closed T9496: Allow Maniphest custom statuses (and priorities) to be disabled as Resolved by committing Restricted Diffusion Commit.
Dec 5 2015, 7:01 PM · Maniphest
epriestley reopened T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions as "Open".
Dec 5 2015, 6:59 PM · Maniphest, Herald
epriestley added a comment to T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions.

Oh, I should have read that comment more carefully. You tested more thoroughly than I did.

Dec 5 2015, 6:59 PM · Maniphest, Herald
epriestley closed T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions as Resolved.
Dec 5 2015, 6:56 PM · Maniphest, Herald
epriestley closed T7250: Actions in wrong order after merging duplicates + reopening as Resolved by committing Restricted Diffusion Commit.
Dec 5 2015, 6:51 PM · Maniphest
epriestley added a revision to T9496: Allow Maniphest custom statuses (and priorities) to be disabled: Unknown Object (Differential Revision).
Dec 5 2015, 6:44 PM · Maniphest
epriestley claimed T9496: Allow Maniphest custom statuses (and priorities) to be disabled.
Dec 5 2015, 6:41 PM · Maniphest
epriestley claimed T7250: Actions in wrong order after merging duplicates + reopening.
Dec 5 2015, 6:09 PM · Maniphest
epriestley added a revision to T7250: Actions in wrong order after merging duplicates + reopening: Unknown Object (Differential Revision).
Dec 5 2015, 6:08 PM · Maniphest
epriestley closed T5158: Maniphest custom field refuses to use non-empty default value as Resolved.

This no longer reproduces for me at HEAD in EditEngine (see T9905), although I can't immediately reproduce it in the old editor either. Since it seems like it got fixed somewhere I'm not going to worry about it too much.

Dec 5 2015, 5:57 PM · Transactions, Custom Fields, Maniphest
Mnkras added a comment to T9897: Unbeta Feedback on Phame.

That is hypothetical, but for example, lets say Evan publishes a post with the following:
/blog/750/development_notes_2015_week_494949494949494/
but really meant for the slug to be
/blog/750/development_notes_2015_week_49/

Dec 5 2015, 5:55 PM · Phame
chad updated the task description for T9897: Unbeta Feedback on Phame.
Dec 5 2015, 5:53 PM · Phame
epriestley updated the task description for T9905: Upgrading: ApplicationEditor changes in Maniphest.
Dec 5 2015, 5:53 PM · Maniphest, Installing & Upgrading
chad added a comment to T9897: Unbeta Feedback on Phame.

Isn't that a hypothetical?

Dec 5 2015, 5:50 PM · Phame
Mnkras added a comment to T9897: Unbeta Feedback on Phame.

The easiest thing I can think of is simple typos/ bad c&p job

Dec 5 2015, 5:43 PM · Phame
chad added a comment to T9897: Unbeta Feedback on Phame.

How are you expecting bad urls to get generated?

Dec 5 2015, 5:42 PM · Phame
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

Defining permissions for newbies that may be distinct from the "got the hang of it" crowd

Dec 5 2015, 5:37 PM · ApplicationEditor
robla added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

Maniphest currently has field-level edit permissions (e.g., "Can Edit Task Status", "Can Assign Tasks"). My belief is that these are essentially always used to hide fields in order to simplify interfaces, not as real policy controls to prevent changes, per se. I would like to remove them entirely: I think they add a lot of complexity and are very difficult to explain to the user, particularly on the email and Herald flows. Broadly, I don't want to move toward a future where every field in every application has a per-field edit policy.

Dec 5 2015, 5:29 PM · ApplicationEditor
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 5 2015, 5:14 PM · Restricted Project, ApplicationEditor, Transactions
Mnkras added a comment to T9897: Unbeta Feedback on Phame.

I have a concern about the /blog/<postid>/ignored_post_title/ approach, if the blog is indexed by Google, /blog/<postid>/ignored_post_title/ and /blog/<postid>/derpa/ will have the exact same content which Google penalizes.

Dec 5 2015, 5:10 PM · Phame
chad added a revision to T9897: Unbeta Feedback on Phame: Unknown Object (Differential Revision).
Dec 5 2015, 4:48 PM · Phame
chad closed T9910: All Columns are as long as the longest column on the board. Due to this the mobile view has a lot of spaces after each column. as Invalid.

Can't reproduce anything here, with Workboards/Mobile. If this was a real bug report, please follow Contributing Bug Reports and re-open.

Dec 5 2015, 4:45 PM · Mobile
chad added a revision to T9909: Received email about subscription to Phame but I have 'Ignore' set to prevent that.: Unknown Object (Differential Revision).
Dec 5 2015, 4:40 PM · Phame, Mail
chad moved T9895: Update Phame Documentation from Backlog to Unbeta (v1) on the Phame board.
Dec 5 2015, 4:40 PM · Phame
chad moved T9897: Unbeta Feedback on Phame from Backlog to Unbeta (v1) on the Phame board.
Dec 5 2015, 4:40 PM · Phame
chad added a revision to T9897: Unbeta Feedback on Phame: Unknown Object (Differential Revision).
Dec 5 2015, 4:39 PM · Phame
johnny-bit added a comment to T9360: Unbeta Phame.

We use SNI and nobody says it's bad. Hell, people actually WANT SNI, since when hositng fo example small shop, you basically need SSL (even cheap one), but IP address (especially IPv4) is pricey per month. Most people when faced with "additional $$$/month with only benefit being customers using ancient software" or "0/month additional charges, only lose handfull of ancient software-using customers" chose 0/month 😉

Dec 5 2015, 3:30 PM · Phame
epriestley added a comment to T9897: Unbeta Feedback on Phame.

(You could put more ignore stuff in the route too if you want the blog title.)

Dec 5 2015, 3:21 PM · Phame
epriestley added a comment to T9897: Unbeta Feedback on Phame.

You can probably just do that by adding a route like this:

Dec 5 2015, 3:11 PM · Phame
chad added a comment to T9897: Unbeta Feedback on Phame.

ah yeah thats good enough

Dec 5 2015, 3:07 PM · Phame
epriestley added a comment to T9897: Unbeta Feedback on Phame.

Yes, but blogs don't have slugs right now and blog post slugs are editable.

Dec 5 2015, 3:06 PM · Phame
chad added a comment to T9897: Unbeta Feedback on Phame.

Also, I need to fix this:

Dec 5 2015, 3:05 PM · Phame
chad added a comment to T9897: Unbeta Feedback on Phame.

is it relatively easy to do with routes, something like /b/blog_title/blog_post/

Dec 5 2015, 3:03 PM · Phame
epriestley updated the post content for Blog Post: Development Notes (2015 Week 49).
Dec 5 2015, 2:39 PM
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

The interaction between Maniphest "Can Edit X" fields and the new form stuff is also currently quite bad. I've restored 'Can Prioritize Tasks' to "All Users" on this install, since users otherwise can not create tasks with the new forms.

Dec 5 2015, 2:21 PM · ApplicationEditor
epriestley closed T9911: test as Spite.
Dec 5 2015, 2:20 PM · Feature Request
• demo closed T9912: asdb as Spite.
Dec 5 2015, 2:20 PM · Feature Request
• demo created T9912: asdb.
Dec 5 2015, 2:19 PM · Feature Request
• demo created T9911: test.
Dec 5 2015, 2:19 PM · Feature Request
• demo closed Restricted Maniphest Task, a subtask of T6215: Referencing to restricted tasks in Blocks / Blocked By fields, as Spite.
Dec 5 2015, 2:18 PM · Maniphest
epriestley added a comment to T9360: Unbeta Phame.

The story on SNI actually looks pretty reasonable (we're mostly just losing IE on XP and very old mobile devices), and should be more reasonable by the time we're thinking about whitelabeling main instances.

Dec 5 2015, 2:02 PM · Phame
epriestley added a comment to T9360: Unbeta Phame.

It's also possible that we can roll our own loadbalancers by assigning a lot of elastic IPs to a single host. This currently allows us to put ~240 domains on a host, at a cost of ~$4 per domain per month (for the elastic IP) instead of ~$20 per domain per month, but is more work. In contrast, SNI would let us put thousands of domains on a host with no cost per domain.

Dec 5 2015, 1:52 PM · Phame
epriestley added a comment to T9360: Unbeta Phame.

One other thing is that custom domains won't work on Phacility by default, and I don't think we can easily make them work (we can't just have users CNAME their DNS because we won't have the right SSL certificate). So maybe that's an argument for removing the feature or adding an option (ugh) to disable it.

Dec 5 2015, 1:46 PM · Phame
• ashishchoudhary edited P1904 (An Untitled Masterwork).
Dec 5 2015, 1:09 PM
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

I'm consistently not seeing a comment preview on T9910. Likely trace:

Dec 5 2015, 12:56 PM · ApplicationEditor
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

The major product issue I'm now unsure about is what form we should use when you interact with the create/edit flow from places other than Maniphest → Create Task. Exhaustively, I believe these are:

Dec 5 2015, 12:45 PM · ApplicationEditor
tycho.tatitscheff added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

@epriestley, not sure you are aware of this but the "create dropdown" (big "+" in navbar) still point manifest task to the default form.

Dec 5 2015, 12:17 PM · ApplicationEditor
tycho.tatitscheff awarded T9905: Upgrading: ApplicationEditor changes in Maniphest a Love token.
Dec 5 2015, 12:08 PM · Maniphest, Installing & Upgrading
epriestley triaged T9898: `git branch --contains X` has cost in the realm of O(commits * branches) as Low priority.

That makes sense, and should work well if you're able to convince developers to use arc feature (or the underlying branch flags, or I think branch.autosetupmerge in Git config?) consistently. You might also consider leaving git:branch-unique(...) in the ruleset after arc:upstream -- it should behave well in more situations than git:merge-base(...) will, I think, and it might be preferable if the penalty for not using --track is "things work, but are slow" instead of "things don't work".

Dec 5 2015, 11:55 AM · Restricted Project, Restricted Project, Arcanist
epriestley added a comment to T9905: Upgrading: ApplicationEditor changes in Maniphest.

Just to be clear, after this week - sites that upgrade but are tracking the stable branch will be affected by these changes?

Dec 5 2015, 11:28 AM · Maniphest, Installing & Upgrading
hach-que updated the title for P1903 Bananarama from untitled to Bananarama.

whooop

Dec 5 2015, 5:59 AM
chad added a comment to T9910: All Columns are as long as the longest column on the board. Due to this the mobile view has a lot of spaces after each column..

Are you testing Phabricator or trying to file a bug?

Dec 5 2015, 5:37 AM · Mobile
rohanmahadar created T9910: All Columns are as long as the longest column on the board. Due to this the mobile view has a lot of spaces after each column..
Dec 5 2015, 5:35 AM · Mobile
angie moved T5031: Draft Comment Persists After Submission from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Dec 5 2015, 5:09 AM · Restricted Project, Support Impact, Mobile
angie moved T9621: Ability to add comments to Phriction docs from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Dec 5 2015, 5:09 AM · Restricted Project
angie moved T9676: Triangle workflows (pushing to a merge manager) from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Dec 5 2015, 5:08 AM · Restricted Project
angie moved T9729: Query differential messages via Conduit API from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Dec 5 2015, 5:08 AM · Restricted Project
angie moved T9751: In the "Leap Into Action" box, Added subscribers don't get cleared if you switch the action from "Add Subscribers" to "Comment" from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Dec 5 2015, 5:08 AM · Restricted Project
angie moved T9783: Multiple linters affecting same line, one of which applying autocorrect from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Dec 5 2015, 5:07 AM · Restricted Project, Lint
angie moved T9853: Support comments in Herald Actions from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Dec 5 2015, 5:07 AM · Restricted Project
angie moved T6226: Conduit-created task always results in [Reopened] tag in the email subject from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Dec 5 2015, 5:06 AM · Restricted Project, Maniphest, Conduit
chad added a comment to T9909: Received email about subscription to Phame but I have 'Ignore' set to prevent that..

I should probably add a subscriber setting for posts too, though.

Dec 5 2015, 3:20 AM · Phame, Mail
cspeckmim added a comment to T9909: Received email about subscription to Phame but I have 'Ignore' set to prevent that..

Ah sorry, thanks for the clarification. I also just remembered that it's still prototype.

Dec 5 2015, 3:19 AM · Phame, Mail
chad added a comment to T9909: Received email about subscription to Phame but I have 'Ignore' set to prevent that..

You have blogs set to ignore subscriber changes, not posts (not really a setting for that).

Dec 5 2015, 3:16 AM · Phame, Mail
chad closed T9909: Received email about subscription to Phame but I have 'Ignore' set to prevent that. as Resolved.
Dec 5 2015, 3:14 AM · Phame, Mail
chad added a comment to T9909: Received email about subscription to Phame but I have 'Ignore' set to prevent that..

pasted_file (61×811 px, 23 KB)

Dec 5 2015, 3:14 AM · Phame, Mail
cspeckmim added a comment to T9905: Upgrading: ApplicationEditor changes in Maniphest.

These new features are exciting!

Dec 5 2015, 2:59 AM · Maniphest, Installing & Upgrading
cspeckmim created T9909: Received email about subscription to Phame but I have 'Ignore' set to prevent that..
Dec 5 2015, 2:56 AM · Phame, Mail
epriestley renamed Blog Post: Development Notes (2015 Week 49) blog post from to Development Notes (2015 Week 49).
Dec 5 2015, 1:08 AM
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

Policy junk should be fixed.

Dec 5 2015, 1:06 AM · ApplicationEditor
epriestley added a comment to T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.

The basics of the ApplicationEditor stuff are now live on this install, and T9908 has some discussion of the direction I think we can pursue for the "Security" use case.

Dec 5 2015, 1:01 AM · Maniphest, Installing & Upgrading
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

Edit forms are causing some policy checks to apply incorrectly so tasks (which should be public) currently aren't. Looking into that...

Dec 5 2015, 12:54 AM · ApplicationEditor
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

One severe regression is that the description textarea in the create form is tiny now. I need to make that gigantic again.

Dec 5 2015, 12:52 AM · ApplicationEditor
epriestley added a comment to T9905: Upgrading: ApplicationEditor changes in Maniphest.

I landed what I've got so far, pushed it here, configured it a bit, and described what I've done in T9908, for the curious.

Dec 5 2015, 12:51 AM · Maniphest, Installing & Upgrading
epriestley created T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.
Dec 5 2015, 12:50 AM · ApplicationEditor
epriestley closed T9907: Testing feature request form as Spite.
Dec 5 2015, 12:42 AM · Feature Request
epriestley created T9907: Testing feature request form.
Dec 5 2015, 12:42 AM · Feature Request
epriestley closed T9906: Testing bug report form as Invalid.
Dec 5 2015, 12:42 AM · Bug Report
epriestley created T9906: Testing bug report form.
Dec 5 2015, 12:41 AM · Bug Report
epriestley set the image for Feature Request to F1014086: project.png.
Dec 5 2015, 12:40 AM
epriestley set the image for Bug Report to F1014085: project.png.
Dec 5 2015, 12:40 AM
epriestley set the icon for Bug Report to fa-bug.
Dec 5 2015, 12:39 AM
epriestley created Feature Request.
Dec 5 2015, 12:39 AM
epriestley created Bug Report.
Dec 5 2015, 12:39 AM
epriestley closed T4580: Auto saving forms doesn't save dynamic form visibility state as Resolved by committing Restricted Diffusion Commit.
Dec 5 2015, 12:31 AM · Maniphest
hach-que added a comment to T9905: Upgrading: ApplicationEditor changes in Maniphest.

(consistent edit endpoints in Conduit and custom task forms are what I'm most looking forward to)

Dec 5 2015, 12:27 AM · Maniphest, Installing & Upgrading
hach-que changed the image for Image Macro "lotsofthumbsup".
Dec 5 2015, 12:25 AM
epriestley edited the content of Changelog.
Dec 5 2015, 12:14 AM