Page MenuHomePhabricator

Header buttons on dashboard panels are lost when panels are embedded in a tab panel
Closed, WontfixPublic

Description

I'd like to be able to see the full results of a query from a truncated list in a dashboard. The search icon handles this well for query panels, but tabbed panels don't include this header.

Event Timeline

puls updated the task description. (Show Details)
puls added a project: Dashboards.
puls added a subscriber: puls.

Specifically, you're talking about this?

  • Create a Query panel.
  • Click the "" icon in the upper right to see full results list.
  • Now embed the query panel inside a tab panel.
  • No longer any way to access the full result list.

Right?

chad edited projects, added Dashboards (v2); removed Dashboards.
epriestley renamed this task from Link to full query from tabbed dashboard panels to Header buttons on dashboard panels are lost when panels are embedded in a tab panel.Mar 27 2019, 5:45 PM
epriestley triaged this task as Wishlist priority.

I believe D20336 fixes the primary practical issue here, by adding a "View All Results" button to the bottom of query panels (including query panels inside tab panels), when there are more results:

Screen Shot 2019-03-27 at 10.40.10 AM.png (340×1 px, 45 KB)

In cases where a query panel inside a tab panel is showing all the results, there's still no way to get to the standalone search UI (in a non-tab panel, the "View All Results" button in the header would be the way to do this). This should still be fixed, but I'd guess 95% of the time the button at the bottom of the list solves the actual problem.

epriestley edited projects, added Dashboards; removed Dashboards (v2).
epriestley claimed this task.

I'm just going to mark this as "Wontfix", since:

  • the only actual use case (getting a link to the full results) is resolved by the "View All" button;
  • the general case of this has no obvious path forward because tab panels may be embedded in other tab panels.

If additional use cases arise, we can deal with them on a case-by-case basis.