Page MenuHomePhabricator
Feed All Stories

Wed, Feb 17

epriestley closed D21562: Limit remarkup URI protocol length to 32 characters to avoid expensive regex behavior.
Wed, Feb 17, 9:21 PM
epriestley requested review of D21562: Limit remarkup URI protocol length to 32 characters to avoid expensive regex behavior.
Wed, Feb 17, 9:13 PM
epriestley added a revision to T13608: Remarkup hyperlink pattern may backtrack explosively: D21562: Limit remarkup URI protocol length to 32 characters to avoid expensive regex behavior.
Wed, Feb 17, 9:12 PM
epriestley added a comment to T13608: Remarkup hyperlink pattern may backtrack explosively.

This passes tests, but it sure is a big mess compared to a 3-character change to just add a maximum length, and discretion is the better part of avoiding a sunk cost fallacy or something along those lines:

Wed, Feb 17, 9:00 PM
epriestley requested review of D21561: Provide some "preg_*" wrappers which raise exceptions on failure.
Wed, Feb 17, 8:44 PM
epriestley added a revision to T13608: Remarkup hyperlink pattern may backtrack explosively: D21561: Provide some "preg_*" wrappers which raise exceptions on failure.
Wed, Feb 17, 8:44 PM
epriestley added a comment to T13608: Remarkup hyperlink pattern may backtrack explosively.

At least on my system, no: \w+, \w{3,}, and \w{3,}+ all take 60s+ to (fail to) match AAAAAAAA... (with total length 512KB).

Wed, Feb 17, 8:31 PM
richardvanvelzen added a comment to T13608: Remarkup hyperlink pattern may backtrack explosively.

Perhaps \w{3,}+ resolves the issue? (+ being a possessive quantifier here that prevents backtracking)

Wed, Feb 17, 7:49 PM
epriestley added a comment to T13608: Remarkup hyperlink pattern may backtrack explosively.

We also can't pass $flags to preg_replace_callback(...) because it wasn't supported until PHP 7.4. This means preg_replace_callback() can't operate on a match-offset basis.

Wed, Feb 17, 6:22 PM
epriestley triaged T13608: Remarkup hyperlink pattern may backtrack explosively as Low priority.
Wed, Feb 17, 6:16 PM
epriestley updated the diff for D21493: Separate Herald transcripts into several different views.
  • Fix regexp issue.
Wed, Feb 17, 4:05 PM
epriestley added a comment to T13587: Ferret may exhaust AUTO_INCREMENT ID space of "ngrams" table after many reindexes.

I've deployed these changes to secure, so hopefully any issues will present themselves.

Wed, Feb 17, 12:18 AM · Search
epriestley added a comment to T13587: Ferret may exhaust AUTO_INCREMENT ID space of "ngrams" table after many reindexes.

If something goes wrong with this, the patch which fixes the problem can now change the indexer version and then all mis-indexed documents can be reindexed with:

Wed, Feb 17, 12:10 AM · Search
epriestley committed rP6703fec3e27d: When documents are indexed, record the indexer version (versus the object… (authored by epriestley).
When documents are indexed, record the indexer version (versus the object…
Wed, Feb 17, 12:09 AM
epriestley committed rP4f647fb6be2b: When updating a Ferret search index document, reuse existing rows where possible (authored by epriestley).
When updating a Ferret search index document, reuse existing rows where possible
Wed, Feb 17, 12:09 AM
epriestley closed D21560: When documents are indexed, record the indexer version (versus the object version) and index epoch.
Wed, Feb 17, 12:09 AM
epriestley closed D21495: When updating a Ferret search index document, reuse existing rows where possible.
Wed, Feb 17, 12:09 AM
epriestley updated the diff for D21560: When documents are indexed, record the indexer version (versus the object version) and index epoch.
  • Correct "bin/index" -> "bin/search index".
Wed, Feb 17, 12:06 AM
epriestley updated the diff for D21560: When documents are indexed, record the indexer version (versus the object version) and index epoch.
  • Fix typos and bugs, test more "--type" flag values.
Wed, Feb 17, 12:03 AM
epriestley requested review of D21560: When documents are indexed, record the indexer version (versus the object version) and index epoch.
Wed, Feb 17, 12:00 AM

Tue, Feb 16

epriestley added a revision to T13587: Ferret may exhaust AUTO_INCREMENT ID space of "ngrams" table after many reindexes: D21560: When documents are indexed, record the indexer version (versus the object version) and index epoch.
Tue, Feb 16, 11:59 PM · Search
epriestley added a comment to T13587: Ferret may exhaust AUTO_INCREMENT ID space of "ngrams" table after many reindexes.

The existing SearchIndexVersion table (which stores document versions) may reasonably be able to store index versions too. This limits the need to apply changes to fdocument.

Tue, Feb 16, 10:00 PM · Search
epriestley added a comment to T13587: Ferret may exhaust AUTO_INCREMENT ID space of "ngrams" table after many reindexes.

This has stalled for a while because it's moderately expensive to recover from if the updated index logic has a bug: rebuilding all document indexes is expensive, and it's difficult to identify the set of documents that need to be reindexed if a bug is present.

Tue, Feb 16, 8:52 PM · Search
epriestley updated the diff for D21495: When updating a Ferret search index document, reuse existing rows where possible.
  • Fix recently added lint warning about catching "Exception" without "Throwable".
Tue, Feb 16, 8:46 PM
epriestley closed T13607: Provide additional query constraints in "harbormaster.target.search" as Resolved.

Yep, that's more constraints.

Tue, Feb 16, 8:34 PM · Harbormaster, Conduit
epriestley committed rP5d6dddc5eb61: Add more constraints to "harbormaster.target.search" (authored by epriestley).
Add more constraints to "harbormaster.target.search"
Tue, Feb 16, 8:22 PM
epriestley closed D21559: Add more constraints to "harbormaster.target.search".
Tue, Feb 16, 8:22 PM
epriestley requested review of D21559: Add more constraints to "harbormaster.target.search".
Tue, Feb 16, 8:07 PM
epriestley added a revision to T13607: Provide additional query constraints in "harbormaster.target.search": D21559: Add more constraints to "harbormaster.target.search".
Tue, Feb 16, 8:06 PM · Harbormaster, Conduit
epriestley triaged T13607: Provide additional query constraints in "harbormaster.target.search" as Normal priority.
Tue, Feb 16, 7:47 PM · Harbormaster, Conduit
epriestley updated the task description for T9069: arc patch can't handle binary file correctly.
Tue, Feb 16, 7:11 PM · Differential, Restricted Project, Arcanist
epriestley updated the task description for T1022: arc patch fails to properly apply a patch which changes a symlink to a real file.
Tue, Feb 16, 7:11 PM · Arcanist

Mon, Feb 15

epriestley triaged T13606: In Diffusion UI, satisfy "Refs" query from the database, not the API as Normal priority.
Mon, Feb 15, 8:17 PM · Diffusion
epriestley closed T13605: Implement a "differential.changeset.search" API method as Resolved.

See T13125 and PHI1997 for followup.

Mon, Feb 15, 7:47 PM · Harbormaster, Differential
epriestley added a comment to T13125: Plans: Code coverage reporting.

See PHI1997, which discusses things from the perspective of reporting coverage from a build system.

Mon, Feb 15, 7:44 PM · Diffusion, Plans
epriestley closed D21557: Add a PHID to Changesets.
Mon, Feb 15, 7:11 PM
epriestley closed D21558: Provide a "differential.changeset.search" Conduit API method.
Mon, Feb 15, 7:11 PM
epriestley committed rPec5476a01f5f: Add a PHID to Changesets (authored by epriestley).
Add a PHID to Changesets
Mon, Feb 15, 7:11 PM
epriestley committed rP9feb7343e662: Provide a "differential.changeset.search" Conduit API method (authored by epriestley).
Provide a "differential.changeset.search" Conduit API method
Mon, Feb 15, 7:11 PM
epriestley requested review of D21558: Provide a "differential.changeset.search" Conduit API method.
Mon, Feb 15, 7:09 PM
epriestley added a revision to T13605: Implement a "differential.changeset.search" API method: D21558: Provide a "differential.changeset.search" Conduit API method.
Mon, Feb 15, 7:07 PM · Harbormaster, Differential
epriestley requested review of D21557: Add a PHID to Changesets.
Mon, Feb 15, 6:15 PM
epriestley added a revision to T13605: Implement a "differential.changeset.search" API method: D21557: Add a PHID to Changesets.
Mon, Feb 15, 6:13 PM · Harbormaster, Differential
epriestley triaged T13605: Implement a "differential.changeset.search" API method as Normal priority.
Mon, Feb 15, 6:01 PM · Harbormaster, Differential
epriestley triaged T13604: Phacility repository shards may restart incompletely as Low priority.
Mon, Feb 15, 5:17 PM · Phacility
epriestley added a comment to I2 Donate to Phacility.

In 2014, Phacility was still largely pre-revenue and the business model wasn't entirely clear, and there was value in testing support for payment processing by handling small, low-stakes charges. Phacility now has revenue and more clarity around the business model (and the payment processing code is more mature and proven), and accepting donations (even with the disclaimer that Phacility is an "evil, for-profit corporation") no longer feels appropriate.

Mon, Feb 15, 4:35 PM · Phacility
epriestley closed I2 Donate to Phacility.
Mon, Feb 15, 4:27 PM · Phacility

Sat, Feb 13

epriestley edited the content of Changelog.
Sat, Feb 13, 9:38 PM
epriestley committed rP42c26821ef92: When a revision has only human reviewers but none can view it, show a warning… (authored by epriestley).
When a revision has only human reviewers but none can view it, show a warning…
Sat, Feb 13, 9:38 PM
epriestley committed rP90903282c706: Render user hovercards with context information about their ability to see the… (authored by epriestley).
Render user hovercards with context information about their ability to see the…
Sat, Feb 13, 9:38 PM
epriestley committed rPa4cb2bb77247: When a subscriber can't see an object, clearly show that they're missing the… (authored by epriestley).
When a subscriber can't see an object, clearly show that they're missing the…
Sat, Feb 13, 9:38 PM
epriestley committed rP2f33dedc8b62: When a reviewer can't see a revision, show it clearly in the reviewer list (authored by epriestley).
When a reviewer can't see a revision, show it clearly in the reviewer list
Sat, Feb 13, 9:38 PM
epriestley closed D21556: When a revision has only human reviewers but none can view it, show a warning banner.
Sat, Feb 13, 9:38 PM
epriestley committed rP2aac3156f791: Restructure Hovercards to support more context information (authored by epriestley).
Restructure Hovercards to support more context information
Sat, Feb 13, 9:38 PM
epriestley committed rPf0dc06529033: Lift bulk tests for "many users against one object" capabilities into… (authored by epriestley).
Lift bulk tests for "many users against one object" capabilities into…
Sat, Feb 13, 9:38 PM
epriestley closed D21554: Render user hovercards with context information about their ability to see the context object.
Sat, Feb 13, 9:38 PM
epriestley committed rP58bbd6ee8838: Propagate the "ContextObject" to Remarkup rendering in timelines (authored by epriestley).
Propagate the "ContextObject" to Remarkup rendering in timelines
Sat, Feb 13, 9:38 PM
epriestley closed D21546: Lift bulk tests for "many users against one object" capabilities into "PolicyFilterSet".
Sat, Feb 13, 9:38 PM
epriestley closed D21547: When a subscriber can't see an object, clearly show that they're missing the permission in the curtain UI.
Sat, Feb 13, 9:37 PM
epriestley closed D21555: When a reviewer can't see a revision, show it clearly in the reviewer list.
Sat, Feb 13, 9:37 PM
epriestley closed D21553: Restructure Hovercards to support more context information.
Sat, Feb 13, 9:37 PM
epriestley closed D21548: Propagate the "ContextObject" to Remarkup rendering in timelines.
Sat, Feb 13, 9:37 PM
epriestley created an object: 2021 Week 7 (Mid February).
Sat, Feb 13, 9:36 PM
epriestley committed rARCfaca82a3d55c: (stable) Promote 2021 Week 7 (authored by epriestley).
(stable) Promote 2021 Week 7
Sat, Feb 13, 9:36 PM
epriestley committed rP6bcd8a49d064: (stable) Promote 2021 Week 7 (authored by epriestley).
(stable) Promote 2021 Week 7
Sat, Feb 13, 9:36 PM
epriestley requested review of D21556: When a revision has only human reviewers but none can view it, show a warning banner.
Sat, Feb 13, 9:22 PM
epriestley added a revision to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers: D21556: When a revision has only human reviewers but none can view it, show a warning banner.
Sat, Feb 13, 9:21 PM · Policy, Differential
epriestley requested review of D21555: When a reviewer can't see a revision, show it clearly in the reviewer list.
Sat, Feb 13, 9:13 PM
epriestley added a revision to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers: D21555: When a reviewer can't see a revision, show it clearly in the reviewer list.
Sat, Feb 13, 9:12 PM · Policy, Differential
epriestley requested review of D21554: Render user hovercards with context information about their ability to see the context object.
Sat, Feb 13, 9:11 PM
epriestley added a revision to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers: D21554: Render user hovercards with context information about their ability to see the context object.
Sat, Feb 13, 8:56 PM · Policy, Differential
epriestley requested review of D21553: Restructure Hovercards to support more context information.
Sat, Feb 13, 8:01 PM
epriestley added a revision to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers: D21553: Restructure Hovercards to support more context information.
Sat, Feb 13, 7:59 PM · Policy, Differential

Fri, Feb 12

epriestley updated the task description for T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch.
Fri, Feb 12, 7:52 PM · Differential

Wed, Feb 10

epriestley closed D21552: Update golint install instructions.
Wed, Feb 10, 6:03 PM
epriestley committed rARCf501f85eb8bf: Update golint install instructions (authored by vm).
Update golint install instructions
Wed, Feb 10, 6:03 PM
epriestley accepted D21552: Update golint install instructions.
Wed, Feb 10, 6:03 PM
vm updated the summary of D21552: Update golint install instructions.
Wed, Feb 10, 6:01 PM
vm requested review of D21552: Update golint install instructions.
Wed, Feb 10, 6:00 PM

Mon, Feb 8

epriestley added a comment to T13588: PHP 8 Compatibility.

I also don't see any way to really make useful assertions about this parameter statically.

Mon, Feb 8, 6:25 PM · Infrastructure
epriestley committed rP3e38579feea3: Update install and upgrade documentation for libphutil (authored by epriestley).
Update install and upgrade documentation for libphutil
Mon, Feb 8, 6:20 PM
epriestley closed D21550: Update install and upgrade documentation for libphutil.
Mon, Feb 8, 6:20 PM
epriestley closed D21551: In "array_mergev()", guarantee the "call_user_func_array()" parameter list is a natrual list.
Mon, Feb 8, 6:20 PM
epriestley committed rARC239ad5c55d8d: In "array_mergev()", guarantee the "call_user_func_array()" parameter list is a… (authored by epriestley).
In "array_mergev()", guarantee the "call_user_func_array()" parameter list is a…
Mon, Feb 8, 6:20 PM
epriestley requested review of D21551: In "array_mergev()", guarantee the "call_user_func_array()" parameter list is a natrual list.
Mon, Feb 8, 6:18 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21551: In "array_mergev()", guarantee the "call_user_func_array()" parameter list is a natrual list.
Mon, Feb 8, 6:17 PM · Infrastructure
epriestley added a comment to T13588: PHP 8 Compatibility.

PHP8 supports named arguments. At a minimum, the builtin function call_user_func_array() has changed behavior. This script:

Mon, Feb 8, 6:13 PM · Infrastructure
epriestley requested review of D21550: Update install and upgrade documentation for libphutil.
Mon, Feb 8, 5:49 PM
epriestley added a revision to T13395: Strip libphutil for parts: D21550: Update install and upgrade documentation for libphutil.
Mon, Feb 8, 5:47 PM · libphutil
epriestley committed rP67cf80b377bd: Test if "get_magic_quotes_gpc()" exists before calling it (authored by epriestley).
Test if "get_magic_quotes_gpc()" exists before calling it
Mon, Feb 8, 5:34 PM
epriestley closed D21549: Test if "get_magic_quotes_gpc()" exists before calling it.
Mon, Feb 8, 5:34 PM
epriestley requested review of D21549: Test if "get_magic_quotes_gpc()" exists before calling it.
Mon, Feb 8, 5:31 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21549: Test if "get_magic_quotes_gpc()" exists before calling it.
Mon, Feb 8, 5:29 PM · Infrastructure

Sun, Feb 7

CaptSpot updated CaptSpot.
Sun, Feb 7, 6:45 PM
epriestley edited the content of Changelog.
Sun, Feb 7, 6:37 PM
epriestley committed rARCdfc16ce41c91: (stable) Promote 2021 Week 6 (authored by epriestley).
(stable) Promote 2021 Week 6
Sun, Feb 7, 6:36 PM
epriestley committed rP3e42f8be126f: (stable) Promote 2021 Week 6 (authored by epriestley).
(stable) Promote 2021 Week 6
Sun, Feb 7, 6:36 PM
epriestley created an object: 2021 Week 6 (Early February).
Sun, Feb 7, 6:36 PM

Feb 5 2021

epriestley added a comment to T12771: Users can mistakenly create revisions with no repository through confusion or misconfiguration.

See also PHI1987 for another case of this.

Feb 5 2021, 4:30 PM · Arcanist, Customer Impact, Differential, Spaces, Feature Request
epriestley added a comment to T8644: Herald template / recipe book / examples / quick-create tool.

See also PHI1987, which is another motivation for the "diffs with no revision" rule from T12771.

Feb 5 2021, 4:30 PM · Restricted Project, Herald