Page MenuHomePhabricator

In "array_mergev()", guarantee the "call_user_func_array()" parameter list is a natrual list
ClosedPublic

Authored by epriestley on Feb 8 2021, 6:17 PM.
Tags
None
Referenced Files
F14402151: D21551.id51298.diff
Sun, Dec 22, 11:44 PM
Unknown Object (File)
Sun, Dec 22, 2:41 AM
Unknown Object (File)
Wed, Dec 11, 3:36 PM
Unknown Object (File)
Sun, Dec 8, 9:21 PM
Unknown Object (File)
Sun, Dec 8, 2:29 AM
Unknown Object (File)
Thu, Dec 5, 8:45 PM
Unknown Object (File)
Sun, Dec 1, 12:39 PM
Unknown Object (File)
Nov 22 2024, 9:30 AM
Subscribers
None

Details

Summary

Ref T13588. The behavior of "call_user_func_array()" has changed in PHP8, and the function now attempts to use array keys as argument names.

This always fails when calling "array_merge()" (which does not accept named parameters), and may cause misbehavior in the general case.

Guarantee the argument is a natural list (with keys "0", "1", "2", ...).

Test Plan

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2021, 6:18 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.