Page MenuHomePhabricator

In "array_mergev()", guarantee the "call_user_func_array()" parameter list is a natrual list
ClosedPublic

Authored by epriestley on Mon, Feb 8, 6:17 PM.

Details

Summary

Ref T13588. The behavior of "call_user_func_array()" has changed in PHP8, and the function now attempts to use array keys as argument names.

This always fails when calling "array_merge()" (which does not accept named parameters), and may cause misbehavior in the general case.

Guarantee the argument is a natural list (with keys "0", "1", "2", ...).

Test Plan

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Feb 8, 6:18 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.