Page MenuHomePhabricator

Test if "get_magic_quotes_gpc()" exists before calling it
ClosedPublic

Authored by epriestley on Feb 8 2021, 5:29 PM.
Tags
None
Referenced Files
F22190709: D21549.diff
Tue, Aug 25, 12:02 PM
Unknown Object (File)
Fri, Aug 21, 1:48 PM
Unknown Object (File)
Tue, Aug 18, 8:28 PM
Unknown Object (File)
Fri, Aug 14, 7:38 AM
Unknown Object (File)
Jun 24 2026, 11:21 AM
Unknown Object (File)
Jun 24 2026, 11:21 AM
Unknown Object (File)
Jun 24 2026, 11:10 AM
Unknown Object (File)
Jun 19 2026, 2:01 PM
Subscribers
None

Details

Summary

Ref T13588. This function was deprecated in PHP 7.4 (see D20942) and removed in PHP8.

Test that it exists before calling it so we don't fatal in PHP8.

See https://discourse.phabricator-community.org/t/daemon-fails-on-php-8-0-2-in-utils-php-array-merge-call-w-fix/4568.

Test Plan

Used "|| true" to test the message in PHP7. No actual testing in PHP8, but a user reports a similar patch works.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2021, 5:34 PM
This revision was automatically updated to reflect the committed changes.