It appears that PHUICircleView no longer exists, so calling this moot.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Feb 21 2021
Feb 20 2021
Feb 19 2021
See T13602 for modern followup, recent changes, and plans.
I think this was at least approximately resolved by D21115, which made the default log much quieter and the "debug" log more verbose.
Seems okay for me, too. Calling this resolved, thanks for the report!
I can confirm that logging in with Facebook auth works again now.
That covered everything that looked low-hanging.
From "--trace", client PHID generation seems to be the limiting factor.
A minimal implementation here is probably:
See T13612 for followup.
Continued in T13612.
Feb 18 2021
See T13602 for eventual followup.
I'm going to close this in favor of T13602, which has a more cohesive/modern discussion of the issue. Broadly:
Ah! I like that fix, and it also works for me locally. I think the protocol-length-limit is reasonable to retain on the basis of general sanity, but I'll add the negative lookbehind to further encourage PCRE to run in something resembling O(N) time.
Feb 17 2021
Perhaps too little too late: changing to ((?<!\w)\w{3,}://) also resolves the issue for me. Limiting the protocol to 32 characters seems sane either way.