- When rendering a "no view permission" hovercard, it would be nice to annotate it with an explicit "The user can't see this object" piece of context information.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Feb 5 2021
Feb 5 2021
epriestley requested review of D21548: Propagate the "ContextObject" to Remarkup rendering in timelines.
epriestley added a comment to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers.
epriestley added a comment to T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers.
- Context objects don't make it into timeline rendering engines.
- Context objects don't make it into comment previews.
Feb 4 2021
Feb 4 2021
epriestley triaged T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers as Normal priority.
epriestley closed T13600: Improve workflow for host-to-host Phacility cluster repository migrations of observed repositories as Resolved.
This more-or-less worked as desired. Some minor issues:
epriestley committed rPf63680db381a: (stable) Add an "--ignore-locality" flag to "bin/repository pull" (authored by epriestley).
(stable) Add an "--ignore-locality" flag to "bin/repository pull"
epriestley committed rP00cf93548b70: Add an "--ignore-locality" flag to "bin/repository pull" (authored by epriestley).
Add an "--ignore-locality" flag to "bin/repository pull"
epriestley added a revision to T13600: Improve workflow for host-to-host Phacility cluster repository migrations of observed repositories: Unknown Object (Differential Revision).
epriestley triaged T13600: Improve workflow for host-to-host Phacility cluster repository migrations of observed repositories as Normal priority.
Feb 3 2021
Feb 3 2021
epriestley committed rPa7bd58c4bb26: Remove "AlmanacPropertyInterface" from "AlmanacNamespace" (authored by epriestley).
Remove "AlmanacPropertyInterface" from "AlmanacNamespace"
A new linter should be introduced to detect [private final]...
epriestley committed rARC32fe933f3ae7: Add a lint check for catching "Exception" without catching "Throwable" (authored by epriestley).
Add a lint check for catching "Exception" without catching "Throwable"
epriestley requested review of D21542: Add a lint check for catching "Exception" without catching "Throwable".
epriestley committed rARCc1afa91f9ff8: Annotate the unusual use of "$callback()" in "xsprintf()" (authored by epriestley).
Annotate the unusual use of "$callback()" in "xsprintf()"
epriestley committed rARCc51a996fb0bb: Detect and correct "final private" methods in lint (authored by epriestley).
Detect and correct "final private" methods in lint
epriestley committed rP9502312b60ae: Remove "final" from "private" methods in Phabricator (authored by epriestley).
Remove "final" from "private" methods in Phabricator
epriestley added a revision to T13588: PHP 8 Compatibility: D21539: Detect and correct "final private" methods in lint.
epriestley closed T13598: Lint raises symbol capitalization errors as "Unknown Symbol" errors as Resolved.
I believe that covers all cases of this.
epriestley committed rARCe2b6439a734b: Allow lint to correct the spelling of builtin symbols (authored by epriestley).
Allow lint to correct the spelling of builtin symbols
epriestley committed rARC08dbbbba5ade: When lint identifies an unknown symbol, attempt to correct it if it is… (authored by epriestley).
When lint identifies an unknown symbol, attempt to correct it if it is…
- Slight formatting improvement.
epriestley updated the diff for D21537: When lint identifies an unknown symbol, attempt to correct it if it is miscapitalized.
- "Fix" ruby unit test error, which was a local environment issue.
Feb 2 2021
Feb 2 2021
epriestley closed T13591: Importing repositories may incorrectly queue some tasks at "PRIORITY_COMMIT" as Resolved.
Update the daemon UI to break tasks down by object/container.
See T13591. Tasks now (may) have a containerPHID, and whatever daemon console changes are made in service of dynamic generation should also expose container objects.
epriestley committed rPc9ab36395983: Add "bin/worker delay" and "bin/worker priority" utilities for managing task… (authored by epriestley).
Add "bin/worker delay" and "bin/worker priority" utilities for managing task…
epriestley committed rP365836cd316b: Add basic documentation for using "bin/worker" to manage imports of large… (authored by epriestley).
Add basic documentation for using "bin/worker" to manage imports of large…
epriestley committed rP0203105a94e3: Add more selectors to existing "bin/worker" commands (authored by epriestley).
Add more selectors to existing "bin/worker" commands
epriestley committed rP32942f623250: Introduce storage patch "phases" to allow index-rebuilding patches to execute… (authored by epriestley).
Introduce storage patch "phases" to allow index-rebuilding patches to execute…
epriestley committed rP201e0d29435c: Add support for a "containerPHID" in the worker queue (authored by epriestley).
Add support for a "containerPHID" in the worker queue
epriestley committed rPde70a4ff267e: Improve consistency in use of "via", "objectPHID", and "containerPHID"… (authored by epriestley).
Improve consistency in use of "via", "objectPHID", and "containerPHID"…
epriestley committed rPfaf3f7b7872a: Internally, align commit processing tasks around PHIDs, not IDs (authored by epriestley).
Internally, align commit processing tasks around PHIDs, not IDs
epriestley closed T13590: Large HTTP repository pushes may leave clustered repository write lock held as Resolved.
The affected user in PHI1980 reported that this appeared to be effective in resolving the issue.
Feb 1 2021
Feb 1 2021
epriestley requested review of D21533: Internally, align commit processing tasks around PHIDs, not IDs.
epriestley updated the diff for D21532: Improve consistency in use of "via", "objectPHID", and "containerPHID" parameters in repository workers.
- Include skips for SVN tests with no SVN on system.
epriestley committed rP6d5920fa2d23: Improve help for "bin/policy unlock" to make it explicit that you can name… (authored by epriestley).
Improve help for "bin/policy unlock" to make it explicit that you can name…
(stable) Promote 2021 Week 5
Jan 29 2021
Jan 29 2021
Jan 28 2021
Jan 28 2021
epriestley closed T13596: "INSERT INTO ... SELECT" queries require more database locks than "SELECT" queries as Resolved.
This change appears to have resolved the issue in PHI1954.
epriestley committed rPc339eb01d616: (stable) Correct Diffusion browse behavior when visiting a path URI with no… (authored by epriestley).
(stable) Correct Diffusion browse behavior when visiting a path URI with no…
epriestley committed rP6af8756e798d: (stable) Execute project membership materialization as "SELECT" + "INSERT", not… (authored by epriestley).
(stable) Execute project membership materialization as "SELECT" + "INSERT", not…