Diffusion Phabricator 42c26821ef92

When a revision has only human reviewers but none can view it, show a warning…
42c26821ef92
Actions

Tags

None

Referenced Files

	F8430683: Screen Shot 2021-02-13 at 1.18.47 PM.png
	Feb 13 2021, 9:37 PM

Subscribers

None

Description

When a revision has only human reviewers but none can view it, show a warning banner

Summary: Ref T13602. Warn when a reivison has at least one human reviewer, no non-human reviewers, and no human reviewers can view it.

Test Plan:

Screen Shot 2021-02-13 at 1.18.47 PM.png (284×570 px, 22 KB)

Maniphest Tasks: T13602

Differential Revision: https://secure.phabricator.com/D21556

Details

Provenance

epriestley	Authored on Feb 13 2021, 9:19 PM
epriestley	Pushed on Feb 13 2021, 9:37 PM

Differential Revision

D21556: When a revision has only human reviewers but none can view it, show a warning banner

Parents

rP2f33dedc8b62: When a reviewer can't see a revision, show it clearly in the reviewer list

Branches

Unknown

Tags

Unknown

Tasks

T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers

Build Status

Buildable 25126
Build 34671: Run Core Tests

Event Timeline

epriestley committed rP42c26821ef92: When a revision has only human reviewers but none can view it, show a warning… (authored by epriestley).Feb 13 2021, 9:37 PM

epriestley added a task: T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers.

epriestley added an edge: D21556: When a revision has only human reviewers but none can view it, show a warning banner.

Harbormaster completed building B25126: rP42c26821ef92: When a revision has only human reviewers but none can view it, show a warning….Feb 13 2021, 9:43 PM

Changes (1)

Path

Size

src/

applications/

differential/

customfield/

DifferentialReviewersField.php

rP42c26821ef92

src/applications/differential/customfield/DifferentialReviewersField.php

Loading...